Re: [PATCH 2/3] migration/hmp: Dump global in "info migrate_parameters" instead

["Dr. David Alan Gilbert" <dave@treblig.org>]

* Peter Xu (peterx@redhat.com) wrote:
> "info migrate" is the command people would frequently use to query
> migration status.  We may not want it to dump global configurations because
> dumping the same things over and over won't help.
> 
> The globals are just more suitable for a parameter dump instead.  Hence
> move it over.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>

I think this is a *little* odd, since 'info migrate_parameters'
is a list of the things you can set with 'migrate_set_parameters'
Perhaps it would be better to add it under the 'info migrate -a' option
you add in the next patch?

However, one other thing, the globals stuff prints a
'globals:'  at the start,  but doesn't print anything at the end,
so if you make this change, you end up with out being able to tell
where the globals end and the parameters start, so maybe a
'parameters:' after it?

Dave

> ---
>  migration/migration-hmp-cmds.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c
> index 49c26daed3..0034dbe47f 100644
> --- a/migration/migration-hmp-cmds.c
> +++ b/migration/migration-hmp-cmds.c
> @@ -58,8 +58,6 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)
>  
>      info = qmp_query_migrate(NULL);
>  
> -    migration_global_dump(mon);
> -
>      if (info->blocked_reasons) {
>          strList *reasons = info->blocked_reasons;
>          monitor_printf(mon, "Outgoing migration blocked:\n");
> @@ -235,6 +233,8 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
>  {
>      MigrationParameters *params;
>  
> +    migration_global_dump(mon);
> +
>      params = qmp_query_migrate_parameters(NULL);
>  
>      if (params) {
> -- 
> 2.49.0
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/