qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Juraj Marcin <jmarcin@redhat.com>
Cc: qemu-devel@nongnu.org, Fabiano Rosas <farosas@suse.de>,
	Prasad Pandit <ppandit@redhat.com>,
	"Dr . David Alan Gilbert" <dave@treblig.org>
Subject: Re: [PATCH 3/3] migration/hmp: Add "info migrate -a", reorg the dump
Date: Wed, 14 May 2025 13:37:57 -0400	[thread overview]
Message-ID: <aCTU9aFgbt4-ZbYz@x1.local> (raw)
In-Reply-To: <lu4vgrxl2b5kgg5jdfnucqfvu2wh3rudhya5jarw2auyh62mge@onoeum25ttzm>

On Wed, May 14, 2025 at 04:33:16PM +0200, Juraj Marcin wrote:
> >      if (info->ram) {
> > -        monitor_printf(mon, "transferred ram: %" PRIu64 " kbytes\n",
> > -                       info->ram->transferred >> 10);
> > -        monitor_printf(mon, "throughput: %0.2f mbps\n",
> > +        monitor_printf(mon, "RAM info:\n");
> > +        monitor_printf(mon, "  Bandwidth (mbps): %0.2f\n",
> >                         info->ram->mbps);
> 
> I think the previous name (throughput) was better suited for this
> metric. IIUC '->mbps' is the actual amount of data that has been sent
> over a period of time, which is exactly the definition of throughput.
> Bandwidth, on the other hand, is more of a (theoretical) maximum that
> could be sent.

Heh, it's interesting you found this change, I should have mentioned it.

I think I saw more use of the word "bandwidth" from people to describe
miration throughput, but I don't think I was able to distinguish the two
before, after checking I think you're right.

I believe you demostrated solid understanding in networking issues. :-D

I'll use "Throughput" when repost. Thanks!

-- 
Peter Xu



      reply	other threads:[~2025-05-14 17:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-13 22:09 [PATCH 0/3] migration: Some fix and enhancements to HMP "info migrate" Peter Xu
2025-05-13 22:09 ` [PATCH 1/3] migration: Allow caps to be set when preempt or multifd cap enabled Peter Xu
2025-05-14 12:52   ` Dr. David Alan Gilbert
2025-05-14 13:27   ` Juraj Marcin
2025-05-13 22:09 ` [PATCH 2/3] migration/hmp: Dump global in "info migrate_parameters" instead Peter Xu
2025-05-14 13:25   ` Dr. David Alan Gilbert
2025-05-14 17:29     ` Peter Xu
2025-05-14 13:28   ` Juraj Marcin
2025-05-13 22:09 ` [PATCH 3/3] migration/hmp: Add "info migrate -a", reorg the dump Peter Xu
2025-05-14 13:15   ` Dr. David Alan Gilbert
2025-05-14 14:33   ` Juraj Marcin
2025-05-14 17:37     ` Peter Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aCTU9aFgbt4-ZbYz@x1.local \
    --to=peterx@redhat.com \
    --cc=dave@treblig.org \
    --cc=farosas@suse.de \
    --cc=jmarcin@redhat.com \
    --cc=ppandit@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).