From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A89D5C3ABC9 for ; Thu, 15 May 2025 09:47:27 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uFVAo-0002fv-CG; Thu, 15 May 2025 05:46:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uFVAl-0002fO-Vb for qemu-devel@nongnu.org; Thu, 15 May 2025 05:46:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uFVAk-0003Ud-7u for qemu-devel@nongnu.org; Thu, 15 May 2025 05:46:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747302394; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=UOjYx8O5r0tpPBhguPSMXTZE1MqlrdqONIbluGDK/qc=; b=AfujniHqwpytcqKScIigVV1PPhdX9esAs0oKchOLNyULkbBiQKru+902i5rB1UC+GhPN3m 424rlyA5Fsg2Xr9etUldHAE3q2r7C1yrepy2BeDwTNKTQ1p8KM8NgxiuR84RIURB+RHyBA ZjOROxVxfa7ePxBENB3BIrwGblz8sB0= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-q8FP1xCMMm2z0HyYZKJeYA-1; Thu, 15 May 2025 05:46:33 -0400 X-MC-Unique: q8FP1xCMMm2z0HyYZKJeYA-1 X-Mimecast-MFC-AGG-ID: q8FP1xCMMm2z0HyYZKJeYA_1747302392 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5829D1956050; Thu, 15 May 2025 09:46:31 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.135]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ED27818008F4; Thu, 15 May 2025 09:46:28 +0000 (UTC) Date: Thu, 15 May 2025 10:46:24 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Mario Fleischmann Cc: qemu-devel@nongnu.org, alex.bennee@linaro.org, philmd@linaro.org, armbru@redhat.com, christian.boenig@lauterbach.com Subject: Re: [PATCH v2 03/20] mcd: Introduce MCD server Message-ID: References: <20250430052741.21145-1-mario.fleischmann@lauterbach.com> <20250430052741.21145-4-mario.fleischmann@lauterbach.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250430052741.21145-4-mario.fleischmann@lauterbach.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.686, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Apr 30, 2025 at 07:27:24AM +0200, Mario Fleischmann wrote: > The MCD implementation follows a remote procedure call approach > and will use a client JSON protocol for communication. > > While the MCD server implements the MCD API, the server stub will be > responsible for handling the JSON connection and for dispatching the > corresponding server functions. > > Signed-off-by: Mario Fleischmann > --- > mcd/mcd_server.c | 431 +++++++++++++++++++++++++++++++++++++++++++++++ > mcd/meson.build | 14 ++ > meson.build | 4 + > 3 files changed, 449 insertions(+) > create mode 100644 mcd/mcd_server.c > create mode 100644 mcd/meson.build > > diff --git a/mcd/mcd_server.c b/mcd/mcd_server.c > new file mode 100644 > index 0000000..a20708d > --- /dev/null > +++ b/mcd/mcd_server.c > @@ -0,0 +1,431 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > +/* > + * mcdserver - Multi-Core Debug (MCD) API implementation Nitpick - you don't need to open & close a comment just for the SPDX tag, just let the whole header flow as one comment > + * > + * Copyright (c) 2025 Lauterbach GmbH > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or later. > + * See the COPYING file in the top-level directory. This text should be omitted in any new files - only the SPDX tag is expected/required. I won't repeat them on later patches, but these comments apply to all new files through this whole series. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|