qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhao Liu <zhao1.liu@intel.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Eric Blake <eblake@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH 0/2] qapi/misc-target: Fix the doc of query-sgx and query-sgx-capabilities
Date: Thu, 15 May 2025 14:56:53 +0800	[thread overview]
Message-ID: <aCWQNdZ0dy3641jE@intel.com> (raw)
In-Reply-To: <87cyca4dbt.fsf@pond.sub.org>

On Thu, May 15, 2025 at 08:07:02AM +0200, Markus Armbruster wrote:
> Date: Thu, 15 May 2025 08:07:02 +0200
> From: Markus Armbruster <armbru@redhat.com>
> Subject: Re: [PATCH 0/2] qapi/misc-target: Fix the doc of query-sgx and
>  query-sgx-capabilities
> 
> Zhao Liu <zhao1.liu@intel.com> writes:
> 
> > Hi all,
> >
> > There're 2 QMP commands: query-sgx and query-sgx-capabilities, but
> > their outputs are very similar and the documentation lacks clear
> > differentiation.
> >
>  >From the codes, query-sgx is used to gather guest's SGX capabilities
> > (including SGX related CPUIDs and EPC sections' size, in SGXInfo), and
> > query-sgx-capabilities is used to gather host's SGX capabilities 
> > (descripted by SGXInfo as well).
> >
> > Therefore, fix their documentation to reflect this difference.
> 
> Acked-by: Markus Armbruster <armbru@redhat.com>
> 
> I'll take this through my tree unless Paolo is faster.

Thanks Markus!

I was also thinking you would like "SgxInfo" and "SgxEpcSection" instead
of current "SGXInfo" and "SGXEPCSection".

But I'm not sure if modifying the old names has any compatibility issues
for QAPI? If you think it's ok, I can continue to make the SGX naming
styles more QAPI compliant.

Regards,
Zhao



  reply	other threads:[~2025-05-15  6:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-13 14:31 [PATCH 0/2] qapi/misc-target: Fix the doc of query-sgx and query-sgx-capabilities Zhao Liu
2025-05-13 14:31 ` [PATCH 1/2] qapi/misc-target: Fix the doc related SGXEPCSection Zhao Liu
2025-05-13 14:31 ` [PATCH 2/2] qapi/misc-target: Fix the doc to distinguish query-sgx and query-sgx-capabilities Zhao Liu
2025-05-15  6:07 ` [PATCH 0/2] qapi/misc-target: Fix the doc of " Markus Armbruster
2025-05-15  6:56   ` Zhao Liu [this message]
2025-05-15  7:43     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aCWQNdZ0dy3641jE@intel.com \
    --to=zhao1.liu@intel.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).