From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C742C3DA6D for ; Fri, 23 May 2025 12:09:33 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uIRCD-00070y-MB; Fri, 23 May 2025 08:08:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uIRC4-000707-Pd; Fri, 23 May 2025 08:08:11 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uIRBx-0007aW-NI; Fri, 23 May 2025 08:08:08 -0400 Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54NAJ0sO004905; Fri, 23 May 2025 12:07:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=49Bb4Q XKG8LElInLMFT00GF9LgKQVqsnYyRB5uOd8Lw=; b=fgN+JVq7zpmn5sPS2wcbrs GnfTY92vtnGskX/Z5SBo2sDqsMxCUK/JWwi6Krfgwg2Ts68QaP0a/Q99O3ZEpS7B FNMwEJPuu9ojoIMbAIEY+9YCXK9JImSdcbOR/HdTUGh2PYOEQA5xAWQ++VkdUJiq VxmxdJjmsp3037WAwV2kGcuxeM1+oy6FmUcmyEs2BzmOph8D7EIYm6fRqpOKUcWi PX/Z+Z8AFeZfiJaD6y2mUTKozkPTbDbjZ43gPAzqOSwcUZcy1HNFuT6iitu2klc5 ypnhwAUkh/F03ayCIOFPlNRaEggjCzeJqlg2Rn7cddXPVYTFRtQWLUCnlsR/y6wg == Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46t14jppru-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 May 2025 12:07:55 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 54NAY9Dc015487; Fri, 23 May 2025 12:07:54 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 46rwnnpeau-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 May 2025 12:07:54 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 54NC7oH559638150 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 May 2025 12:07:51 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C83A120043; Fri, 23 May 2025 12:07:50 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AE9BB20040; Fri, 23 May 2025 12:07:50 +0000 (GMT) Received: from vela (unknown [9.111.50.39]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Fri, 23 May 2025 12:07:50 +0000 (GMT) Received: from brueckner by vela with local (Exim 4.98.2) (envelope-from ) id 1uIRBl-000000009IQ-2UL2; Fri, 23 May 2025 14:07:49 +0200 Date: Fri, 23 May 2025 14:07:49 +0200 From: Hendrik Brueckner To: Shalini Chellathurai Saroja Cc: Thomas Huth , Hendrik Brueckner , Nina Schoetterl-Glausch , qemu-s390x mailing list , Daniel Berrange , qemu-devel mailing list Subject: Re: [PATCH v4 1/4] hw/s390x: add SCLP event type CPI Message-ID: References: <5077ebbe-5a4d-4db5-8a1d-067d88244bfb@redhat.com> <2d53cf272ae58736b7904c9a86a2a1ce@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2d53cf272ae58736b7904c9a86a2a1ce@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: auqvUUTYuKaD7saqSiSmFGZXZ2IWogMZ X-Authority-Analysis: v=2.4 cv=XOkwSRhE c=1 sm=1 tr=0 ts=6830651b cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=8nJEP1OIZ-IA:10 a=dt9VzEwgFbYA:10 a=VnNF1IyMAAAA:8 a=20KFwNOVAAAA:8 a=CGpzUJuCNQDKkO0R5_4A:9 a=3ZKOabzyN94A:10 a=wPNLvfGTeEIA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTIzMDEwNiBTYWx0ZWRfX5bvzMX6kaNfR uJsRzxKpPvXmWpGtcg9YeXEB3KnYiNMRXfQ+xXq5oql1FqPeTPa5tTjazW0DyGSTBCTO7/Cv05a N1dKqbvBrB/IAxQGTyANfjpwR7IDklG+Pb36atBVl7mYia++BoOn2KIcuVUxrZ/MBpcjyuE5Foq EUbL7bPHa2U0C0cLkI/gzmEHDqw6vvrzPPMVVtcd5dSrX6uOcfygu6UVlhqw0DbYFhkbd4r+8ld LDudsLstFmXv1GRUSALDPF/Jj5Qw/vhkvprFS1kUnK7CqTRT6fGilbNqAsSK0/JwB0ZUmbcaoiA rWqgvw3m0rGz+XisKisn5Aui2gxefR6rNztC5DQeby2xtkJq/3mdcoZKIXYdebRUy/PYu/zxUMk W4tiTkEzTlrNRp9fq47JSVsWf4hhVcxTV8UTpRPXkv9HrU8GrjEpzt1UoQww20ehHxZF+nhu X-Proofpoint-GUID: auqvUUTYuKaD7saqSiSmFGZXZ2IWogMZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-23_03,2025-05-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 malwarescore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 spamscore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505230106 Received-SPF: pass client-ip=148.163.158.5; envelope-from=brueckner@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, May 06, 2025 at 02:16:18PM +0200, Shalini Chellathurai Saroja wrote: > On 2025-05-06 09:48, Thomas Huth wrote: > > On 06/05/2025 08.48, Nina Schoetterl-Glausch wrote: > > > On Mon, 2025-05-05 at 08:55 +0200, Shalini Chellathurai Saroja wrote: > > > > On 2025-04-28 11:22, Janis Schoetterl-Glausch wrote: > > > > > On Thu, 2025-04-10 at 17:09 +0200, Shalini Chellathurai > > > > > Saroja wrote: > > > > > > Implement the Service-Call Logical Processor (SCLP) event > > > > > > type Control-Program Identification (CPI) in QEMU. This > > > > > > event is used to send CPI identifiers from the guest to the > > > > > > host. The CPI identifiers are: system type, system name, > > > > > > system level and sysplex name. > > > > > > > > > > > > System type: operating system of the guest (e.g. "LINUX"). > > > > > > System name: user configurable name of the guest (e.g. "TESTVM"). > > > > > > System level: distribution and kernel version, if the > > > > > > system type is > > > > > > Linux > > > > > > (e.g. 0x50e00). > > > > > > Sysplex name: name of the cluster which the guest > > > > > > belongs to (if any) > > > > > > (e.g. "PLEX"). > > > > > > > > > > > > Signed-off-by: Shalini Chellathurai Saroja > > > > > > Reviewed-by: Thomas Huth > > > > > > --- > > > > > > hw/s390x/event-facility.c | 2 + > > > > > > hw/s390x/meson.build | 1 + > > > > > > hw/s390x/s390-virtio-ccw.c | 14 +++++ > > > > > > hw/s390x/sclpcpi.c | 92 > > > > > > +++++++++++++++++++++++++++++++ > > > > > > include/hw/s390x/event-facility.h | 13 +++++ > > > > > > 5 files changed, 122 insertions(+) > > > > > > create mode 100644 hw/s390x/sclpcpi.c > > > > > > > > > > > > diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c > > > > > > index 2b0332c20e..60237b8581 100644 > > > > > > --- a/hw/s390x/event-facility.c > > > > > > +++ b/hw/s390x/event-facility.c > > > > > > [...] > > > > > > > It is possible to add the identifiers directly as the properties of > > > > sclpcpi (eg. system type as shown below) and remove the > > > > control-program-id. > > > > > > This is what I meant, drop it from qom. > > Ok. > > > > > > > > > virsh # qemu-monitor-command vm --pretty > > > > '{"execute":"qom-list","arguments": {"path": > > > > "/machine/sclp/s390-sclp-event-facility/sclpcpi"}}' > > > > { > > > > "return": [ > > > > { > > > > "name": "type", > > > > "type": "string" > > > > }, > > > > { > > > > "name": "parent_bus", > > > > "type": "link" > > > > }, > > > > { > > > > "name": "realized", > > > > "type": "bool" > > > > }, > > > > { > > > > "name": "hotplugged", > > > > "type": "bool" > > > > }, > > > > { > > > > "name": "hotpluggable", > > > > "type": "bool" > > > > }, > > > > { > > > > "name": "system_type", > > > > "type": "string" > > > > }, > > > > { > > > > "name": "control-program-id", > > > > "type": "S390ControlProgramId" > > > > } > > > > ], > > > > "id": "libvirt-16" > > > > } > > > > > > > > virsh # qemu-monitor-command vm --pretty '{"execute":"qom-get", > > > > "arguments":{"path":"/machine/sclp/s390-sclp-event-facility/sclpcpi", > > > > "property":"system_type"}}' > > > > { > > > > "return": "LINUX ", > > > > "id": "libvirt-17" > > > > } > > > > > > > > However, Hendrik Brückner suggested to group the identifiers together > > > > during the initial discussion of this line item. So, I would > > > > prefer to > > > > > > They are grouped together under "sclpcpi", no? > > Yes. > > > > > > > > leave this as it is. Please let me know if you still think otherwise. > > > > > > I don't have a strong opinion on this, just wanted to mention it and > > > see what other people say. > > > > I guess it mostly depends on whether there are future plans for using > > the QOM type elsewhere. If this type is supposed to be used in other > > QAPI calls in the future, it makes sense to keep it separate now. If > > there are no such plans, it's maybe easier to integrate the values > > into sclpcpi directly. Hendrik, any opinion from your side? > > > > Thomas > > Hello Hendrik, > > I have provided the output of both the options below. Please let me know > which option do you prefer. > > I have incorporated the other comments. So I will be able to send V5 after > your response. Thank you very much! > > Option 1: Control-program identifiers set as the properties of sclpcpi: > > virsh # qemu-monitor-command vm --pretty '{"execute":"qom-list","arguments": > {"path": "/machine/sclp/s390-sclp-event-facility/sclpcpi"}}' > { > "return": [ > { > [...] > }, > { > "name": "system_level", > "type": "uint64" > }, > { > "name": "system_name", > "type": "string" > }, > { > "name": "system_type", > "type": "string" > }, > { > "name": "timestamp", > "type": "uint64" > }, > { > "name": "sysplex_name", > "type": "string" > } > ], > "id": "libvirt-14" > } I would vote for Option 1 as this seems to be a bit more natural from an object model. There is not much impact for the upcoming changes to consume this information.