From: Peter Xu <peterx@redhat.com>
To: "Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com>
Cc: "Dr. David Alan Gilbert" <dave@treblig.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Fabiano Rosas <farosas@suse.de>,
Prasad Pandit <ppandit@redhat.com>,
Juraj Marcin <jmarcin@redhat.com>
Subject: Re: [PATCH v2 2/2] migration/hmp: Add "info migrate -a", reorg the dump
Date: Mon, 26 May 2025 11:40:14 -0400 [thread overview]
Message-ID: <aDSLXqCAEor3YJE2@x1.local> (raw)
In-Reply-To: <7e3b7343-fbfc-43a4-a0c6-eb9c037da4d3@fujitsu.com>
On Fri, May 23, 2025 at 02:06:42AM +0000, Zhijian Li (Fujitsu) wrote:
>
>
> On 22/05/2025 21:16, Peter Xu wrote:
> > I followed up with Dave's idea, but then added all entries into it, below.
> >
> > Status: postcopy-active
> > Time (ms): total=40504, setup=14, down=145
> > RAM info:
> > Throughput (Mbps): 6102.65
> > Sizes (KiB): pagesize=4, total=16777992
> > Transfers (KiB): transferred=37673019, remain=2136404
> > Channels (KiB): precopy=3, multifd=26108780, postcopy=11563855
> > Page Types: normal=9394288, zero=600672
> > Page Rates (pps): transfer_rate=185875, dirty_rate=278378
>
>
> Regarding the "transfer_rate" and "dirty_rate" fields:
> Would it be clearer to drop the "_rate" suffix since the category header
> "Page Rates (pps)" already implies they are rate metrics?
I made it verbose to be clear while still suitable in a line. I don't feel
strongly - I can drop them when proposing the patch, thanks.
--
Peter Xu
next prev parent reply other threads:[~2025-05-26 15:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 20:01 [PATCH v2 0/2] migration: Some fix and enhancements to HMP "info migrate" Peter Xu
2025-05-14 20:01 ` [PATCH v2 1/2] migration: Allow caps to be set when preempt or multifd cap enabled Peter Xu
2025-05-22 20:15 ` Michael Tokarev
2025-05-14 20:01 ` [PATCH v2 2/2] migration/hmp: Add "info migrate -a", reorg the dump Peter Xu
2025-05-14 20:29 ` Dr. David Alan Gilbert
2025-05-14 21:17 ` Peter Xu
2025-05-14 23:00 ` Dr. David Alan Gilbert
2025-05-21 8:43 ` Zhijian Li (Fujitsu) via
2025-05-21 14:03 ` Peter Xu
2025-05-21 21:04 ` Dr. David Alan Gilbert
2025-05-22 0:55 ` Zhijian Li (Fujitsu) via
2025-05-22 13:16 ` Peter Xu
2025-05-23 2:06 ` Zhijian Li (Fujitsu) via
2025-05-26 15:40 ` Peter Xu [this message]
2025-05-22 1:07 ` Zhijian Li (Fujitsu) via
2025-05-19 11:27 ` [PATCH v2 0/2] migration: Some fix and enhancements to HMP "info migrate" Mario Casquero
2025-05-20 17:03 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDSLXqCAEor3YJE2@x1.local \
--to=peterx@redhat.com \
--cc=dave@treblig.org \
--cc=farosas@suse.de \
--cc=jmarcin@redhat.com \
--cc=lizhijian@fujitsu.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).