Re: [PATCH 05/11] migration: Drop save_live_complete_postcopy hook

[Peter Xu <peterx@redhat.com>]

On Thu, May 29, 2025 at 04:48:41PM +0200, Juraj Marcin wrote:
> On 2025-05-29 16:42, Juraj Marcin wrote:
> > Hi Peter

Hey, Juraj!

> > 
> > On 2025-05-27 17:58, Peter Xu wrote:
> > > The hook is only defined in two vmstate users ("ram" and "block dirty
> > > bitmap"), meanwhile both of them define the hook exactly the same as the
> > > precopy version.  Hence, this postcopy version isn't needed.
> > > 
> > > No functional change intended.
> > 
> > Could be some future users, that would benefit from separate hooks for
> > precopy and postcopy?

There's nothing that I'm aware of.  Normally we should only provide
separate hook until that comes, and then review the hook together with the
use case.

> > 
> > In case we are going to drop it, I think the '_precopy' suffix could be
> > dropped too, as the handler would be used for postcopy too.
> 
> Never mind, just noticed it's in the next patch...

Yep.  I can squash that into this one; it's pretty small so maybe it's
fine.  I'll keep it separate as of now, but if anyone thinks it better I
can squash them.

-- 
Peter Xu