* [PATCH v12 0/6] Specifying cache topology on ARM
@ 2025-06-04 13:34 Alireza Sanaee via
2025-06-04 13:34 ` [PATCH v12 1/6] target/arm/tcg: increase cache level for cpu=max Alireza Sanaee via
` (5 more replies)
0 siblings, 6 replies; 14+ messages in thread
From: Alireza Sanaee via @ 2025-06-04 13:34 UTC (permalink / raw)
To: mst
Cc: anisinha, armbru, berrange, dapeng1.mi, eric.auger, farman,
gustavo.romero, imammedo, jiangkunkun, jonathan.cameron, linuxarm,
mtosatti, peter.maydell, philmd, qemu-arm, qemu-devel,
richard.henderson, shameerali.kolothum.thodi, shannon.zhaosl,
yangyicong, zhao1.liu, maobibo
Specifying the cache layout in virtual machines is useful for
applications and operating systems to fetch accurate information about
the cache structure and make appropriate adjustments. Enforcing correct
sharing information can lead to better optimizations. Patches that allow
for an interface to express caches was landed in the prior cycles. This
patchset uses the interface as a foundation. Thus, the device tree and
ACPI/PPTT table, and device tree are populated based on
user-provided information and CPU topology.
Example:
+----------------+ +----------------+
| Socket 0 | | Socket 1 |
| (L3 Cache) | | (L3 Cache) |
+--------+-------+ +--------+-------+
| |
+--------+--------+ +--------+--------+
| Cluster 0 | | Cluster 0 |
| (L2 Cache) | | (L2 Cache) |
+--------+--------+ +--------+--------+
| |
+--------+--------+ +--------+--------+ +--------+--------+ +--------+----+
| Core 0 | | Core 1 | | Core 0 | | Core 1 |
| (L1i, L1d) | | (L1i, L1d) | | (L1i, L1d) | | (L1i, L1d)|
+--------+--------+ +--------+--------+ +--------+--------+ +--------+----+
| | | |
+--------+ +--------+ +--------+ +--------+
|Thread 0| |Thread 1| |Thread 1| |Thread 0|
+--------+ +--------+ +--------+ +--------+
|Thread 1| |Thread 0| |Thread 0| |Thread 1|
+--------+ +--------+ +--------+ +--------+
The following command will represent the system relying on **ACPI PPTT tables**.
./qemu-system-aarch64 \
-machine virt,smp-cache.0.cache=l1i,smp-cache.0.topology=core,smp-cache.1.cache=l1d,smp-cache.1.topology=core,smp-cache.2.cache=l2,smp-cache.2.topology=cluseter,smp-cache.3.cache=l3,smp-cache.3.topology=socket \
-cpu max \
-m 2048 \
-smp sockets=2,clusters=1,cores=2,threads=2 \
-kernel ./Image.gz \
-append "console=ttyAMA0 root=/dev/ram rdinit=/init acpi=force" \
-initrd rootfs.cpio.gz \
-bios ./edk2-aarch64-code.fd \
-nographic
The following command will represent the system relying on **the device tree**.
./qemu-system-aarch64 \
-machine virt,acpi=off,smp-cache.0.cache=l1i,smp-cache.0.topology=core,smp-cache.1.cache=l1d,smp-cache.1.topology=core,smp-cache.2.cache=l2,smp-cache.2.topology=cluseter,smp-cache.3.cache=l3,smp-cache.3.topology=socket \
-cpu max \
-m 2048 \
-smp sockets=2,clusters=1,cores=2,threads=2 \
-kernel ./Image.gz \
-append "console=ttyAMA0 root=/dev/ram rdinit=/init acpi=off" \
-initrd rootfs.cpio.gz \
-nographic
Failure cases:
1) There are scenarios where caches exist in systems' registers but
left unspecified by users. In this case qemu returns failure.
2) SMT threads cannot share caches which is not very common. More
discussions here [1].
Currently only three levels of caches are supported to be specified from
the command line. However, increasing the value does not require
significant changes. Further, this patch assumes l2 and l3 unified
caches and does not allow l(2/3)(i/d). The level terminology is
thread/core/cluster/socket right now. Hierarchy assumed in this patch:
Socket level = Cluster level + 1 = Core level + 2 = Thread level + 3;
TODO:
1) Making the code to work with arbitrary levels
2) Separated data and instruction cache at L2 and L3.
3) Additional cache controls. e.g. size of L3 may not want to just
match the underlying system, because only some of the associated host
CPUs may be bound to this VM.
[1] https://lore.kernel.org/devicetree-spec/20250203120527.3534-1-alireza.sanaee@huawei.com/
Change Log:
v11->v12:
* Patch #4 couldn't not merge properly as the main file diverged. Now it is fixed (hopefully).
* Loonarch build_pptt function updated.
* Rebased on 09be8a511a2e278b45729d7b065d30c68dd699d0.
v10->v11:
* Fix some coding style issues.
* Rename some variables.
v9->v10:
* PPTT rev down to 2.
v8->v9:
* rebase to 10
* Fixed a bug in device-tree generation related to a scenario when
caches are shared at core in higher levels than 1.
v7->v8:
* rebase: Merge tag 'pull-nbd-2024-08-26' of https://repo.or.cz/qemu/ericb into staging
* I mis-included a file in patch #4 and I removed it in this one.
v6->v7:
* Intel stuff got pulled up, so rebase.
* added some discussions on device tree.
v5->v6:
* Minor bug fix.
* rebase based on new Intel patchset.
- https://lore.kernel.org/qemu-devel/20250110145115.1574345-1-zhao1.liu@intel.com/
v4->v5:
* Added Reviewed-by tags.
* Applied some comments.
v3->v4:
* Device tree added.
Depends-on: Building PPTT with root node and identical implementation flag
Depends-on: Msg-id: 20250604115233.1234-1-alireza.sanaee@huawei.com
Alireza Sanaee (6):
target/arm/tcg: increase cache level for cpu=max
arm/virt.c: add cache hierarchy to device tree
bios-tables-test: prepare to change ARM ACPI virt PPTT
hw/acpi: add cache hierarchy to pptt table
tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology
Update the ACPI tables based on new aml-build.c
hw/acpi/aml-build.c | 222 ++++++++++++-
hw/arm/virt-acpi-build.c | 8 +-
hw/arm/virt.c | 359 ++++++++++++++++++++-
hw/cpu/core.c | 92 ++++++
hw/loongarch/virt-acpi-build.c | 2 +-
include/hw/acpi/aml-build.h | 4 +-
include/hw/arm/virt.h | 7 +-
include/hw/cpu/core.h | 27 ++
target/arm/tcg/cpu64.c | 13 +
tests/data/acpi/aarch64/virt/PPTT.topology | Bin 356 -> 540 bytes
tests/qtest/bios-tables-test.c | 4 +
11 files changed, 725 insertions(+), 13 deletions(-)
--
2.43.0
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v12 1/6] target/arm/tcg: increase cache level for cpu=max
2025-06-04 13:34 [PATCH v12 0/6] Specifying cache topology on ARM Alireza Sanaee via
@ 2025-06-04 13:34 ` Alireza Sanaee via
2025-06-04 13:34 ` [PATCH v12 2/6] arm/virt.c: add cache hierarchy to device tree Alireza Sanaee via
` (4 subsequent siblings)
5 siblings, 0 replies; 14+ messages in thread
From: Alireza Sanaee via @ 2025-06-04 13:34 UTC (permalink / raw)
To: mst
Cc: anisinha, armbru, berrange, dapeng1.mi, eric.auger, farman,
gustavo.romero, imammedo, jiangkunkun, jonathan.cameron, linuxarm,
mtosatti, peter.maydell, philmd, qemu-arm, qemu-devel,
richard.henderson, shameerali.kolothum.thodi, shannon.zhaosl,
yangyicong, zhao1.liu, maobibo
This patch addresses cache description in the `aarch64_max_tcg_initfn`
function for cpu=max. It introduces three layers of caches and modifies
the cache description registers accordingly.
Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
target/arm/tcg/cpu64.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c
index 5d8ed2794d..87e68b10c3 100644
--- a/target/arm/tcg/cpu64.c
+++ b/target/arm/tcg/cpu64.c
@@ -1086,6 +1086,19 @@ void aarch64_max_tcg_initfn(Object *obj)
uint64_t t;
uint32_t u;
+ /*
+ * Expanded cache set
+ */
+ cpu->clidr = 0x8200123; /* 4 4 3 in 3 bit fields */
+ /* 64KB L1 dcache */
+ cpu->ccsidr[0] = make_ccsidr(CCSIDR_FORMAT_LEGACY, 4, 64, 64 * KiB, 7);
+ /* 64KB L1 icache */
+ cpu->ccsidr[1] = make_ccsidr(CCSIDR_FORMAT_LEGACY, 4, 64, 64 * KiB, 2);
+ /* 1MB L2 unified cache */
+ cpu->ccsidr[2] = make_ccsidr(CCSIDR_FORMAT_LEGACY, 8, 64, 1 * MiB, 7);
+ /* 2MB L3 unified cache */
+ cpu->ccsidr[4] = make_ccsidr(CCSIDR_FORMAT_LEGACY, 8, 64, 2 * MiB, 7);
+
/*
* Unset ARM_FEATURE_BACKCOMPAT_CNTFRQ, which we would otherwise default
* to because we started with aarch64_a57_initfn(). A 'max' CPU might
--
2.43.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v12 2/6] arm/virt.c: add cache hierarchy to device tree
2025-06-04 13:34 [PATCH v12 0/6] Specifying cache topology on ARM Alireza Sanaee via
2025-06-04 13:34 ` [PATCH v12 1/6] target/arm/tcg: increase cache level for cpu=max Alireza Sanaee via
@ 2025-06-04 13:34 ` Alireza Sanaee via
2025-06-05 9:44 ` Zhao Liu
2025-06-04 13:34 ` [PATCH v12 3/6] bios-tables-test: prepare to change ARM ACPI virt PPTT Alireza Sanaee via
` (3 subsequent siblings)
5 siblings, 1 reply; 14+ messages in thread
From: Alireza Sanaee via @ 2025-06-04 13:34 UTC (permalink / raw)
To: mst
Cc: anisinha, armbru, berrange, dapeng1.mi, eric.auger, farman,
gustavo.romero, imammedo, jiangkunkun, jonathan.cameron, linuxarm,
mtosatti, peter.maydell, philmd, qemu-arm, qemu-devel,
richard.henderson, shameerali.kolothum.thodi, shannon.zhaosl,
yangyicong, zhao1.liu, maobibo
Specify which layer (core/cluster/socket) caches found at in the CPU
topology. Updating cache topology to device tree (spec v0.4).
Example:
Here, 2 sockets (packages), and 2 clusters, 4 cores and 2 threads
created, in aggregate 2*2*4*2 logical cores. In the smp-cache object,
cores will have l1d and l1i. However, extending this is not difficult).
The clusters will share a unified l2 level cache, and finally sockets
will share l3. In this patch, threads will share l1 caches by default,
but this can be adjusted if case required.
Currently only three levels of caches are supported. The patch does not
allow partial declaration of caches. In another word, all caches must be
defined or caches must be skipped.
./qemu-system-aarch64 \
-machine virt,\
smp-cache.0.cache=l1i,smp-cache.0.topology=core,\
smp-cache.1.cache=l1d,smp-cache.1.topology=core,\
smp-cache.2.cache=l2,smp-cache.2.topology=cluster,\
smp-cache.3.cache=l3,smp-cache.3.topology=socket\
-cpu max \
-m 2048 \
-smp sockets=2,clusters=2,cores=4,threads=1 \
-kernel ./Image.gz \
-append "console=ttyAMA0 root=/dev/ram rdinit=/init acpi=force" \
-initrd rootfs.cpio.gz \
-bios ./edk2-aarch64-code.fd \
-nographic
For instance, following device tree will be generated for a scenario
where we have 2 sockets, 2 clusters, 2 cores and 2 threads, in total 16
PEs. L1i and L1d are private to each thread, and l2 and l3 are shared at
socket level as an example.
Limitation: SMT cores cannot share L1 cache for now. This
problem does not exist in PPTT tables.
Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
Co-developed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Signed-off-by: Jonathan Cameron <jonathan.cameron@huawei.com>
---
hw/arm/virt.c | 359 +++++++++++++++++++++++++++++++++++++++++-
hw/cpu/core.c | 92 +++++++++++
include/hw/arm/virt.h | 7 +-
include/hw/cpu/core.h | 27 ++++
4 files changed, 483 insertions(+), 2 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 9a6cd085a3..fcea2124bb 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -238,6 +238,132 @@ static const int a15irqmap[] = {
[VIRT_PLATFORM_BUS] = 112, /* ...to 112 + PLATFORM_BUS_NUM_IRQS -1 */
};
+unsigned int virt_get_caches(const VirtMachineState *vms,
+ CPUCorePPTTCaches *caches)
+{
+ ARMCPU *armcpu = ARM_CPU(qemu_get_cpu(0)); /* assume homogeneous CPUs */
+ bool ccidx = cpu_isar_feature(any_ccidx, armcpu);
+ unsigned int num_cache, i;
+ int level_instr = 1, level_data = 1;
+
+ for (i = 0, num_cache = 0; i < CPU_MAX_CACHES; i++, num_cache++) {
+ int type = (armcpu->clidr >> (3 * i)) & 7;
+ int bank_index;
+ int level;
+ CPUCoreCacheType cache_type;
+
+ if (type == 0) {
+ break;
+ }
+
+ switch (type) {
+ case 1:
+ cache_type = CPU_CORE_INSTRUCTION;
+ level = level_instr;
+ break;
+ case 2:
+ cache_type = CPU_CORE_DATA;
+ level = level_data;
+ break;
+ case 4:
+ cache_type = CPU_CORE_UNIFIED;
+ level = level_instr > level_data ? level_instr : level_data;
+ break;
+ case 3: /* Split - Do data first */
+ cache_type = CPU_CORE_DATA;
+ level = level_data;
+ break;
+ default:
+ error_setg(&error_abort, "Unrecognized cache type");
+ return 0;
+ }
+ /*
+ * ccsidr is indexed using both the level and whether it is
+ * an instruction cache. Unified caches use the same storage
+ * as data caches.
+ */
+ bank_index = (i * 2) | ((type == 1) ? 1 : 0);
+ if (ccidx) {
+ caches[num_cache] = (CPUCorePPTTCaches) {
+ .type = cache_type,
+ .level = level,
+ .linesize = 1 << (FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1,
+ CCIDX_LINESIZE) + 4),
+ .associativity = FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1,
+ CCIDX_ASSOCIATIVITY) + 1,
+ .sets = FIELD_EX64(armcpu->ccsidr[bank_index], CCSIDR_EL1,
+ CCIDX_NUMSETS) + 1,
+ };
+ } else {
+ caches[num_cache] = (CPUCorePPTTCaches) {
+ .type = cache_type,
+ .level = level,
+ .linesize = 1 << (FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1, LINESIZE) + 4),
+ .associativity = FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1,
+ ASSOCIATIVITY) + 1,
+ .sets = FIELD_EX64(armcpu->ccsidr[bank_index], CCSIDR_EL1,
+ NUMSETS) + 1,
+ };
+ }
+ caches[num_cache].size = caches[num_cache].associativity *
+ caches[num_cache].sets * caches[num_cache].linesize;
+
+ /* Break one 'split' entry up into two records */
+ if (type == 3) {
+ num_cache++;
+ bank_index = (i * 2) | 1;
+ if (ccidx) {
+ /* Instruction cache: bottom bit set when reading banked reg */
+ caches[num_cache] = (CPUCorePPTTCaches) {
+ .type = CPU_CORE_INSTRUCTION,
+ .level = level_instr,
+ .linesize = 1 << (FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1,
+ CCIDX_LINESIZE) + 4),
+ .associativity = FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1,
+ CCIDX_ASSOCIATIVITY) + 1,
+ .sets = FIELD_EX64(armcpu->ccsidr[bank_index], CCSIDR_EL1,
+ CCIDX_NUMSETS) + 1,
+ };
+ } else {
+ caches[num_cache] = (CPUCorePPTTCaches) {
+ .type = CPU_CORE_INSTRUCTION,
+ .level = level_instr,
+ .linesize = 1 << (FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1, LINESIZE) + 4),
+ .associativity = FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1,
+ ASSOCIATIVITY) + 1,
+ .sets = FIELD_EX64(armcpu->ccsidr[bank_index], CCSIDR_EL1,
+ NUMSETS) + 1,
+ };
+ }
+ caches[num_cache].size = caches[num_cache].associativity *
+ caches[num_cache].sets * caches[num_cache].linesize;
+ }
+ switch (type) {
+ case 1:
+ level_instr++;
+ break;
+ case 2:
+ level_data++;
+ break;
+ case 3:
+ case 4:
+ level_instr++;
+ level_data++;
+ break;
+ }
+ }
+
+ return num_cache;
+}
+
static void create_randomness(MachineState *ms, const char *node)
{
struct {
@@ -416,13 +542,105 @@ static void fdt_add_timer_nodes(const VirtMachineState *vms)
}
}
+static void add_cache_node(void *fdt, char * nodepath, CPUCorePPTTCaches cache,
+ uint32_t *next_level)
+{
+ /* Assume L2/3 are unified caches. */
+
+ uint32_t phandle;
+
+ qemu_fdt_add_path(fdt, nodepath);
+ phandle = qemu_fdt_alloc_phandle(fdt);
+ qemu_fdt_setprop_cell(fdt, nodepath, "phandle", phandle);
+ qemu_fdt_setprop_cell(fdt, nodepath, "cache-level", cache.level);
+ qemu_fdt_setprop_cell(fdt, nodepath, "cache-size", cache.size);
+ qemu_fdt_setprop_cell(fdt, nodepath, "cache-block-size", cache.linesize);
+ qemu_fdt_setprop_cell(fdt, nodepath, "cache-sets", cache.sets);
+ qemu_fdt_setprop(fdt, nodepath, "cache-unified", NULL, 0);
+ qemu_fdt_setprop_string(fdt, nodepath, "compatible", "cache");
+ if (cache.level != 3) {
+ /* top level cache doesn't have next-level-cache property */
+ qemu_fdt_setprop_cell(fdt, nodepath, "next-level-cache", *next_level);
+ }
+
+ *next_level = phandle;
+}
+
+static bool add_cpu_cache_hierarchy(void *fdt, CPUCorePPTTCaches* cache,
+ uint32_t cache_cnt,
+ uint32_t top_level,
+ uint32_t bottom_level,
+ uint32_t cpu_id,
+ uint32_t *next_level) {
+ bool found_cache = false;
+ char *nodepath;
+
+ for (int level = top_level; level >= bottom_level; level--) {
+ for (int i = 0; i < cache_cnt; i++) {
+ if (i != level) {
+ continue;
+ }
+
+ nodepath = g_strdup_printf("/cpus/cpu@%d/l%d-cache",
+ cpu_id, level);
+ add_cache_node(fdt, nodepath, cache[i], next_level);
+ found_cache = true;
+ g_free(nodepath);
+
+ }
+ }
+
+ return found_cache;
+}
+
+static void set_cache_properties(void *fdt, const char *nodename,
+ const char *prefix, CPUCorePPTTCaches cache)
+{
+ char prop_name[64];
+
+ snprintf(prop_name, sizeof(prop_name), "%s-block-size", prefix);
+ qemu_fdt_setprop_cell(fdt, nodename, prop_name, cache.linesize);
+
+ snprintf(prop_name, sizeof(prop_name), "%s-size", prefix);
+ qemu_fdt_setprop_cell(fdt, nodename, prop_name, cache.size);
+
+ snprintf(prop_name, sizeof(prop_name), "%s-sets", prefix);
+ qemu_fdt_setprop_cell(fdt, nodename, prop_name, cache.sets);
+}
+
static void fdt_add_cpu_nodes(const VirtMachineState *vms)
{
int cpu;
int addr_cells = 1;
const MachineState *ms = MACHINE(vms);
+ const MachineClass *mc = MACHINE_GET_CLASS(ms);
const VirtMachineClass *vmc = VIRT_MACHINE_GET_CLASS(vms);
int smp_cpus = ms->smp.cpus;
+ int socket_id, cluster_id, core_id;
+ uint32_t next_level = 0;
+ uint32_t socket_offset = 0;
+ uint32_t cluster_offset = 0;
+ uint32_t core_offset = 0;
+ int last_socket = -1;
+ int last_cluster = -1;
+ int last_core = -1;
+ int top_node = 3;
+ int top_cluster = 3;
+ int top_core = 3;
+ int bottom_node = 3;
+ int bottom_cluster = 3;
+ int bottom_core = 3;
+ unsigned int num_cache;
+ CPUCorePPTTCaches caches[16];
+ bool cache_created = false;
+
+ num_cache = virt_get_caches(vms, caches);
+
+ if (mc->smp_props.has_caches &&
+ partial_cache_description(ms, caches, num_cache)) {
+ error_setg(&error_fatal, "Missing cache description");
+ return;
+ }
/*
* See Linux Documentation/devicetree/bindings/arm/cpus.yaml
@@ -451,9 +669,14 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms)
qemu_fdt_setprop_cell(ms->fdt, "/cpus", "#size-cells", 0x0);
for (cpu = smp_cpus - 1; cpu >= 0; cpu--) {
+ socket_id = cpu / (ms->smp.clusters * ms->smp.cores * ms->smp.threads);
+ cluster_id = cpu / (ms->smp.cores * ms->smp.threads) % ms->smp.clusters;
+ core_id = cpu / (ms->smp.threads) % ms->smp.cores;
+
char *nodename = g_strdup_printf("/cpus/cpu@%d", cpu);
ARMCPU *armcpu = ARM_CPU(qemu_get_cpu(cpu));
CPUState *cs = CPU(armcpu);
+ const char *prefix = NULL;
qemu_fdt_add_subnode(ms->fdt, nodename);
qemu_fdt_setprop_string(ms->fdt, nodename, "device_type", "cpu");
@@ -483,6 +706,135 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms)
qemu_fdt_alloc_phandle(ms->fdt));
}
+ if (!vmc->no_cpu_topology && num_cache) {
+ for (uint8_t i = 0; i < num_cache; i++) {
+ /* only level 1 in the CPU entry */
+ if (caches[i].level > 1) {
+ continue;
+ }
+
+ if (caches[i].type == CPU_CORE_INSTRUCTION) {
+ prefix = "i-cache";
+ } else if (caches[i].type == CPU_CORE_DATA) {
+ prefix = "d-cache";
+ } else if (caches[i].type == CPU_CORE_UNIFIED) {
+ error_setg(&error_fatal,
+ "Unified type is not implemented at level %d",
+ caches[i].level);
+ return;
+ } else {
+ error_setg(&error_fatal, "Undefined cache type");
+ return;
+ }
+
+ set_cache_properties(ms->fdt, nodename, prefix, caches[i]);
+ }
+ }
+
+ if (socket_id != last_socket) {
+ bottom_node = top_node;
+ /* this assumes socket as the highest topological level */
+ socket_offset = 0;
+ cluster_offset = 0;
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_SOCKET) &&
+ find_the_lowest_level_cache_defined_at_level(ms,
+ &bottom_node,
+ CPU_TOPOLOGY_LEVEL_SOCKET)) {
+
+ if (bottom_node == 1 && !virt_is_acpi_enabled(vms)) {
+ error_setg(&error_fatal,
+ "Cannot share L1 at socket_id %d. DT limiation on "
+ "sharing at cache level = 1",
+ socket_id);
+ }
+
+ cache_created = add_cpu_cache_hierarchy(ms->fdt, caches,
+ num_cache,
+ top_node,
+ bottom_node, cpu,
+ &socket_offset);
+
+ if (!cache_created) {
+ error_setg(&error_fatal,
+ "Socket: No caches at levels %d-%d",
+ top_node, bottom_node);
+ return;
+ }
+
+ top_cluster = bottom_node - 1;
+ }
+
+ last_socket = socket_id;
+ }
+
+ if (cluster_id != last_cluster) {
+ bottom_cluster = top_cluster;
+ cluster_offset = socket_offset;
+ core_offset = 0;
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_CLUSTER) &&
+ find_the_lowest_level_cache_defined_at_level(ms,
+ &bottom_cluster,
+ CPU_TOPOLOGY_LEVEL_CLUSTER)) {
+
+ cache_created = add_cpu_cache_hierarchy(ms->fdt, caches,
+ num_cache,
+ top_cluster,
+ bottom_cluster, cpu,
+ &cluster_offset);
+ if (bottom_cluster == 1 && !virt_is_acpi_enabled(vms)) {
+ error_setg(&error_fatal,
+ "Cannot share L1 at socket_id %d, cluster_id %d. "
+ "DT limitation on sharing at cache level = 1.",
+ socket_id, cluster_id);
+ }
+
+ if (!cache_created) {
+ error_setg(&error_fatal,
+ "Cluster: No caches at levels %d-%d",
+ top_cluster, bottom_cluster);
+ return;
+ }
+
+ top_core = bottom_cluster - 1;
+ } else if (top_cluster == bottom_node - 1) {
+ top_core = bottom_node - 1;
+ }
+
+ last_cluster = cluster_id;
+ }
+
+ if (core_id != last_core) {
+ bottom_core = top_core;
+ core_offset = cluster_offset;
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_CORE) &&
+ find_the_lowest_level_cache_defined_at_level(ms,
+ &bottom_core,
+ CPU_TOPOLOGY_LEVEL_CORE)) {
+
+ if (bottom_core > 1) {
+ cache_created = add_cpu_cache_hierarchy(ms->fdt,
+ caches,
+ num_cache,
+ top_core,
+ bottom_core, cpu,
+ &core_offset);
+
+ if (!cache_created) {
+ error_setg(&error_fatal,
+ "Core: No caches at levels %d-%d",
+ top_core, bottom_core);
+ return;
+ }
+ }
+ }
+
+ last_core = core_id;
+ }
+
+ next_level = core_offset;
+ qemu_fdt_setprop_cell(ms->fdt, nodename, "next-level-cache",
+ next_level);
+
g_free(nodename);
}
@@ -2650,7 +3002,7 @@ static void virt_set_oem_table_id(Object *obj, const char *value,
}
-bool virt_is_acpi_enabled(VirtMachineState *vms)
+bool virt_is_acpi_enabled(const VirtMachineState *vms)
{
if (vms->acpi == ON_OFF_AUTO_OFF) {
return false;
@@ -3176,6 +3528,11 @@ static void virt_machine_class_init(ObjectClass *oc, const void *data)
hc->unplug = virt_machine_device_unplug_cb;
mc->nvdimm_supported = true;
mc->smp_props.clusters_supported = true;
+ /* Supported caches */
+ mc->smp_props.cache_supported[CACHE_LEVEL_AND_TYPE_L1D] = true;
+ mc->smp_props.cache_supported[CACHE_LEVEL_AND_TYPE_L1I] = true;
+ mc->smp_props.cache_supported[CACHE_LEVEL_AND_TYPE_L2] = true;
+ mc->smp_props.cache_supported[CACHE_LEVEL_AND_TYPE_L3] = true;
mc->auto_enable_numa_with_memhp = true;
mc->auto_enable_numa_with_memdev = true;
/* platform instead of architectural choice */
diff --git a/hw/cpu/core.c b/hw/cpu/core.c
index 5cb2e9a7f5..7339782663 100644
--- a/hw/cpu/core.c
+++ b/hw/cpu/core.c
@@ -102,4 +102,96 @@ static void cpu_core_register_types(void)
type_register_static(&cpu_core_type_info);
}
+bool cache_described_at(const MachineState *ms, CpuTopologyLevel level)
+{
+ if (machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L3) == level ||
+ machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L2) == level ||
+ machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1I) == level ||
+ machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1D) == level) {
+ return true;
+ }
+ return false;
+}
+
+int partial_cache_description(const MachineState *ms, CPUCorePPTTCaches *caches,
+ int num_caches)
+{
+ int level, c;
+
+ for (level = 1; level < num_caches; level++) {
+ for (c = 0; c < num_caches; c++) {
+ if (caches[c].level != level) {
+ continue;
+ }
+
+ switch (level) {
+ case 1:
+ /*
+ * L1 cache is assumed to have both L1I and L1D available.
+ * Technically both need to be checked.
+ */
+ if (machine_get_cache_topo_level(ms,
+ CACHE_LEVEL_AND_TYPE_L1I) ==
+ CPU_TOPOLOGY_LEVEL_DEFAULT) {
+ return level;
+ }
+ break;
+ case 2:
+ if (machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L2) ==
+ CPU_TOPOLOGY_LEVEL_DEFAULT) {
+ return level;
+ }
+ break;
+ case 3:
+ if (machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L3) ==
+ CPU_TOPOLOGY_LEVEL_DEFAULT) {
+ return level;
+ }
+ break;
+ }
+ }
+ }
+
+ return 0;
+}
+
+/*
+ * This function assumes l3 and l2 have unified cache and l1 is split l1d
+ * and l1i, and further prepares the lowest cache level for a topology
+ * level. The info will be fed to build_caches to create caches at the
+ * right level.
+ */
+bool find_the_lowest_level_cache_defined_at_level(const MachineState *ms,
+ int *level_found,
+ CpuTopologyLevel topo_level) {
+
+ CpuTopologyLevel level;
+
+ level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1I);
+ if (level == topo_level) {
+ *level_found = 1;
+ return true;
+ }
+
+ level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1D);
+ if (level == topo_level) {
+ *level_found = 1;
+ return true;
+ }
+
+ level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L2);
+ if (level == topo_level) {
+ *level_found = 2;
+ return true;
+ }
+
+ level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L3);
+ if (level == topo_level) {
+ *level_found = 3;
+ return true;
+ }
+
+ return false;
+}
+
type_init(cpu_core_register_types)
diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h
index 9a1b0f53d2..644198bb1b 100644
--- a/include/hw/arm/virt.h
+++ b/include/hw/arm/virt.h
@@ -39,6 +39,7 @@
#include "system/kvm.h"
#include "hw/intc/arm_gicv3_common.h"
#include "qom/object.h"
+#include "hw/cpu/core.h"
#define NUM_GICV2M_SPIS 64
#define NUM_VIRTIO_TRANSPORTS 32
@@ -50,6 +51,8 @@
/* GPIO pins */
#define GPIO_PIN_POWER_BUTTON 3
+#define CPU_MAX_CACHES 16
+
enum {
VIRT_FLASH,
VIRT_MEM,
@@ -182,7 +185,9 @@ struct VirtMachineState {
OBJECT_DECLARE_TYPE(VirtMachineState, VirtMachineClass, VIRT_MACHINE)
void virt_acpi_setup(VirtMachineState *vms);
-bool virt_is_acpi_enabled(VirtMachineState *vms);
+bool virt_is_acpi_enabled(const VirtMachineState *vms);
+unsigned int virt_get_caches(const VirtMachineState *vms,
+ CPUCorePPTTCaches *caches);
/* Return number of redistributors that fit in the specified region */
static uint32_t virt_redist_capacity(VirtMachineState *vms, int region)
diff --git a/include/hw/cpu/core.h b/include/hw/cpu/core.h
index 98ab91647e..0f7bf8bc28 100644
--- a/include/hw/cpu/core.h
+++ b/include/hw/cpu/core.h
@@ -11,6 +11,7 @@
#include "hw/qdev-core.h"
#include "qom/object.h"
+#include "qapi/qapi-types-machine-common.h"
#define TYPE_CPU_CORE "cpu-core"
@@ -25,6 +26,32 @@ struct CPUCore {
int nr_threads;
};
+typedef enum CPUCacheType {
+ CPU_CORE_DATA,
+ CPU_CORE_INSTRUCTION,
+ CPU_CORE_UNIFIED,
+} CPUCoreCacheType;
+
+typedef struct CPUPPTTCaches {
+ CPUCoreCacheType type;
+ uint32_t pptt_id;
+ uint32_t sets;
+ uint32_t size;
+ uint32_t level;
+ uint16_t linesize;
+ uint8_t attributes; /* write policy: 0x0 write back, 0x1 write through */
+ uint8_t associativity;
+} CPUCorePPTTCaches;
+
+int partial_cache_description(const MachineState *ms, CPUCorePPTTCaches *caches,
+ int num_caches);
+
+bool cache_described_at(const MachineState *ms, CpuTopologyLevel level);
+
+bool find_the_lowest_level_cache_defined_at_level(const MachineState *ms,
+ int *level_found,
+ CpuTopologyLevel topo_level);
+
/* Note: topology field names need to be kept in sync with
* 'CpuInstanceProperties' */
--
2.43.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v12 3/6] bios-tables-test: prepare to change ARM ACPI virt PPTT
2025-06-04 13:34 [PATCH v12 0/6] Specifying cache topology on ARM Alireza Sanaee via
2025-06-04 13:34 ` [PATCH v12 1/6] target/arm/tcg: increase cache level for cpu=max Alireza Sanaee via
2025-06-04 13:34 ` [PATCH v12 2/6] arm/virt.c: add cache hierarchy to device tree Alireza Sanaee via
@ 2025-06-04 13:34 ` Alireza Sanaee via
2025-06-05 8:29 ` Zhao Liu
2025-06-04 13:34 ` [PATCH v12 4/6] hw/acpi: add cache hierarchy to pptt table Alireza Sanaee via
` (2 subsequent siblings)
5 siblings, 1 reply; 14+ messages in thread
From: Alireza Sanaee via @ 2025-06-04 13:34 UTC (permalink / raw)
To: mst
Cc: anisinha, armbru, berrange, dapeng1.mi, eric.auger, farman,
gustavo.romero, imammedo, jiangkunkun, jonathan.cameron, linuxarm,
mtosatti, peter.maydell, philmd, qemu-arm, qemu-devel,
richard.henderson, shameerali.kolothum.thodi, shannon.zhaosl,
yangyicong, zhao1.liu, maobibo
Prepare to update `build_pptt` function to add cache description
functionalities, thus add binaries in this patch.
Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..e84d6c6955 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,4 @@
/* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/aarch64/virt/PPTT",
+"tests/data/acpi/aarch64/virt/PPTT.acpihmatvirt",
+"tests/data/acpi/aarch64/virt/PPTT.topology",
--
2.43.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v12 4/6] hw/acpi: add cache hierarchy to pptt table
2025-06-04 13:34 [PATCH v12 0/6] Specifying cache topology on ARM Alireza Sanaee via
` (2 preceding siblings ...)
2025-06-04 13:34 ` [PATCH v12 3/6] bios-tables-test: prepare to change ARM ACPI virt PPTT Alireza Sanaee via
@ 2025-06-04 13:34 ` Alireza Sanaee via
2025-06-04 13:34 ` [PATCH v12 5/6] tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology Alireza Sanaee via
2025-06-04 13:34 ` [PATCH v12 6/6] Update the ACPI tables based on new aml-build.c Alireza Sanaee via
5 siblings, 0 replies; 14+ messages in thread
From: Alireza Sanaee via @ 2025-06-04 13:34 UTC (permalink / raw)
To: mst
Cc: anisinha, armbru, berrange, dapeng1.mi, eric.auger, farman,
gustavo.romero, imammedo, jiangkunkun, jonathan.cameron, linuxarm,
mtosatti, peter.maydell, philmd, qemu-arm, qemu-devel,
richard.henderson, shameerali.kolothum.thodi, shannon.zhaosl,
yangyicong, zhao1.liu, maobibo
Add cache topology to PPTT table. With this patch, both ACPI PPTT table
and device tree will represent the same cache topology given users
input.
Co-developed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
---
hw/acpi/aml-build.c | 222 +++++++++++++++++++++++++++++++--
hw/arm/virt-acpi-build.c | 8 +-
hw/loongarch/virt-acpi-build.c | 2 +-
include/hw/acpi/aml-build.h | 4 +-
4 files changed, 225 insertions(+), 11 deletions(-)
diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
index 76a4157a18..d9c6e02037 100644
--- a/hw/acpi/aml-build.c
+++ b/hw/acpi/aml-build.c
@@ -2141,20 +2141,142 @@ void build_spcr(GArray *table_data, BIOSLinker *linker,
}
acpi_table_end(linker, &table);
}
+
+static void build_cache_nodes(GArray *tbl, CPUCorePPTTCaches *cache,
+ uint32_t next_offset, unsigned int id)
+{
+ int val;
+
+ /* Type 1 - cache */
+ build_append_byte(tbl, 1);
+ /* Length */
+ build_append_byte(tbl, 28);
+ /* Reserved */
+ build_append_int_noprefix(tbl, 0, 2);
+ /* Flags - everything except possibly the ID */
+ build_append_int_noprefix(tbl, 0xff, 4);
+ /* Offset of next cache up */
+ build_append_int_noprefix(tbl, next_offset, 4);
+ build_append_int_noprefix(tbl, cache->size, 4);
+ build_append_int_noprefix(tbl, cache->sets, 4);
+ build_append_byte(tbl, cache->associativity);
+ val = 0x3;
+ switch (cache->type) {
+ case CPU_CORE_INSTRUCTION:
+ val |= (1 << 2);
+ break;
+ case CPU_CORE_DATA:
+ val |= (0 << 2); /* Data */
+ break;
+ case CPU_CORE_UNIFIED:
+ val |= (3 << 2); /* Unified */
+ break;
+ }
+ build_append_byte(tbl, val);
+ build_append_int_noprefix(tbl, cache->linesize, 2);
+ build_append_int_noprefix(tbl,
+ (cache->type << 24) | (cache->level << 16) | id,
+ 4);
+}
+
+/*
+ * builds caches from the top level (`level_high` parameter) to the bottom
+ * level (`level_low` parameter). It searches for caches found in
+ * systems' registers, and fills up the table. Then it updates the
+ * `data_offset` and `instr_offset` parameters with the offset of the data
+ * and instruction caches of the lowest level, respectively.
+ */
+static bool build_caches(GArray *table_data, uint32_t pptt_start,
+ int num_caches, CPUCorePPTTCaches *caches,
+ int base_id,
+ uint8_t level_high, /* Inclusive */
+ uint8_t level_low, /* Inclusive */
+ uint32_t *data_offset,
+ uint32_t *instr_offset)
+{
+ uint32_t next_level_offset_data = 0, next_level_offset_instruction = 0;
+ uint32_t this_offset, next_offset = 0;
+ int c, level;
+ bool found_cache = false;
+
+ /* Walk caches from top to bottom */
+ for (level = level_high; level >= level_low; level--) {
+ for (c = 0; c < num_caches; c++) {
+ if (caches[c].level != level) {
+ continue;
+ }
+
+ /* Assume only unified above l1 for now */
+ this_offset = table_data->len - pptt_start;
+ switch (caches[c].type) {
+ case CPU_CORE_INSTRUCTION:
+ next_offset = next_level_offset_instruction;
+ break;
+ case CPU_CORE_DATA:
+ next_offset = next_level_offset_data;
+ break;
+ case CPU_CORE_UNIFIED:
+ /* Either is fine here */
+ next_offset = next_level_offset_instruction;
+ break;
+ }
+ build_cache_nodes(table_data, &caches[c], next_offset, base_id);
+ switch (caches[c].type) {
+ case CPU_CORE_INSTRUCTION:
+ next_level_offset_instruction = this_offset;
+ break;
+ case CPU_CORE_DATA:
+ next_level_offset_data = this_offset;
+ break;
+ case CPU_CORE_UNIFIED:
+ next_level_offset_instruction = this_offset;
+ next_level_offset_data = this_offset;
+ break;
+ }
+ *data_offset = next_level_offset_data;
+ *instr_offset = next_level_offset_instruction;
+
+ found_cache = true;
+ }
+ }
+
+ return found_cache;
+}
+
/*
* ACPI spec, Revision 6.3
* 5.2.29 Processor Properties Topology Table (PPTT)
*/
void build_pptt(GArray *table_data, BIOSLinker *linker, MachineState *ms,
- const char *oem_id, const char *oem_table_id)
+ const char *oem_id, const char *oem_table_id,
+ int num_caches, CPUCorePPTTCaches *caches)
{
MachineClass *mc = MACHINE_GET_CLASS(ms);
CPUArchIdList *cpus = ms->possible_cpus;
- int64_t socket_id = -1, cluster_id = -1, core_id = -1;
- uint32_t socket_offset = 0, cluster_offset = 0, core_offset = 0;
+ uint32_t core_data_offset = 0;
+ uint32_t core_instr_offset = 0;
+ uint32_t cluster_instr_offset = 0;
+ uint32_t cluster_data_offset = 0;
+ uint32_t node_data_offset = 0;
+ uint32_t node_instr_offset = 0;
+ int top_node = 3;
+ int top_cluster = 3;
+ int top_core = 3;
+ int bottom_node = 3;
+ int bottom_cluster = 3;
+ int bottom_core = 3;
+ int64_t socket_id = -1;
+ int64_t cluster_id = -1;
+ int64_t core_id = -1;
+ uint32_t socket_offset = 0;
+ uint32_t cluster_offset = 0;
+ uint32_t core_offset = 0;
uint32_t pptt_start = table_data->len;
uint32_t root_offset;
int n;
+ uint32_t priv_rsrc[2];
+ uint32_t num_priv = 0;
+
AcpiTable table = { .sig = "PPTT", .rev = 2,
.oem_id = oem_id, .oem_table_id = oem_table_id };
@@ -2162,7 +2284,7 @@ void build_pptt(GArray *table_data, BIOSLinker *linker, MachineState *ms,
/*
* Build a root node for all the processor nodes. Otherwise when
- * building a multi-socket system each socket tree is separated
+ * building a multi-socket system each socket tree are separated
* and will be hard for the OS like Linux to know whether the
* system is homogeneous.
*/
@@ -2184,11 +2306,35 @@ void build_pptt(GArray *table_data, BIOSLinker *linker, MachineState *ms,
socket_id = cpus->cpus[n].props.socket_id;
cluster_id = -1;
core_id = -1;
+ bottom_node = top_node;
+ num_priv = 0;
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_SOCKET) &&
+ find_the_lowest_level_cache_defined_at_level(
+ ms,
+ &bottom_node,
+ CPU_TOPOLOGY_LEVEL_SOCKET))
+ {
+ build_caches(table_data, pptt_start,
+ num_caches, caches,
+ n, top_node, bottom_node,
+ &node_data_offset, &node_instr_offset);
+
+ priv_rsrc[0] = node_instr_offset;
+ priv_rsrc[1] = node_data_offset;
+
+ if (node_instr_offset || node_data_offset) {
+ num_priv = node_instr_offset == node_data_offset ? 1 : 2;
+ }
+
+ top_cluster = bottom_node - 1;
+ }
+
socket_offset = table_data->len - pptt_start;
build_processor_hierarchy_node(table_data,
(1 << 0) | /* Physical package */
(1 << 4), /* Identical Implementation */
- root_offset, socket_id, NULL, 0);
+ root_offset, socket_id,
+ priv_rsrc, num_priv);
}
if (mc->smp_props.clusters_supported && mc->smp_props.has_clusters) {
@@ -2196,21 +2342,80 @@ void build_pptt(GArray *table_data, BIOSLinker *linker, MachineState *ms,
assert(cpus->cpus[n].props.cluster_id > cluster_id);
cluster_id = cpus->cpus[n].props.cluster_id;
core_id = -1;
+ bottom_cluster = top_cluster;
+ num_priv = 0;
+
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_CLUSTER) &&
+ find_the_lowest_level_cache_defined_at_level(
+ ms,
+ &bottom_cluster,
+ CPU_TOPOLOGY_LEVEL_CLUSTER))
+ {
+
+ build_caches(table_data, pptt_start,
+ num_caches, caches, n, top_cluster,
+ bottom_cluster, &cluster_data_offset,
+ &cluster_instr_offset);
+
+ priv_rsrc[0] = cluster_instr_offset;
+ priv_rsrc[1] = cluster_data_offset;
+
+ if (cluster_instr_offset || cluster_data_offset) {
+ num_priv =
+ cluster_instr_offset == cluster_data_offset ? 1 : 2;
+ }
+
+ top_core = bottom_cluster - 1;
+ } else if (top_cluster == bottom_node - 1) {
+ /* socket cache but no cluster cache */
+ top_core = bottom_node - 1;
+ }
+
cluster_offset = table_data->len - pptt_start;
build_processor_hierarchy_node(table_data,
(0 << 0) | /* Not a physical package */
(1 << 4), /* Identical Implementation */
- socket_offset, cluster_id, NULL, 0);
+ socket_offset, cluster_id,
+ priv_rsrc, num_priv);
}
} else {
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_CLUSTER)) {
+ error_setg(&error_fatal, "Not clusters found for the cache");
+ return;
+ }
+
cluster_offset = socket_offset;
+ top_core = bottom_node - 1; /* there is no cluster */
+ }
+
+ if (cpus->cpus[n].props.core_id != core_id) {
+ bottom_core = top_core;
+ num_priv = 0;
+
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_CORE) &&
+ find_the_lowest_level_cache_defined_at_level(
+ ms,
+ &bottom_core,
+ CPU_TOPOLOGY_LEVEL_CORE))
+ {
+ build_caches(table_data, pptt_start,
+ num_caches, caches,
+ n, top_core, bottom_core,
+ &core_data_offset, &core_instr_offset);
+
+ priv_rsrc[0] = core_instr_offset;
+ priv_rsrc[1] = core_data_offset;
+
+ num_priv = core_instr_offset == core_data_offset ? 1 : 2;
+ }
}
if (ms->smp.threads == 1) {
build_processor_hierarchy_node(table_data,
(1 << 1) | /* ACPI Processor ID valid */
(1 << 3), /* Node is a Leaf */
- cluster_offset, n, NULL, 0);
+ cluster_offset, n,
+ priv_rsrc, num_priv);
} else {
if (cpus->cpus[n].props.core_id != core_id) {
assert(cpus->cpus[n].props.core_id > core_id);
@@ -2219,7 +2424,8 @@ void build_pptt(GArray *table_data, BIOSLinker *linker, MachineState *ms,
build_processor_hierarchy_node(table_data,
(0 << 0) | /* Not a physical package */
(1 << 4), /* Identical Implementation */
- cluster_offset, core_id, NULL, 0);
+ cluster_offset, core_id,
+ priv_rsrc, num_priv);
}
build_processor_hierarchy_node(table_data,
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 7e8e0f0298..eccdbb640f 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -898,6 +898,11 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTables *tables)
GArray *tables_blob = tables->table_data;
MachineState *ms = MACHINE(vms);
+ CPUCorePPTTCaches caches[CPU_MAX_CACHES];
+ unsigned int num_caches;
+
+ num_caches = virt_get_caches(vms, caches);
+
table_offsets = g_array_new(false, true /* clear */,
sizeof(uint32_t));
@@ -919,7 +924,8 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTables *tables)
if (!vmc->no_cpu_topology) {
acpi_add_table(table_offsets, tables_blob);
build_pptt(tables_blob, tables->linker, ms,
- vms->oem_id, vms->oem_table_id);
+ vms->oem_id, vms->oem_table_id,
+ num_caches, caches);
}
acpi_add_table(table_offsets, tables_blob);
diff --git a/hw/loongarch/virt-acpi-build.c b/hw/loongarch/virt-acpi-build.c
index 2cd2d9d842..dd34a520c7 100644
--- a/hw/loongarch/virt-acpi-build.c
+++ b/hw/loongarch/virt-acpi-build.c
@@ -552,7 +552,7 @@ static void acpi_build(AcpiBuildTables *tables, MachineState *machine)
acpi_add_table(table_offsets, tables_blob);
build_pptt(tables_blob, tables->linker, machine,
- lvms->oem_id, lvms->oem_table_id);
+ lvms->oem_id, lvms->oem_table_id, 0, NULL);
acpi_add_table(table_offsets, tables_blob);
build_srat(tables_blob, tables->linker, machine);
diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
index c18f681342..e22f411f31 100644
--- a/include/hw/acpi/aml-build.h
+++ b/include/hw/acpi/aml-build.h
@@ -3,6 +3,7 @@
#include "hw/acpi/acpi-defs.h"
#include "hw/acpi/bios-linker-loader.h"
+#include "hw/cpu/core.h"
#define ACPI_BUILD_APPNAME6 "BOCHS "
#define ACPI_BUILD_APPNAME8 "BXPC "
@@ -497,7 +498,8 @@ void build_slit(GArray *table_data, BIOSLinker *linker, MachineState *ms,
const char *oem_id, const char *oem_table_id);
void build_pptt(GArray *table_data, BIOSLinker *linker, MachineState *ms,
- const char *oem_id, const char *oem_table_id);
+ const char *oem_id, const char *oem_table_id,
+ int num_caches, CPUCorePPTTCaches *caches);
void build_fadt(GArray *tbl, BIOSLinker *linker, const AcpiFadtData *f,
const char *oem_id, const char *oem_table_id);
--
2.43.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v12 5/6] tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology
2025-06-04 13:34 [PATCH v12 0/6] Specifying cache topology on ARM Alireza Sanaee via
` (3 preceding siblings ...)
2025-06-04 13:34 ` [PATCH v12 4/6] hw/acpi: add cache hierarchy to pptt table Alireza Sanaee via
@ 2025-06-04 13:34 ` Alireza Sanaee via
2025-06-05 9:46 ` Zhao Liu
2025-06-04 13:34 ` [PATCH v12 6/6] Update the ACPI tables based on new aml-build.c Alireza Sanaee via
5 siblings, 1 reply; 14+ messages in thread
From: Alireza Sanaee via @ 2025-06-04 13:34 UTC (permalink / raw)
To: mst
Cc: anisinha, armbru, berrange, dapeng1.mi, eric.auger, farman,
gustavo.romero, imammedo, jiangkunkun, jonathan.cameron, linuxarm,
mtosatti, peter.maydell, philmd, qemu-arm, qemu-devel,
richard.henderson, shameerali.kolothum.thodi, shannon.zhaosl,
yangyicong, zhao1.liu, maobibo
Test new PPTT topolopy with cache representation.
Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
tests/qtest/bios-tables-test.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 0b2bdf9d0d..1f64c784a6 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -2142,6 +2142,10 @@ static void test_acpi_aarch64_virt_tcg_topology(void)
};
test_acpi_one("-cpu cortex-a57 "
+ "-M virt,smp-cache.0.cache=l1i,smp-cache.0.topology=cluster,"
+ "smp-cache.1.cache=l1d,smp-cache.1.topology=cluster,"
+ "smp-cache.2.cache=l2,smp-cache.2.topology=cluster,"
+ "smp-cache.3.cache=l3,smp-cache.3.topology=cluster "
"-smp sockets=1,clusters=2,cores=2,threads=2", &data);
free_test_data(&data);
}
--
2.43.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v12 6/6] Update the ACPI tables based on new aml-build.c
2025-06-04 13:34 [PATCH v12 0/6] Specifying cache topology on ARM Alireza Sanaee via
` (4 preceding siblings ...)
2025-06-04 13:34 ` [PATCH v12 5/6] tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology Alireza Sanaee via
@ 2025-06-04 13:34 ` Alireza Sanaee via
2025-06-05 9:47 ` Zhao Liu
5 siblings, 1 reply; 14+ messages in thread
From: Alireza Sanaee via @ 2025-06-04 13:34 UTC (permalink / raw)
To: mst
Cc: anisinha, armbru, berrange, dapeng1.mi, eric.auger, farman,
gustavo.romero, imammedo, jiangkunkun, jonathan.cameron, linuxarm,
mtosatti, peter.maydell, philmd, qemu-arm, qemu-devel,
richard.henderson, shameerali.kolothum.thodi, shannon.zhaosl,
yangyicong, zhao1.liu, maobibo
The disassembled differences between actual and expected PPTT based on
the following cache topology representation:
- l1d and l1i shared at cluster level
- l2 shared at cluster level
- l3 shared at cluster level
/*
* Intel ACPI Component Architecture
* AML/ASL+ Disassembler version 20230628 (64-bit version)
* Copyright (c) 2000 - 2023 Intel Corporation
*
* Disassembly of tests/data/acpi/aarch64/virt/PPTT.topology, Tue Jun 3 13:48:43 2025
* Disassembly of /tmp/aml-424862, Tue Jun 3 13:48:43 2025
*
* ACPI Data Table [PPTT]
*
* Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue (in hex)
*/
[000h 0000 004h] Signature : "PPTT" [Processor Properties Topology Table]
[004h 0004 004h] Table Length : 00000164
[004h 0004 004h] Table Length : 0000021C
[008h 0008 001h] Revision : 02
[009h 0009 001h] Checksum : 97
[009h 0009 001h] Checksum : 4E
[00Ah 0010 006h] Oem ID : "BOCHS "
[010h 0016 008h] Oem Table ID : "BXPC "
[018h 0024 004h] Oem Revision : 00000001
[01Ch 0028 004h] Asl Compiler ID : "BXPC"
[020h 0032 004h] Asl Compiler Revision : 00000001
[024h 0036 001h] Subtable Type : 00 [Processor Hierarchy Node]
[025h 0037 001h] Length : 14
[026h 0038 002h] Reserved : 0000
[028h 0040 004h] Flags (decoded below) : 00000011
Physical package : 1
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
@ -34,223 +34,370 @@
[030h 0048 004h] ACPI Processor ID : 00000000
[034h 0052 004h] Private Resource Number : 00000000
[038h 0056 001h] Subtable Type : 00 [Processor Hierarchy Node]
[039h 0057 001h] Length : 14
[03Ah 0058 002h] Reserved : 0000
[03Ch 0060 004h] Flags (decoded below) : 00000011
Physical package : 1
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[040h 0064 004h] Parent : 00000024
[044h 0068 004h] ACPI Processor ID : 00000000
[048h 0072 004h] Private Resource Number : 00000000
[04Ch 0076 001h] Subtable Type : 00 [Processor Hierarchy Node]
[04Dh 0077 001h] Length : 14
[04Ch 0076 001h] Subtable Type : 01 [Cache Type]
[04Dh 0077 001h] Length : 1C
[04Eh 0078 002h] Reserved : 0000
[050h 0080 004h] Flags (decoded below) : 00000010
[050h 0080 004h] Flags (decoded below) : 000000FF
Size valid : 1
Number of Sets valid : 1
Associativity valid : 1
Allocation Type valid : 1
Cache Type valid : 1
Write Policy valid : 1
Line Size valid : 1
Cache ID valid : 1
[054h 0084 004h] Next Level of Cache : 00000000
[058h 0088 004h] Size : 00200000
[05Ch 0092 004h] Number of Sets : 00000800
[060h 0096 001h] Associativity : 10
[061h 0097 001h] Attributes : 0F
Allocation Type : 3
Cache Type : 3
Write Policy : 0
[062h 0098 002h] Line Size : 0040
[068h 0104 001h] Subtable Type : 01 [Cache Type]
[069h 0105 001h] Length : 1C
[06Ah 0106 002h] Reserved : 0000
[06Ch 0108 004h] Flags (decoded below) : 000000FF
Size valid : 1
Number of Sets valid : 1
Associativity valid : 1
Allocation Type valid : 1
Cache Type valid : 1
Write Policy valid : 1
Line Size valid : 1
Cache ID valid : 1
[070h 0112 004h] Next Level of Cache : 0000004C
[074h 0116 004h] Size : 00008000
[078h 0120 004h] Number of Sets : 00000080
[07Ch 0124 001h] Associativity : 04
[07Dh 0125 001h] Attributes : 03
Allocation Type : 3
Cache Type : 0
Write Policy : 0
[07Eh 0126 002h] Line Size : 0040
[084h 0132 001h] Subtable Type : 01 [Cache Type]
[085h 0133 001h] Length : 1C
[086h 0134 002h] Reserved : 0000
[088h 0136 004h] Flags (decoded below) : 000000FF
Size valid : 1
Number of Sets valid : 1
Associativity valid : 1
Allocation Type valid : 1
Cache Type valid : 1
Write Policy valid : 1
Line Size valid : 1
Cache ID valid : 1
[08Ch 0140 004h] Next Level of Cache : 0000004C
[090h 0144 004h] Size : 0000C000
[094h 0148 004h] Number of Sets : 00000100
[098h 0152 001h] Associativity : 03
[099h 0153 001h] Attributes : 07
Allocation Type : 3
Cache Type : 1
Write Policy : 0
[09Ah 0154 002h] Line Size : 0040
[0A0h 0160 001h] Subtable Type : 00 [Processor Hierarchy Node]
[0A1h 0161 001h] Length : 1C
[0A2h 0162 002h] Reserved : 0000
[0A4h 0164 004h] Flags (decoded below) : 00000010
Physical package : 0
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[054h 0084 004h] Parent : 00000038
[058h 0088 004h] ACPI Processor ID : 00000000
[05Ch 0092 004h] Private Resource Number : 00000000
[060h 0096 001h] Subtable Type : 00 [Processor Hierarchy Node]
[061h 0097 001h] Length : 14
[062h 0098 002h] Reserved : 0000
[064h 0100 004h] Flags (decoded below) : 00000010
[0A8h 0168 004h] Parent : 00000038
[0ACh 0172 004h] ACPI Processor ID : 00000000
[0B0h 0176 004h] Private Resource Number : 00000002
[0B4h 0180 004h] Private Resource : 00000084
[0B8h 0184 004h] Private Resource : 00000068
[0BCh 0188 001h] Subtable Type : 00 [Processor Hierarchy Node]
[0BDh 0189 001h] Length : 14
[0BEh 0190 002h] Reserved : 0000
[0C0h 0192 004h] Flags (decoded below) : 00000010
Physical package : 0
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[068h 0104 004h] Parent : 0000004C
[06Ch 0108 004h] ACPI Processor ID : 00000000
[070h 0112 004h] Private Resource Number : 00000000
[074h 0116 001h] Subtable Type : 00 [Processor Hierarchy Node]
[075h 0117 001h] Length : 14
[076h 0118 002h] Reserved : 0000
[078h 0120 004h] Flags (decoded below) : 0000000E
[0C4h 0196 004h] Parent : 000000A0
[0C8h 0200 004h] ACPI Processor ID : 00000000
[0CCh 0204 004h] Private Resource Number : 00000000
[0D0h 0208 001h] Subtable Type : 00 [Processor Hierarchy Node]
[0D1h 0209 001h] Length : 14
[0D2h 0210 002h] Reserved : 0000
[0D4h 0212 004h] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[07Ch 0124 004h] Parent : 00000060
[080h 0128 004h] ACPI Processor ID : 00000000
[084h 0132 004h] Private Resource Number : 00000000
[088h 0136 001h] Subtable Type : 00 [Processor Hierarchy Node]
[089h 0137 001h] Length : 14
[08Ah 0138 002h] Reserved : 0000
[08Ch 0140 004h] Flags (decoded below) : 0000000E
[0D8h 0216 004h] Parent : 000000BC
[0DCh 0220 004h] ACPI Processor ID : 00000000
[0E0h 0224 004h] Private Resource Number : 00000000
[0E4h 0228 001h] Subtable Type : 00 [Processor Hierarchy Node]
[0E5h 0229 001h] Length : 14
[0E6h 0230 002h] Reserved : 0000
[0E8h 0232 004h] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[090h 0144 004h] Parent : 00000060
[094h 0148 004h] ACPI Processor ID : 00000001
[098h 0152 004h] Private Resource Number : 00000000
[09Ch 0156 001h] Subtable Type : 00 [Processor Hierarchy Node]
[09Dh 0157 001h] Length : 14
[09Eh 0158 002h] Reserved : 0000
[0A0h 0160 004h] Flags (decoded below) : 00000010
[0ECh 0236 004h] Parent : 000000BC
[0F0h 0240 004h] ACPI Processor ID : 00000001
[0F4h 0244 004h] Private Resource Number : 00000000
[0F8h 0248 001h] Subtable Type : 00 [Processor Hierarchy Node]
[0F9h 0249 001h] Length : 14
[0FAh 0250 002h] Reserved : 0000
[0FCh 0252 004h] Flags (decoded below) : 00000010
Physical package : 0
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[0A4h 0164 004h] Parent : 0000004C
[0A8h 0168 004h] ACPI Processor ID : 00000001
[0ACh 0172 004h] Private Resource Number : 00000000
[0B0h 0176 001h] Subtable Type : 00 [Processor Hierarchy Node]
[0B1h 0177 001h] Length : 14
[0B2h 0178 002h] Reserved : 0000
[0B4h 0180 004h] Flags (decoded below) : 0000000E
[100h 0256 004h] Parent : 000000A0
[104h 0260 004h] ACPI Processor ID : 00000001
[108h 0264 004h] Private Resource Number : 00000000
[10Ch 0268 001h] Subtable Type : 00 [Processor Hierarchy Node]
[10Dh 0269 001h] Length : 14
[10Eh 0270 002h] Reserved : 0000
[110h 0272 004h] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[0B8h 0184 004h] Parent : 0000009C
[0BCh 0188 004h] ACPI Processor ID : 00000002
[0C0h 0192 004h] Private Resource Number : 00000000
[0C4h 0196 001h] Subtable Type : 00 [Processor Hierarchy Node]
[0C5h 0197 001h] Length : 14
[0C6h 0198 002h] Reserved : 0000
[0C8h 0200 004h] Flags (decoded below) : 0000000E
[114h 0276 004h] Parent : 000000F8
[118h 0280 004h] ACPI Processor ID : 00000002
[11Ch 0284 004h] Private Resource Number : 00000000
[120h 0288 001h] Subtable Type : 00 [Processor Hierarchy Node]
[121h 0289 001h] Length : 14
[122h 0290 002h] Reserved : 0000
[124h 0292 004h] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[0CCh 0204 004h] Parent : 0000009C
[0D0h 0208 004h] ACPI Processor ID : 00000003
[0D4h 0212 004h] Private Resource Number : 00000000
[0D8h 0216 001h] Subtable Type : 00 [Processor Hierarchy Node]
[0D9h 0217 001h] Length : 14
[0DAh 0218 002h] Reserved : 0000
[0DCh 0220 004h] Flags (decoded below) : 00000010
[128h 0296 004h] Parent : 000000F8
[12Ch 0300 004h] ACPI Processor ID : 00000003
[130h 0304 004h] Private Resource Number : 00000000
[134h 0308 001h] Subtable Type : 01 [Cache Type]
[135h 0309 001h] Length : 1C
[136h 0310 002h] Reserved : 0000
[138h 0312 004h] Flags (decoded below) : 000000FF
Size valid : 1
Number of Sets valid : 1
Associativity valid : 1
Allocation Type valid : 1
Cache Type valid : 1
Write Policy valid : 1
Line Size valid : 1
Cache ID valid : 1
[13Ch 0316 004h] Next Level of Cache : 00000000
[140h 0320 004h] Size : 00200000
[144h 0324 004h] Number of Sets : 00000800
[148h 0328 001h] Associativity : 10
[149h 0329 001h] Attributes : 0F
Allocation Type : 3
Cache Type : 3
Write Policy : 0
[14Ah 0330 002h] Line Size : 0040
[150h 0336 001h] Subtable Type : 01 [Cache Type]
[151h 0337 001h] Length : 1C
[152h 0338 002h] Reserved : 0000
[154h 0340 004h] Flags (decoded below) : 000000FF
Size valid : 1
Number of Sets valid : 1
Associativity valid : 1
Allocation Type valid : 1
Cache Type valid : 1
Write Policy valid : 1
Line Size valid : 1
Cache ID valid : 1
[158h 0344 004h] Next Level of Cache : 00000134
[15Ch 0348 004h] Size : 00008000
[160h 0352 004h] Number of Sets : 00000080
[164h 0356 001h] Associativity : 04
[165h 0357 001h] Attributes : 03
Allocation Type : 3
Cache Type : 0
Write Policy : 0
[166h 0358 002h] Line Size : 0040
[16Ch 0364 001h] Subtable Type : 01 [Cache Type]
[16Dh 0365 001h] Length : 1C
[16Eh 0366 002h] Reserved : 0000
[170h 0368 004h] Flags (decoded below) : 000000FF
Size valid : 1
Number of Sets valid : 1
Associativity valid : 1
Allocation Type valid : 1
Cache Type valid : 1
Write Policy valid : 1
Line Size valid : 1
Cache ID valid : 1
[174h 0372 004h] Next Level of Cache : 00000134
[178h 0376 004h] Size : 0000C000
[17Ch 0380 004h] Number of Sets : 00000100
[180h 0384 001h] Associativity : 03
[181h 0385 001h] Attributes : 07
Allocation Type : 3
Cache Type : 1
Write Policy : 0
[182h 0386 002h] Line Size : 0040
[188h 0392 001h] Subtable Type : 00 [Processor Hierarchy Node]
[189h 0393 001h] Length : 1C
[18Ah 0394 002h] Reserved : 0000
[18Ch 0396 004h] Flags (decoded below) : 00000010
Physical package : 0
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[0E0h 0224 004h] Parent : 00000038
[0E4h 0228 004h] ACPI Processor ID : 00000001
[0E8h 0232 004h] Private Resource Number : 00000000
[0ECh 0236 001h] Subtable Type : 00 [Processor Hierarchy Node]
[0EDh 0237 001h] Length : 14
[0EEh 0238 002h] Reserved : 0000
[0F0h 0240 004h] Flags (decoded below) : 00000010
[190h 0400 004h] Parent : 00000038
[194h 0404 004h] ACPI Processor ID : 00000001
[198h 0408 004h] Private Resource Number : 00000002
[19Ch 0412 004h] Private Resource : 0000016C
[1A0h 0416 004h] Private Resource : 00000150
[1A4h 0420 001h] Subtable Type : 00 [Processor Hierarchy Node]
[1A5h 0421 001h] Length : 14
[1A6h 0422 002h] Reserved : 0000
[1A8h 0424 004h] Flags (decoded below) : 00000010
Physical package : 0
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[0F4h 0244 004h] Parent : 000000D8
[0F8h 0248 004h] ACPI Processor ID : 00000000
[0FCh 0252 004h] Private Resource Number : 00000000
[100h 0256 001h] Subtable Type : 00 [Processor Hierarchy Node]
[101h 0257 001h] Length : 14
[102h 0258 002h] Reserved : 0000
[104h 0260 004h] Flags (decoded below) : 0000000E
[1ACh 0428 004h] Parent : 00000188
[1B0h 0432 004h] ACPI Processor ID : 00000000
[1B4h 0436 004h] Private Resource Number : 00000000
[1B8h 0440 001h] Subtable Type : 00 [Processor Hierarchy Node]
[1B9h 0441 001h] Length : 14
[1BAh 0442 002h] Reserved : 0000
[1BCh 0444 004h] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[108h 0264 004h] Parent : 000000EC
[10Ch 0268 004h] ACPI Processor ID : 00000004
[110h 0272 004h] Private Resource Number : 00000000
[114h 0276 001h] Subtable Type : 00 [Processor Hierarchy Node]
[115h 0277 001h] Length : 14
[116h 0278 002h] Reserved : 0000
[118h 0280 004h] Flags (decoded below) : 0000000E
[1C0h 0448 004h] Parent : 000001A4
[1C4h 0452 004h] ACPI Processor ID : 00000004
[1C8h 0456 004h] Private Resource Number : 00000000
[1CCh 0460 001h] Subtable Type : 00 [Processor Hierarchy Node]
[1CDh 0461 001h] Length : 14
[1CEh 0462 002h] Reserved : 0000
[1D0h 0464 004h] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[11Ch 0284 004h] Parent : 000000EC
[120h 0288 004h] ACPI Processor ID : 00000005
[124h 0292 004h] Private Resource Number : 00000000
[128h 0296 001h] Subtable Type : 00 [Processor Hierarchy Node]
[129h 0297 001h] Length : 14
[12Ah 0298 002h] Reserved : 0000
[12Ch 0300 004h] Flags (decoded below) : 00000010
[1D4h 0468 004h] Parent : 000001A4
[1D8h 0472 004h] ACPI Processor ID : 00000005
[1DCh 0476 004h] Private Resource Number : 00000000
[1E0h 0480 001h] Subtable Type : 00 [Processor Hierarchy Node]
[1E1h 0481 001h] Length : 14
[1E2h 0482 002h] Reserved : 0000
[1E4h 0484 004h] Flags (decoded below) : 00000010
Physical package : 0
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[130h 0304 004h] Parent : 000000D8
[134h 0308 004h] ACPI Processor ID : 00000001
[138h 0312 004h] Private Resource Number : 00000000
[13Ch 0316 001h] Subtable Type : 00 [Processor Hierarchy Node]
[13Dh 0317 001h] Length : 14
[13Eh 0318 002h] Reserved : 0000
[140h 0320 004h] Flags (decoded below) : 0000000E
[1E8h 0488 004h] Parent : 00000188
[1ECh 0492 004h] ACPI Processor ID : 00000001
[1F0h 0496 004h] Private Resource Number : 00000000
[1F4h 0500 001h] Subtable Type : 00 [Processor Hierarchy Node]
[1F5h 0501 001h] Length : 14
[1F6h 0502 002h] Reserved : 0000
[1F8h 0504 004h] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[144h 0324 004h] Parent : 00000128
[148h 0328 004h] ACPI Processor ID : 00000006
[14Ch 0332 004h] Private Resource Number : 00000000
[150h 0336 001h] Subtable Type : 00 [Processor Hierarchy Node]
[151h 0337 001h] Length : 14
[152h 0338 002h] Reserved : 0000
[154h 0340 004h] Flags (decoded below) : 0000000E
[1FCh 0508 004h] Parent : 000001E0
[200h 0512 004h] ACPI Processor ID : 00000006
[204h 0516 004h] Private Resource Number : 00000000
[208h 0520 001h] Subtable Type : 00 [Processor Hierarchy Node]
[209h 0521 001h] Length : 14
[20Ah 0522 002h] Reserved : 0000
[20Ch 0524 004h] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[158h 0344 004h] Parent : 00000128
[15Ch 0348 004h] ACPI Processor ID : 00000007
[160h 0352 004h] Private Resource Number : 00000000
[210h 0528 004h] Parent : 000001E0
[214h 0532 004h] ACPI Processor ID : 00000007
[218h 0536 004h] Private Resource Number : 00000000
Raw Table Data: Length 356 (0x164)
Raw Table Data: Length 540 (0x21C)
0000: 50 50 54 54 64 01 00 00 02 97 42 4F 43 48 53 20 // PPTTd.....BOCHS
0000: 50 50 54 54 1C 02 00 00 02 4E 42 4F 43 48 53 20 // PPTT.....NBOCHS
0010: 42 58 50 43 20 20 20 20 01 00 00 00 42 58 50 43 // BXPC ....BXPC
0020: 01 00 00 00 00 14 00 00 11 00 00 00 00 00 00 00 // ................
0030: 00 00 00 00 00 00 00 00 00 14 00 00 11 00 00 00 // ................
0040: 24 00 00 00 00 00 00 00 00 00 00 00 00 14 00 00 // $...............
0050: 10 00 00 00 38 00 00 00 00 00 00 00 00 00 00 00 // ....8...........
0060: 00 14 00 00 10 00 00 00 4C 00 00 00 00 00 00 00 // ........L.......
0070: 00 00 00 00 00 14 00 00 0E 00 00 00 60 00 00 00 // ............`...
0080: 00 00 00 00 00 00 00 00 00 14 00 00 0E 00 00 00 // ................
0090: 60 00 00 00 01 00 00 00 00 00 00 00 00 14 00 00 // `...............
00A0: 10 00 00 00 4C 00 00 00 01 00 00 00 00 00 00 00 // ....L...........
00B0: 00 14 00 00 0E 00 00 00 9C 00 00 00 02 00 00 00 // ................
00C0: 00 00 00 00 00 14 00 00 0E 00 00 00 9C 00 00 00 // ................
00D0: 03 00 00 00 00 00 00 00 00 14 00 00 10 00 00 00 // ................
00E0: 38 00 00 00 01 00 00 00 00 00 00 00 00 14 00 00 // 8...............
00F0: 10 00 00 00 D8 00 00 00 00 00 00 00 00 00 00 00 // ................
0100: 00 14 00 00 0E 00 00 00 EC 00 00 00 04 00 00 00 // ................
0110: 00 00 00 00 00 14 00 00 0E 00 00 00 EC 00 00 00 // ................
0120: 05 00 00 00 00 00 00 00 00 14 00 00 10 00 00 00 // ................
0130: D8 00 00 00 01 00 00 00 00 00 00 00 00 14 00 00 // ................
0140: 0E 00 00 00 28 01 00 00 06 00 00 00 00 00 00 00 // ....(...........
0150: 00 14 00 00 0E 00 00 00 28 01 00 00 07 00 00 00 // ........(.......
0160: 00 00 00 00 // ....
0040: 24 00 00 00 00 00 00 00 00 00 00 00 01 1C 00 00 // $...............
0050: FF 00 00 00 00 00 00 00 00 00 20 00 00 08 00 00 // .......... .....
0060: 10 0F 40 00 00 00 02 02 01 1C 00 00 FF 00 00 00 // ..@.............
0070: 4C 00 00 00 00 80 00 00 80 00 00 00 04 03 40 00 // L.............@.
0080: 00 00 01 00 01 1C 00 00 FF 00 00 00 4C 00 00 00 // ............L...
0090: 00 C0 00 00 00 01 00 00 03 07 40 00 00 00 01 01 // ..........@.....
00A0: 00 1C 00 00 10 00 00 00 38 00 00 00 00 00 00 00 // ........8.......
00B0: 02 00 00 00 84 00 00 00 68 00 00 00 00 14 00 00 // ........h.......
00C0: 10 00 00 00 A0 00 00 00 00 00 00 00 00 00 00 00 // ................
00D0: 00 14 00 00 0E 00 00 00 BC 00 00 00 00 00 00 00 // ................
00E0: 00 00 00 00 00 14 00 00 0E 00 00 00 BC 00 00 00 // ................
00F0: 01 00 00 00 00 00 00 00 00 14 00 00 10 00 00 00 // ................
0100: A0 00 00 00 01 00 00 00 00 00 00 00 00 14 00 00 // ................
0110: 0E 00 00 00 F8 00 00 00 02 00 00 00 00 00 00 00 // ................
0120: 00 14 00 00 0E 00 00 00 F8 00 00 00 03 00 00 00 // ................
0130: 00 00 00 00 01 1C 00 00 FF 00 00 00 00 00 00 00 // ................
0140: 00 00 20 00 00 08 00 00 10 0F 40 00 04 00 02 02 // .. .......@.....
0150: 01 1C 00 00 FF 00 00 00 34 01 00 00 00 80 00 00 // ........4.......
0160: 80 00 00 00 04 03 40 00 04 00 01 00 01 1C 00 00 // ......@.........
0170: FF 00 00 00 34 01 00 00 00 C0 00 00 00 01 00 00 // ....4...........
0180: 03 07 40 00 04 00 01 01 00 1C 00 00 10 00 00 00 // ..@.............
0190: 38 00 00 00 01 00 00 00 02 00 00 00 6C 01 00 00 // 8...........l...
01A0: 50 01 00 00 00 14 00 00 10 00 00 00 88 01 00 00 // P...............
01B0: 00 00 00 00 00 00 00 00 00 14 00 00 0E 00 00 00 // ................
01C0: A4 01 00 00 04 00 00 00 00 00 00 00 00 14 00 00 // ................
01D0: 0E 00 00 00 A4 01 00 00 05 00 00 00 00 00 00 00 // ................
01E0: 00 14 00 00 10 00 00 00 88 01 00 00 01 00 00 00 // ................
01F0: 00 00 00 00 00 14 00 00 0E 00 00 00 E0 01 00 00 // ................
0200: 06 00 00 00 00 00 00 00 00 14 00 00 0E 00 00 00 // ................
0210: E0 01 00 00 07 00 00 00 00 00 00 00 // ............
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
---
tests/data/acpi/aarch64/virt/PPTT.topology | Bin 356 -> 540 bytes
tests/qtest/bios-tables-test-allowed-diff.h | 3 ---
2 files changed, 3 deletions(-)
diff --git a/tests/data/acpi/aarch64/virt/PPTT.topology b/tests/data/acpi/aarch64/virt/PPTT.topology
index 6b864f035c9f48845e9a3beb482c5171074864a5..645b873906fc29f03392ae5ac18853ee59e10100 100644
GIT binary patch
literal 540
zcmZvXI}XAy5JV>*2o(g0GDQlGKtUNL4F!Toq~Hh?93lk;$DrUC6gdjVpo1A>2S;LM
z%e!y9_D)?lO%?*-uH09fLtY;1DrW=$l<UL-nCtYzvZcp@40!i-4orY_R*;0D)3(xE
zvk*rGivR<yGYC;)v;cfFC0cVUI4UmOCl#DQ+D*9&vMKY2t95$J__56O`b@nqZvA7z
z_KHOoxp}{3-usL_pDR7u{(Q!sPos6zc}G5}4ScFq|DT!EDy+||au;^4J6ZgPjXWlw
S>h0TY?~`Ec-II5*#Ig@|7$E@w
literal 356
zcmWFt2nk7HWME*L?&R<65v<@85#X!<1VAAM5F11@h%hh+f@ov_6;nYI69Dopu!#Af
ziSYsX2{^>Sc7o)9c7V(S=|vU;>74__Oh60<Ky@%NW+X9~TafjF#BRXUfM}@RH$Wx}
cOdLs!6-f-H7uh_Jy&6CPHY9a0F?OgJ00?&w0RR91
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index e84d6c6955..dfb8523c8b 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,4 +1 @@
/* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/aarch64/virt/PPTT",
-"tests/data/acpi/aarch64/virt/PPTT.acpihmatvirt",
-"tests/data/acpi/aarch64/virt/PPTT.topology",
--
2.43.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v12 3/6] bios-tables-test: prepare to change ARM ACPI virt PPTT
2025-06-04 13:34 ` [PATCH v12 3/6] bios-tables-test: prepare to change ARM ACPI virt PPTT Alireza Sanaee via
@ 2025-06-05 8:29 ` Zhao Liu
0 siblings, 0 replies; 14+ messages in thread
From: Zhao Liu @ 2025-06-05 8:29 UTC (permalink / raw)
To: Alireza Sanaee
Cc: mst, anisinha, armbru, berrange, dapeng1.mi, eric.auger, farman,
gustavo.romero, imammedo, jiangkunkun, jonathan.cameron, linuxarm,
mtosatti, peter.maydell, philmd, qemu-arm, qemu-devel,
richard.henderson, shameerali.kolothum.thodi, shannon.zhaosl,
yangyicong, maobibo
On Wed, Jun 04, 2025 at 02:34:36PM +0100, Alireza Sanaee wrote:
> Date: Wed, 4 Jun 2025 14:34:36 +0100
> From: Alireza Sanaee <alireza.sanaee@huawei.com>
> Subject: [PATCH v12 3/6] bios-tables-test: prepare to change ARM ACPI virt
> PPTT
> X-Mailer: git-send-email 2.34.1
>
> Prepare to update `build_pptt` function to add cache description
> functionalities, thus add binaries in this patch.
>
> Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
> ---
> tests/qtest/bios-tables-test-allowed-diff.h | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v12 2/6] arm/virt.c: add cache hierarchy to device tree
2025-06-05 9:44 ` Zhao Liu
@ 2025-06-05 9:40 ` Alireza Sanaee via
2025-06-05 13:58 ` Zhao Liu
2025-06-11 11:38 ` Alireza Sanaee via
1 sibling, 1 reply; 14+ messages in thread
From: Alireza Sanaee via @ 2025-06-05 9:40 UTC (permalink / raw)
To: Zhao Liu
Cc: mst, anisinha, armbru, berrange, dapeng1.mi, eric.auger, farman,
gustavo.romero, imammedo, jiangkunkun, jonathan.cameron, linuxarm,
mtosatti, peter.maydell, philmd, qemu-arm, qemu-devel,
richard.henderson, shameerali.kolothum.thodi, shannon.zhaosl,
yangyicong, maobibo
On Thu, 5 Jun 2025 17:44:52 +0800
Zhao Liu <zhao1.liu@intel.com> wrote:
> Hi Ali,
>
> I'm very sorry to bother you with some comments after so many
> versions.
>
> > diff --git a/hw/cpu/core.c b/hw/cpu/core.c
> > index 5cb2e9a7f5..7339782663 100644
> > --- a/hw/cpu/core.c
> > +++ b/hw/cpu/core.c
>
> core.c is not the right place. It just contains the "cpu-core"
> abstraction. So we need to move the following functions to other
> files.
>
> > @@ -102,4 +102,96 @@ static void cpu_core_register_types(void)
> > type_register_static(&cpu_core_type_info);
> > }
> >
> > +bool cache_described_at(const MachineState *ms, CpuTopologyLevel
> > level)
>
> It's better to add the comment about what this function did. (its name
> doesn't reflect it wants to check the coresponding CPU topology
> level.)
>
> I also feel it's not a good name, what about
> "machine_check_cache_at_topo_level"?
>
> Furthermore, we can move this one to hw/core/machine-smp.c, as it is
> about with machine's smp_cache.
>
> > +{
> > + if (machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L3)
> > == level ||
> > + machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L2)
> > == level ||
> > + machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1I)
> > == level ||
> > + machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1D)
> > == level) {
> > + return true;
> > + }
> > + return false;
> > +}
> > +
> > +int partial_cache_description(const MachineState *ms,
> > CPUCorePPTTCaches *caches,
> > + int num_caches)
>
> Because I'll suggest to move CPUCorePPTTCaches to
> include/hw/acpi/cpu.h later, and this function accepts
> CPUCorePPTTCaches as the argument, so I think we could move this
> function to hw/acpi/cpu.c (if Michael and Igor don't object).
>
> > +{
> > + int level, c;
> > +
> > + for (level = 1; level < num_caches; level++) {
> > + for (c = 0; c < num_caches; c++) {
> > + if (caches[c].level != level) {
> > + continue;
> > + }
> > +
> > + switch (level) {
> > + case 1:
> > + /*
> > + * L1 cache is assumed to have both L1I and L1D
> > available.
> > + * Technically both need to be checked.
> > + */
> > + if (machine_get_cache_topo_level(ms,
> > +
> > CACHE_LEVEL_AND_TYPE_L1I) ==
> > + CPU_TOPOLOGY_LEVEL_DEFAULT) {
> > + return level;
> > + }
> > + break;
> > + case 2:
> > + if (machine_get_cache_topo_level(ms,
> > CACHE_LEVEL_AND_TYPE_L2) ==
> > + CPU_TOPOLOGY_LEVEL_DEFAULT) {
> > + return level;
> > + }
> > + break;
> > + case 3:
> > + if (machine_get_cache_topo_level(ms,
> > CACHE_LEVEL_AND_TYPE_L3) ==
> > + CPU_TOPOLOGY_LEVEL_DEFAULT) {
> > + return level;
> > + }
> > + break;
> > + }
> > + }
> > + }
> > +
> > + return 0;
> > +}
> > +
> > +/*
> > + * This function assumes l3 and l2 have unified cache and l1 is
> > split l1d
> > + * and l1i, and further prepares the lowest cache level for a
> > topology
> > + * level. The info will be fed to build_caches to create caches
> > at the
> > + * right level.
> > + */
> > +bool find_the_lowest_level_cache_defined_at_level(const
> > MachineState *ms,
> > + int *level_found,
> > + CpuTopologyLevel
> > topo_level) {
>
> This is a very long name :-).
>
> Maybe we can rename it like:
>
> machine_find_lowest_level_cache_at_topo_level,
>
> (sorry this name doesn't shorten the length but align the naming style
> in machine-smp.c)
>
> and explain the arguments in the comment.
>
> Furthermore, we can move this one to hw/core/machine-smp.c, too.
>
> > + CpuTopologyLevel level;
> > +
> > + level = machine_get_cache_topo_level(ms,
> > CACHE_LEVEL_AND_TYPE_L1I);
> > + if (level == topo_level) {
> > + *level_found = 1;
> > + return true;
> > + }
> > +
> > + level = machine_get_cache_topo_level(ms,
> > CACHE_LEVEL_AND_TYPE_L1D);
> > + if (level == topo_level) {
> > + *level_found = 1;
> > + return true;
> > + }
> > +
> > + level = machine_get_cache_topo_level(ms,
> > CACHE_LEVEL_AND_TYPE_L2);
> > + if (level == topo_level) {
> > + *level_found = 2;
> > + return true;
> > + }
> > +
> > + level = machine_get_cache_topo_level(ms,
> > CACHE_LEVEL_AND_TYPE_L3);
> > + if (level == topo_level) {
> > + *level_found = 3;
> > + return true;
> > + }
> > +
> > + return false;
> > +}
> > +
> > type_init(cpu_core_register_types)
>
> ...
>
> > diff --git a/include/hw/cpu/core.h b/include/hw/cpu/core.h
> > index 98ab91647e..0f7bf8bc28 100644
> > --- a/include/hw/cpu/core.h
> > +++ b/include/hw/cpu/core.h
> > @@ -11,6 +11,7 @@
> >
> > #include "hw/qdev-core.h"
> > #include "qom/object.h"
> > +#include "qapi/qapi-types-machine-common.h"
> >
> > #define TYPE_CPU_CORE "cpu-core"
> >
> > @@ -25,6 +26,32 @@ struct CPUCore {
> > int nr_threads;
> > };
> >
> > +typedef enum CPUCacheType {
> > + CPU_CORE_DATA,
> > + CPU_CORE_INSTRUCTION,
> > + CPU_CORE_UNIFIED,
> > +} CPUCoreCacheType;
>
> This is a complete duplicate of the x86's CPUCaches
> (target/i386/cpu.h).
>
> I think we can move x86's CPUCaches to include/hw/core/cpu.h.
>
> > +typedef struct CPUPPTTCaches {
> > + CPUCoreCacheType type;
> > + uint32_t pptt_id;
> > + uint32_t sets;
> > + uint32_t size;
> > + uint32_t level;
> > + uint16_t linesize;
> > + uint8_t attributes; /* write policy: 0x0 write back, 0x1 write
> > through */
> > + uint8_t associativity;
> > +} CPUCorePPTTCaches;
>
> x86 doesn't use PPTT to describe cache so it's not necessary to reuse
> CPUCacheInfo (target/i386/cpu.h) for PPTT.
>
> But I understand it's better to place this sturct in
> include/hw/acpi/cpu.h, since it is part of the ACPI PPTT table.
>
> > +int partial_cache_description(const MachineState *ms,
> > CPUCorePPTTCaches *caches,
> > + int num_caches);
>
> Could move to include/hw/acpi/cpu.h, too.
>
> > +bool cache_described_at(const MachineState *ms, CpuTopologyLevel
> > level); +
> > +bool find_the_lowest_level_cache_defined_at_level(const
> > MachineState *ms,
> > + int *level_found,
> > + CpuTopologyLevel
> > topo_level);
> > +
>
> Because these 2 functions' definitions would be moved to
> hw/core/machine-smp.c, then we need to move their declarations to
> include/hw/boards.h.
>
>
> Except the above nits, the general part is fine for me.
>
> Thanks,
> Zhao
>
>
>
Hi Zhao,
Thanks for the feedback, I was actually unsure about the structure, and
was looking to get some feedback here, to see where to put what! I
will go over the suggestions, and take note. In the meantime,
let's see if we can get some more review here.
Alireza
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v12 2/6] arm/virt.c: add cache hierarchy to device tree
2025-06-04 13:34 ` [PATCH v12 2/6] arm/virt.c: add cache hierarchy to device tree Alireza Sanaee via
@ 2025-06-05 9:44 ` Zhao Liu
2025-06-05 9:40 ` Alireza Sanaee via
2025-06-11 11:38 ` Alireza Sanaee via
0 siblings, 2 replies; 14+ messages in thread
From: Zhao Liu @ 2025-06-05 9:44 UTC (permalink / raw)
To: Alireza Sanaee
Cc: mst, anisinha, armbru, berrange, dapeng1.mi, eric.auger, farman,
gustavo.romero, imammedo, jiangkunkun, jonathan.cameron, linuxarm,
mtosatti, peter.maydell, philmd, qemu-arm, qemu-devel,
richard.henderson, shameerali.kolothum.thodi, shannon.zhaosl,
yangyicong, maobibo
Hi Ali,
I'm very sorry to bother you with some comments after so many versions.
> diff --git a/hw/cpu/core.c b/hw/cpu/core.c
> index 5cb2e9a7f5..7339782663 100644
> --- a/hw/cpu/core.c
> +++ b/hw/cpu/core.c
core.c is not the right place. It just contains the "cpu-core"
abstraction. So we need to move the following functions to other files.
> @@ -102,4 +102,96 @@ static void cpu_core_register_types(void)
> type_register_static(&cpu_core_type_info);
> }
>
> +bool cache_described_at(const MachineState *ms, CpuTopologyLevel level)
It's better to add the comment about what this function did. (its name
doesn't reflect it wants to check the coresponding CPU topology level.)
I also feel it's not a good name, what about "machine_check_cache_at_topo_level"?
Furthermore, we can move this one to hw/core/machine-smp.c, as it is
about with machine's smp_cache.
> +{
> + if (machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L3) == level ||
> + machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L2) == level ||
> + machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1I) == level ||
> + machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1D) == level) {
> + return true;
> + }
> + return false;
> +}
> +
> +int partial_cache_description(const MachineState *ms, CPUCorePPTTCaches *caches,
> + int num_caches)
Because I'll suggest to move CPUCorePPTTCaches to include/hw/acpi/cpu.h
later, and this function accepts CPUCorePPTTCaches as the argument, so
I think we could move this function to hw/acpi/cpu.c (if Michael and
Igor don't object).
> +{
> + int level, c;
> +
> + for (level = 1; level < num_caches; level++) {
> + for (c = 0; c < num_caches; c++) {
> + if (caches[c].level != level) {
> + continue;
> + }
> +
> + switch (level) {
> + case 1:
> + /*
> + * L1 cache is assumed to have both L1I and L1D available.
> + * Technically both need to be checked.
> + */
> + if (machine_get_cache_topo_level(ms,
> + CACHE_LEVEL_AND_TYPE_L1I) ==
> + CPU_TOPOLOGY_LEVEL_DEFAULT) {
> + return level;
> + }
> + break;
> + case 2:
> + if (machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L2) ==
> + CPU_TOPOLOGY_LEVEL_DEFAULT) {
> + return level;
> + }
> + break;
> + case 3:
> + if (machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L3) ==
> + CPU_TOPOLOGY_LEVEL_DEFAULT) {
> + return level;
> + }
> + break;
> + }
> + }
> + }
> +
> + return 0;
> +}
> +
> +/*
> + * This function assumes l3 and l2 have unified cache and l1 is split l1d
> + * and l1i, and further prepares the lowest cache level for a topology
> + * level. The info will be fed to build_caches to create caches at the
> + * right level.
> + */
> +bool find_the_lowest_level_cache_defined_at_level(const MachineState *ms,
> + int *level_found,
> + CpuTopologyLevel topo_level) {
This is a very long name :-).
Maybe we can rename it like:
machine_find_lowest_level_cache_at_topo_level,
(sorry this name doesn't shorten the length but align the naming style
in machine-smp.c)
and explain the arguments in the comment.
Furthermore, we can move this one to hw/core/machine-smp.c, too.
> + CpuTopologyLevel level;
> +
> + level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1I);
> + if (level == topo_level) {
> + *level_found = 1;
> + return true;
> + }
> +
> + level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1D);
> + if (level == topo_level) {
> + *level_found = 1;
> + return true;
> + }
> +
> + level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L2);
> + if (level == topo_level) {
> + *level_found = 2;
> + return true;
> + }
> +
> + level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L3);
> + if (level == topo_level) {
> + *level_found = 3;
> + return true;
> + }
> +
> + return false;
> +}
> +
> type_init(cpu_core_register_types)
...
> diff --git a/include/hw/cpu/core.h b/include/hw/cpu/core.h
> index 98ab91647e..0f7bf8bc28 100644
> --- a/include/hw/cpu/core.h
> +++ b/include/hw/cpu/core.h
> @@ -11,6 +11,7 @@
>
> #include "hw/qdev-core.h"
> #include "qom/object.h"
> +#include "qapi/qapi-types-machine-common.h"
>
> #define TYPE_CPU_CORE "cpu-core"
>
> @@ -25,6 +26,32 @@ struct CPUCore {
> int nr_threads;
> };
>
> +typedef enum CPUCacheType {
> + CPU_CORE_DATA,
> + CPU_CORE_INSTRUCTION,
> + CPU_CORE_UNIFIED,
> +} CPUCoreCacheType;
This is a complete duplicate of the x86's CPUCaches (target/i386/cpu.h).
I think we can move x86's CPUCaches to include/hw/core/cpu.h.
> +typedef struct CPUPPTTCaches {
> + CPUCoreCacheType type;
> + uint32_t pptt_id;
> + uint32_t sets;
> + uint32_t size;
> + uint32_t level;
> + uint16_t linesize;
> + uint8_t attributes; /* write policy: 0x0 write back, 0x1 write through */
> + uint8_t associativity;
> +} CPUCorePPTTCaches;
x86 doesn't use PPTT to describe cache so it's not necessary to reuse
CPUCacheInfo (target/i386/cpu.h) for PPTT.
But I understand it's better to place this sturct in include/hw/acpi/cpu.h,
since it is part of the ACPI PPTT table.
> +int partial_cache_description(const MachineState *ms, CPUCorePPTTCaches *caches,
> + int num_caches);
Could move to include/hw/acpi/cpu.h, too.
> +bool cache_described_at(const MachineState *ms, CpuTopologyLevel level);
> +
> +bool find_the_lowest_level_cache_defined_at_level(const MachineState *ms,
> + int *level_found,
> + CpuTopologyLevel topo_level);
> +
Because these 2 functions' definitions would be moved to
hw/core/machine-smp.c, then we need to move their declarations to
include/hw/boards.h.
Except the above nits, the general part is fine for me.
Thanks,
Zhao
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v12 5/6] tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology
2025-06-04 13:34 ` [PATCH v12 5/6] tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology Alireza Sanaee via
@ 2025-06-05 9:46 ` Zhao Liu
0 siblings, 0 replies; 14+ messages in thread
From: Zhao Liu @ 2025-06-05 9:46 UTC (permalink / raw)
To: Alireza Sanaee
Cc: mst, anisinha, armbru, berrange, dapeng1.mi, eric.auger, farman,
gustavo.romero, imammedo, jiangkunkun, jonathan.cameron, linuxarm,
mtosatti, peter.maydell, philmd, qemu-arm, qemu-devel,
richard.henderson, shameerali.kolothum.thodi, shannon.zhaosl,
yangyicong, maobibo
On Wed, Jun 04, 2025 at 02:34:38PM +0100, Alireza Sanaee wrote:
> Date: Wed, 4 Jun 2025 14:34:38 +0100
> From: Alireza Sanaee <alireza.sanaee@huawei.com>
> Subject: [PATCH v12 5/6] tests/qtest/bios-table-test: testing new ARM ACPI
> PPTT topology
> X-Mailer: git-send-email 2.34.1
>
> Test new PPTT topolopy with cache representation.
>
> Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> tests/qtest/bios-tables-test.c | 4 ++++
> 1 file changed, 4 insertions(+)>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v12 6/6] Update the ACPI tables based on new aml-build.c
2025-06-04 13:34 ` [PATCH v12 6/6] Update the ACPI tables based on new aml-build.c Alireza Sanaee via
@ 2025-06-05 9:47 ` Zhao Liu
0 siblings, 0 replies; 14+ messages in thread
From: Zhao Liu @ 2025-06-05 9:47 UTC (permalink / raw)
To: Alireza Sanaee
Cc: mst, anisinha, armbru, berrange, dapeng1.mi, eric.auger, farman,
gustavo.romero, imammedo, jiangkunkun, jonathan.cameron, linuxarm,
mtosatti, peter.maydell, philmd, qemu-arm, qemu-devel,
richard.henderson, shameerali.kolothum.thodi, shannon.zhaosl,
yangyicong, maobibo
On Wed, Jun 04, 2025 at 02:34:39PM +0100, Alireza Sanaee wrote:
> Date: Wed, 4 Jun 2025 14:34:39 +0100
> From: Alireza Sanaee <alireza.sanaee@huawei.com>
> Subject: [PATCH v12 6/6] Update the ACPI tables based on new aml-build.c
> X-Mailer: git-send-email 2.34.1
>
> The disassembled differences between actual and expected PPTT based on
> the following cache topology representation:
>
> - l1d and l1i shared at cluster level
> - l2 shared at cluster level
> - l3 shared at cluster level
>
> /*
> * Intel ACPI Component Architecture
> * AML/ASL+ Disassembler version 20230628 (64-bit version)
> * Copyright (c) 2000 - 2023 Intel Corporation
> *
> * Disassembly of tests/data/acpi/aarch64/virt/PPTT.topology, Tue Jun 3 13:48:43 2025
> * Disassembly of /tmp/aml-424862, Tue Jun 3 13:48:43 2025
> *
> * ACPI Data Table [PPTT]
> *
> * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue (in hex)
> */
>
> [000h 0000 004h] Signature : "PPTT" [Processor Properties Topology Table]
> [004h 0004 004h] Table Length : 00000164
> [004h 0004 004h] Table Length : 0000021C
> [008h 0008 001h] Revision : 02
> [009h 0009 001h] Checksum : 97
> [009h 0009 001h] Checksum : 4E
> [00Ah 0010 006h] Oem ID : "BOCHS "
> [010h 0016 008h] Oem Table ID : "BXPC "
> [018h 0024 004h] Oem Revision : 00000001
> [01Ch 0028 004h] Asl Compiler ID : "BXPC"
> [020h 0032 004h] Asl Compiler Revision : 00000001
>
> [024h 0036 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [025h 0037 001h] Length : 14
> [026h 0038 002h] Reserved : 0000
> [028h 0040 004h] Flags (decoded below) : 00000011
> Physical package : 1
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> @ -34,223 +34,370 @@
> [030h 0048 004h] ACPI Processor ID : 00000000
> [034h 0052 004h] Private Resource Number : 00000000
>
> [038h 0056 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [039h 0057 001h] Length : 14
> [03Ah 0058 002h] Reserved : 0000
> [03Ch 0060 004h] Flags (decoded below) : 00000011
> Physical package : 1
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [040h 0064 004h] Parent : 00000024
> [044h 0068 004h] ACPI Processor ID : 00000000
> [048h 0072 004h] Private Resource Number : 00000000
>
> [04Ch 0076 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [04Dh 0077 001h] Length : 14
> [04Ch 0076 001h] Subtable Type : 01 [Cache Type]
> [04Dh 0077 001h] Length : 1C
> [04Eh 0078 002h] Reserved : 0000
> [050h 0080 004h] Flags (decoded below) : 00000010
> [050h 0080 004h] Flags (decoded below) : 000000FF
> Size valid : 1
> Number of Sets valid : 1
> Associativity valid : 1
> Allocation Type valid : 1
> Cache Type valid : 1
> Write Policy valid : 1
> Line Size valid : 1
> Cache ID valid : 1
> [054h 0084 004h] Next Level of Cache : 00000000
> [058h 0088 004h] Size : 00200000
> [05Ch 0092 004h] Number of Sets : 00000800
> [060h 0096 001h] Associativity : 10
> [061h 0097 001h] Attributes : 0F
> Allocation Type : 3
> Cache Type : 3
> Write Policy : 0
> [062h 0098 002h] Line Size : 0040
>
> [068h 0104 001h] Subtable Type : 01 [Cache Type]
> [069h 0105 001h] Length : 1C
> [06Ah 0106 002h] Reserved : 0000
> [06Ch 0108 004h] Flags (decoded below) : 000000FF
> Size valid : 1
> Number of Sets valid : 1
> Associativity valid : 1
> Allocation Type valid : 1
> Cache Type valid : 1
> Write Policy valid : 1
> Line Size valid : 1
> Cache ID valid : 1
> [070h 0112 004h] Next Level of Cache : 0000004C
> [074h 0116 004h] Size : 00008000
> [078h 0120 004h] Number of Sets : 00000080
> [07Ch 0124 001h] Associativity : 04
> [07Dh 0125 001h] Attributes : 03
> Allocation Type : 3
> Cache Type : 0
> Write Policy : 0
> [07Eh 0126 002h] Line Size : 0040
>
> [084h 0132 001h] Subtable Type : 01 [Cache Type]
> [085h 0133 001h] Length : 1C
> [086h 0134 002h] Reserved : 0000
> [088h 0136 004h] Flags (decoded below) : 000000FF
> Size valid : 1
> Number of Sets valid : 1
> Associativity valid : 1
> Allocation Type valid : 1
> Cache Type valid : 1
> Write Policy valid : 1
> Line Size valid : 1
> Cache ID valid : 1
> [08Ch 0140 004h] Next Level of Cache : 0000004C
> [090h 0144 004h] Size : 0000C000
> [094h 0148 004h] Number of Sets : 00000100
> [098h 0152 001h] Associativity : 03
> [099h 0153 001h] Attributes : 07
> Allocation Type : 3
> Cache Type : 1
> Write Policy : 0
> [09Ah 0154 002h] Line Size : 0040
>
> [0A0h 0160 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [0A1h 0161 001h] Length : 1C
> [0A2h 0162 002h] Reserved : 0000
> [0A4h 0164 004h] Flags (decoded below) : 00000010
> Physical package : 0
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [054h 0084 004h] Parent : 00000038
> [058h 0088 004h] ACPI Processor ID : 00000000
> [05Ch 0092 004h] Private Resource Number : 00000000
>
> [060h 0096 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [061h 0097 001h] Length : 14
> [062h 0098 002h] Reserved : 0000
> [064h 0100 004h] Flags (decoded below) : 00000010
> [0A8h 0168 004h] Parent : 00000038
> [0ACh 0172 004h] ACPI Processor ID : 00000000
> [0B0h 0176 004h] Private Resource Number : 00000002
> [0B4h 0180 004h] Private Resource : 00000084
> [0B8h 0184 004h] Private Resource : 00000068
>
> [0BCh 0188 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [0BDh 0189 001h] Length : 14
> [0BEh 0190 002h] Reserved : 0000
> [0C0h 0192 004h] Flags (decoded below) : 00000010
> Physical package : 0
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [068h 0104 004h] Parent : 0000004C
> [06Ch 0108 004h] ACPI Processor ID : 00000000
> [070h 0112 004h] Private Resource Number : 00000000
>
> [074h 0116 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [075h 0117 001h] Length : 14
> [076h 0118 002h] Reserved : 0000
> [078h 0120 004h] Flags (decoded below) : 0000000E
> [0C4h 0196 004h] Parent : 000000A0
> [0C8h 0200 004h] ACPI Processor ID : 00000000
> [0CCh 0204 004h] Private Resource Number : 00000000
>
> [0D0h 0208 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [0D1h 0209 001h] Length : 14
> [0D2h 0210 002h] Reserved : 0000
> [0D4h 0212 004h] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [07Ch 0124 004h] Parent : 00000060
> [080h 0128 004h] ACPI Processor ID : 00000000
> [084h 0132 004h] Private Resource Number : 00000000
>
> [088h 0136 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [089h 0137 001h] Length : 14
> [08Ah 0138 002h] Reserved : 0000
> [08Ch 0140 004h] Flags (decoded below) : 0000000E
> [0D8h 0216 004h] Parent : 000000BC
> [0DCh 0220 004h] ACPI Processor ID : 00000000
> [0E0h 0224 004h] Private Resource Number : 00000000
>
> [0E4h 0228 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [0E5h 0229 001h] Length : 14
> [0E6h 0230 002h] Reserved : 0000
> [0E8h 0232 004h] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [090h 0144 004h] Parent : 00000060
> [094h 0148 004h] ACPI Processor ID : 00000001
> [098h 0152 004h] Private Resource Number : 00000000
>
> [09Ch 0156 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [09Dh 0157 001h] Length : 14
> [09Eh 0158 002h] Reserved : 0000
> [0A0h 0160 004h] Flags (decoded below) : 00000010
> [0ECh 0236 004h] Parent : 000000BC
> [0F0h 0240 004h] ACPI Processor ID : 00000001
> [0F4h 0244 004h] Private Resource Number : 00000000
>
> [0F8h 0248 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [0F9h 0249 001h] Length : 14
> [0FAh 0250 002h] Reserved : 0000
> [0FCh 0252 004h] Flags (decoded below) : 00000010
> Physical package : 0
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [0A4h 0164 004h] Parent : 0000004C
> [0A8h 0168 004h] ACPI Processor ID : 00000001
> [0ACh 0172 004h] Private Resource Number : 00000000
>
> [0B0h 0176 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [0B1h 0177 001h] Length : 14
> [0B2h 0178 002h] Reserved : 0000
> [0B4h 0180 004h] Flags (decoded below) : 0000000E
> [100h 0256 004h] Parent : 000000A0
> [104h 0260 004h] ACPI Processor ID : 00000001
> [108h 0264 004h] Private Resource Number : 00000000
>
> [10Ch 0268 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [10Dh 0269 001h] Length : 14
> [10Eh 0270 002h] Reserved : 0000
> [110h 0272 004h] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [0B8h 0184 004h] Parent : 0000009C
> [0BCh 0188 004h] ACPI Processor ID : 00000002
> [0C0h 0192 004h] Private Resource Number : 00000000
>
> [0C4h 0196 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [0C5h 0197 001h] Length : 14
> [0C6h 0198 002h] Reserved : 0000
> [0C8h 0200 004h] Flags (decoded below) : 0000000E
> [114h 0276 004h] Parent : 000000F8
> [118h 0280 004h] ACPI Processor ID : 00000002
> [11Ch 0284 004h] Private Resource Number : 00000000
>
> [120h 0288 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [121h 0289 001h] Length : 14
> [122h 0290 002h] Reserved : 0000
> [124h 0292 004h] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [0CCh 0204 004h] Parent : 0000009C
> [0D0h 0208 004h] ACPI Processor ID : 00000003
> [0D4h 0212 004h] Private Resource Number : 00000000
>
> [0D8h 0216 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [0D9h 0217 001h] Length : 14
> [0DAh 0218 002h] Reserved : 0000
> [0DCh 0220 004h] Flags (decoded below) : 00000010
> [128h 0296 004h] Parent : 000000F8
> [12Ch 0300 004h] ACPI Processor ID : 00000003
> [130h 0304 004h] Private Resource Number : 00000000
>
> [134h 0308 001h] Subtable Type : 01 [Cache Type]
> [135h 0309 001h] Length : 1C
> [136h 0310 002h] Reserved : 0000
> [138h 0312 004h] Flags (decoded below) : 000000FF
> Size valid : 1
> Number of Sets valid : 1
> Associativity valid : 1
> Allocation Type valid : 1
> Cache Type valid : 1
> Write Policy valid : 1
> Line Size valid : 1
> Cache ID valid : 1
> [13Ch 0316 004h] Next Level of Cache : 00000000
> [140h 0320 004h] Size : 00200000
> [144h 0324 004h] Number of Sets : 00000800
> [148h 0328 001h] Associativity : 10
> [149h 0329 001h] Attributes : 0F
> Allocation Type : 3
> Cache Type : 3
> Write Policy : 0
> [14Ah 0330 002h] Line Size : 0040
>
> [150h 0336 001h] Subtable Type : 01 [Cache Type]
> [151h 0337 001h] Length : 1C
> [152h 0338 002h] Reserved : 0000
> [154h 0340 004h] Flags (decoded below) : 000000FF
> Size valid : 1
> Number of Sets valid : 1
> Associativity valid : 1
> Allocation Type valid : 1
> Cache Type valid : 1
> Write Policy valid : 1
> Line Size valid : 1
> Cache ID valid : 1
> [158h 0344 004h] Next Level of Cache : 00000134
> [15Ch 0348 004h] Size : 00008000
> [160h 0352 004h] Number of Sets : 00000080
> [164h 0356 001h] Associativity : 04
> [165h 0357 001h] Attributes : 03
> Allocation Type : 3
> Cache Type : 0
> Write Policy : 0
> [166h 0358 002h] Line Size : 0040
>
> [16Ch 0364 001h] Subtable Type : 01 [Cache Type]
> [16Dh 0365 001h] Length : 1C
> [16Eh 0366 002h] Reserved : 0000
> [170h 0368 004h] Flags (decoded below) : 000000FF
> Size valid : 1
> Number of Sets valid : 1
> Associativity valid : 1
> Allocation Type valid : 1
> Cache Type valid : 1
> Write Policy valid : 1
> Line Size valid : 1
> Cache ID valid : 1
> [174h 0372 004h] Next Level of Cache : 00000134
> [178h 0376 004h] Size : 0000C000
> [17Ch 0380 004h] Number of Sets : 00000100
> [180h 0384 001h] Associativity : 03
> [181h 0385 001h] Attributes : 07
> Allocation Type : 3
> Cache Type : 1
> Write Policy : 0
> [182h 0386 002h] Line Size : 0040
>
> [188h 0392 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [189h 0393 001h] Length : 1C
> [18Ah 0394 002h] Reserved : 0000
> [18Ch 0396 004h] Flags (decoded below) : 00000010
> Physical package : 0
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [0E0h 0224 004h] Parent : 00000038
> [0E4h 0228 004h] ACPI Processor ID : 00000001
> [0E8h 0232 004h] Private Resource Number : 00000000
>
> [0ECh 0236 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [0EDh 0237 001h] Length : 14
> [0EEh 0238 002h] Reserved : 0000
> [0F0h 0240 004h] Flags (decoded below) : 00000010
> [190h 0400 004h] Parent : 00000038
> [194h 0404 004h] ACPI Processor ID : 00000001
> [198h 0408 004h] Private Resource Number : 00000002
> [19Ch 0412 004h] Private Resource : 0000016C
> [1A0h 0416 004h] Private Resource : 00000150
>
> [1A4h 0420 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [1A5h 0421 001h] Length : 14
> [1A6h 0422 002h] Reserved : 0000
> [1A8h 0424 004h] Flags (decoded below) : 00000010
> Physical package : 0
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [0F4h 0244 004h] Parent : 000000D8
> [0F8h 0248 004h] ACPI Processor ID : 00000000
> [0FCh 0252 004h] Private Resource Number : 00000000
>
> [100h 0256 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [101h 0257 001h] Length : 14
> [102h 0258 002h] Reserved : 0000
> [104h 0260 004h] Flags (decoded below) : 0000000E
> [1ACh 0428 004h] Parent : 00000188
> [1B0h 0432 004h] ACPI Processor ID : 00000000
> [1B4h 0436 004h] Private Resource Number : 00000000
>
> [1B8h 0440 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [1B9h 0441 001h] Length : 14
> [1BAh 0442 002h] Reserved : 0000
> [1BCh 0444 004h] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [108h 0264 004h] Parent : 000000EC
> [10Ch 0268 004h] ACPI Processor ID : 00000004
> [110h 0272 004h] Private Resource Number : 00000000
>
> [114h 0276 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [115h 0277 001h] Length : 14
> [116h 0278 002h] Reserved : 0000
> [118h 0280 004h] Flags (decoded below) : 0000000E
> [1C0h 0448 004h] Parent : 000001A4
> [1C4h 0452 004h] ACPI Processor ID : 00000004
> [1C8h 0456 004h] Private Resource Number : 00000000
>
> [1CCh 0460 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [1CDh 0461 001h] Length : 14
> [1CEh 0462 002h] Reserved : 0000
> [1D0h 0464 004h] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [11Ch 0284 004h] Parent : 000000EC
> [120h 0288 004h] ACPI Processor ID : 00000005
> [124h 0292 004h] Private Resource Number : 00000000
>
> [128h 0296 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [129h 0297 001h] Length : 14
> [12Ah 0298 002h] Reserved : 0000
> [12Ch 0300 004h] Flags (decoded below) : 00000010
> [1D4h 0468 004h] Parent : 000001A4
> [1D8h 0472 004h] ACPI Processor ID : 00000005
> [1DCh 0476 004h] Private Resource Number : 00000000
>
> [1E0h 0480 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [1E1h 0481 001h] Length : 14
> [1E2h 0482 002h] Reserved : 0000
> [1E4h 0484 004h] Flags (decoded below) : 00000010
> Physical package : 0
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [130h 0304 004h] Parent : 000000D8
> [134h 0308 004h] ACPI Processor ID : 00000001
> [138h 0312 004h] Private Resource Number : 00000000
>
> [13Ch 0316 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [13Dh 0317 001h] Length : 14
> [13Eh 0318 002h] Reserved : 0000
> [140h 0320 004h] Flags (decoded below) : 0000000E
> [1E8h 0488 004h] Parent : 00000188
> [1ECh 0492 004h] ACPI Processor ID : 00000001
> [1F0h 0496 004h] Private Resource Number : 00000000
>
> [1F4h 0500 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [1F5h 0501 001h] Length : 14
> [1F6h 0502 002h] Reserved : 0000
> [1F8h 0504 004h] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [144h 0324 004h] Parent : 00000128
> [148h 0328 004h] ACPI Processor ID : 00000006
> [14Ch 0332 004h] Private Resource Number : 00000000
>
> [150h 0336 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [151h 0337 001h] Length : 14
> [152h 0338 002h] Reserved : 0000
> [154h 0340 004h] Flags (decoded below) : 0000000E
> [1FCh 0508 004h] Parent : 000001E0
> [200h 0512 004h] ACPI Processor ID : 00000006
> [204h 0516 004h] Private Resource Number : 00000000
>
> [208h 0520 001h] Subtable Type : 00 [Processor Hierarchy Node]
> [209h 0521 001h] Length : 14
> [20Ah 0522 002h] Reserved : 0000
> [20Ch 0524 004h] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [158h 0344 004h] Parent : 00000128
> [15Ch 0348 004h] ACPI Processor ID : 00000007
> [160h 0352 004h] Private Resource Number : 00000000
> [210h 0528 004h] Parent : 000001E0
> [214h 0532 004h] ACPI Processor ID : 00000007
> [218h 0536 004h] Private Resource Number : 00000000
>
> Raw Table Data: Length 356 (0x164)
> Raw Table Data: Length 540 (0x21C)
>
> 0000: 50 50 54 54 64 01 00 00 02 97 42 4F 43 48 53 20 // PPTTd.....BOCHS
> 0000: 50 50 54 54 1C 02 00 00 02 4E 42 4F 43 48 53 20 // PPTT.....NBOCHS
> 0010: 42 58 50 43 20 20 20 20 01 00 00 00 42 58 50 43 // BXPC ....BXPC
> 0020: 01 00 00 00 00 14 00 00 11 00 00 00 00 00 00 00 // ................
> 0030: 00 00 00 00 00 00 00 00 00 14 00 00 11 00 00 00 // ................
> 0040: 24 00 00 00 00 00 00 00 00 00 00 00 00 14 00 00 // $...............
> 0050: 10 00 00 00 38 00 00 00 00 00 00 00 00 00 00 00 // ....8...........
> 0060: 00 14 00 00 10 00 00 00 4C 00 00 00 00 00 00 00 // ........L.......
> 0070: 00 00 00 00 00 14 00 00 0E 00 00 00 60 00 00 00 // ............`...
> 0080: 00 00 00 00 00 00 00 00 00 14 00 00 0E 00 00 00 // ................
> 0090: 60 00 00 00 01 00 00 00 00 00 00 00 00 14 00 00 // `...............
> 00A0: 10 00 00 00 4C 00 00 00 01 00 00 00 00 00 00 00 // ....L...........
> 00B0: 00 14 00 00 0E 00 00 00 9C 00 00 00 02 00 00 00 // ................
> 00C0: 00 00 00 00 00 14 00 00 0E 00 00 00 9C 00 00 00 // ................
> 00D0: 03 00 00 00 00 00 00 00 00 14 00 00 10 00 00 00 // ................
> 00E0: 38 00 00 00 01 00 00 00 00 00 00 00 00 14 00 00 // 8...............
> 00F0: 10 00 00 00 D8 00 00 00 00 00 00 00 00 00 00 00 // ................
> 0100: 00 14 00 00 0E 00 00 00 EC 00 00 00 04 00 00 00 // ................
> 0110: 00 00 00 00 00 14 00 00 0E 00 00 00 EC 00 00 00 // ................
> 0120: 05 00 00 00 00 00 00 00 00 14 00 00 10 00 00 00 // ................
> 0130: D8 00 00 00 01 00 00 00 00 00 00 00 00 14 00 00 // ................
> 0140: 0E 00 00 00 28 01 00 00 06 00 00 00 00 00 00 00 // ....(...........
> 0150: 00 14 00 00 0E 00 00 00 28 01 00 00 07 00 00 00 // ........(.......
> 0160: 00 00 00 00 // ....
> 0040: 24 00 00 00 00 00 00 00 00 00 00 00 01 1C 00 00 // $...............
> 0050: FF 00 00 00 00 00 00 00 00 00 20 00 00 08 00 00 // .......... .....
> 0060: 10 0F 40 00 00 00 02 02 01 1C 00 00 FF 00 00 00 // ..@.............
> 0070: 4C 00 00 00 00 80 00 00 80 00 00 00 04 03 40 00 // L.............@.
> 0080: 00 00 01 00 01 1C 00 00 FF 00 00 00 4C 00 00 00 // ............L...
> 0090: 00 C0 00 00 00 01 00 00 03 07 40 00 00 00 01 01 // ..........@.....
> 00A0: 00 1C 00 00 10 00 00 00 38 00 00 00 00 00 00 00 // ........8.......
> 00B0: 02 00 00 00 84 00 00 00 68 00 00 00 00 14 00 00 // ........h.......
> 00C0: 10 00 00 00 A0 00 00 00 00 00 00 00 00 00 00 00 // ................
> 00D0: 00 14 00 00 0E 00 00 00 BC 00 00 00 00 00 00 00 // ................
> 00E0: 00 00 00 00 00 14 00 00 0E 00 00 00 BC 00 00 00 // ................
> 00F0: 01 00 00 00 00 00 00 00 00 14 00 00 10 00 00 00 // ................
> 0100: A0 00 00 00 01 00 00 00 00 00 00 00 00 14 00 00 // ................
> 0110: 0E 00 00 00 F8 00 00 00 02 00 00 00 00 00 00 00 // ................
> 0120: 00 14 00 00 0E 00 00 00 F8 00 00 00 03 00 00 00 // ................
> 0130: 00 00 00 00 01 1C 00 00 FF 00 00 00 00 00 00 00 // ................
> 0140: 00 00 20 00 00 08 00 00 10 0F 40 00 04 00 02 02 // .. .......@.....
> 0150: 01 1C 00 00 FF 00 00 00 34 01 00 00 00 80 00 00 // ........4.......
> 0160: 80 00 00 00 04 03 40 00 04 00 01 00 01 1C 00 00 // ......@.........
> 0170: FF 00 00 00 34 01 00 00 00 C0 00 00 00 01 00 00 // ....4...........
> 0180: 03 07 40 00 04 00 01 01 00 1C 00 00 10 00 00 00 // ..@.............
> 0190: 38 00 00 00 01 00 00 00 02 00 00 00 6C 01 00 00 // 8...........l...
> 01A0: 50 01 00 00 00 14 00 00 10 00 00 00 88 01 00 00 // P...............
> 01B0: 00 00 00 00 00 00 00 00 00 14 00 00 0E 00 00 00 // ................
> 01C0: A4 01 00 00 04 00 00 00 00 00 00 00 00 14 00 00 // ................
> 01D0: 0E 00 00 00 A4 01 00 00 05 00 00 00 00 00 00 00 // ................
> 01E0: 00 14 00 00 10 00 00 00 88 01 00 00 01 00 00 00 // ................
> 01F0: 00 00 00 00 00 14 00 00 0E 00 00 00 E0 01 00 00 // ................
> 0200: 06 00 00 00 00 00 00 00 00 14 00 00 0E 00 00 00 // ................
> 0210: E0 01 00 00 07 00 00 00 00 00 00 00 // ............
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
> ---
> tests/data/acpi/aarch64/virt/PPTT.topology | Bin 356 -> 540 bytes
> tests/qtest/bios-tables-test-allowed-diff.h | 3 ---
> 2 files changed, 3 deletions(-)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v12 2/6] arm/virt.c: add cache hierarchy to device tree
2025-06-05 9:40 ` Alireza Sanaee via
@ 2025-06-05 13:58 ` Zhao Liu
0 siblings, 0 replies; 14+ messages in thread
From: Zhao Liu @ 2025-06-05 13:58 UTC (permalink / raw)
To: Alireza Sanaee
Cc: mst, anisinha, armbru, berrange, dapeng1.mi, eric.auger, farman,
gustavo.romero, imammedo, jiangkunkun, jonathan.cameron, linuxarm,
mtosatti, peter.maydell, philmd, qemu-arm, qemu-devel,
richard.henderson, shameerali.kolothum.thodi, shannon.zhaosl,
yangyicong, maobibo
> Hi Zhao,
>
> Thanks for the feedback, I was actually unsure about the structure, and
> was looking to get some feedback here, to see where to put what! I
> will go over the suggestions, and take note. In the meantime, let's see
> if we can get some more review here.
Sure! BTW, it's better to spilt the general code change (not ARM-specific
codes) into a separate patch. Anyway, it's up to you.
Regards,
Zhao
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v12 2/6] arm/virt.c: add cache hierarchy to device tree
2025-06-05 9:44 ` Zhao Liu
2025-06-05 9:40 ` Alireza Sanaee via
@ 2025-06-11 11:38 ` Alireza Sanaee via
1 sibling, 0 replies; 14+ messages in thread
From: Alireza Sanaee via @ 2025-06-11 11:38 UTC (permalink / raw)
To: Zhao Liu
Cc: mst, anisinha, armbru, berrange, dapeng1.mi, eric.auger, farman,
gustavo.romero, imammedo, jiangkunkun, jonathan.cameron, linuxarm,
mtosatti, peter.maydell, philmd, qemu-arm, qemu-devel,
richard.henderson, shameerali.kolothum.thodi, shannon.zhaosl,
yangyicong, maobibo
On Thu, 5 Jun 2025 17:44:52 +0800
Zhao Liu <zhao1.liu@intel.com> wrote:
> Hi Ali,
>
> I'm very sorry to bother you with some comments after so many
> versions.
>
> > diff --git a/hw/cpu/core.c b/hw/cpu/core.c
> > index 5cb2e9a7f5..7339782663 100644
> > --- a/hw/cpu/core.c
> > +++ b/hw/cpu/core.c
>
> core.c is not the right place. It just contains the "cpu-core"
> abstraction. So we need to move the following functions to other
> files.
>
> > @@ -102,4 +102,96 @@ static void cpu_core_register_types(void)
> > type_register_static(&cpu_core_type_info);
> > }
> >
> > +bool cache_described_at(const MachineState *ms, CpuTopologyLevel
> > level)
>
> It's better to add the comment about what this function did. (its name
> doesn't reflect it wants to check the coresponding CPU topology
> level.)
>
> I also feel it's not a good name, what about
> "machine_check_cache_at_topo_level"?
>
> Furthermore, we can move this one to hw/core/machine-smp.c, as it is
> about with machine's smp_cache.
>
> > +{
> > + if (machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L3)
> > == level ||
> > + machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L2)
> > == level ||
> > + machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1I)
> > == level ||
> > + machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1D)
> > == level) {
> > + return true;
> > + }
> > + return false;
> > +}
> > +
> > +int partial_cache_description(const MachineState *ms,
> > CPUCorePPTTCaches *caches,
> > + int num_caches)
>
> Because I'll suggest to move CPUCorePPTTCaches to
> include/hw/acpi/cpu.h later, and this function accepts
> CPUCorePPTTCaches as the argument, so I think we could move this
> function to hw/acpi/cpu.c (if Michael and Igor don't object).
Hi Zhao
partial_cache_description function has been used in both hw/arm/virt.c
and hw/acpi/aml-build.c it feels like it neither for arm nor acpi.
Where do you think it is better to be placed at? does it go to core
maybe?
Thanks
Alirez
>
> > +{
> > + int level, c;
> > +
> > + for (level = 1; level < num_caches; level++) {
> > + for (c = 0; c < num_caches; c++) {
> > + if (caches[c].level != level) {
> > + continue;
> > + }
> > +
> > + switch (level) {
> > + case 1:
> > + /*
> > + * L1 cache is assumed to have both L1I and L1D
> > available.
> > + * Technically both need to be checked.
> > + */
> > + if (machine_get_cache_topo_level(ms,
> > +
> > CACHE_LEVEL_AND_TYPE_L1I) ==
> > + CPU_TOPOLOGY_LEVEL_DEFAULT) {
> > + return level;
> > + }
> > + break;
> > + case 2:
> > + if (machine_get_cache_topo_level(ms,
> > CACHE_LEVEL_AND_TYPE_L2) ==
> > + CPU_TOPOLOGY_LEVEL_DEFAULT) {
> > + return level;
> > + }
> > + break;
> > + case 3:
> > + if (machine_get_cache_topo_level(ms,
> > CACHE_LEVEL_AND_TYPE_L3) ==
> > + CPU_TOPOLOGY_LEVEL_DEFAULT) {
> > + return level;
> > + }
> > + break;
> > + }
> > + }
> > + }
> > +
> > + return 0;
> > +}
> > +
> > +/*
> > + * This function assumes l3 and l2 have unified cache and l1 is
> > split l1d
> > + * and l1i, and further prepares the lowest cache level for a
> > topology
> > + * level. The info will be fed to build_caches to create caches
> > at the
> > + * right level.
> > + */
> > +bool find_the_lowest_level_cache_defined_at_level(const
> > MachineState *ms,
> > + int *level_found,
> > + CpuTopologyLevel
> > topo_level) {
>
> This is a very long name :-).
>
> Maybe we can rename it like:
>
> machine_find_lowest_level_cache_at_topo_level,
>
> (sorry this name doesn't shorten the length but align the naming style
> in machine-smp.c)
>
> and explain the arguments in the comment.
>
> Furthermore, we can move this one to hw/core/machine-smp.c, too.
>
> > + CpuTopologyLevel level;
> > +
> > + level = machine_get_cache_topo_level(ms,
> > CACHE_LEVEL_AND_TYPE_L1I);
> > + if (level == topo_level) {
> > + *level_found = 1;
> > + return true;
> > + }
> > +
> > + level = machine_get_cache_topo_level(ms,
> > CACHE_LEVEL_AND_TYPE_L1D);
> > + if (level == topo_level) {
> > + *level_found = 1;
> > + return true;
> > + }
> > +
> > + level = machine_get_cache_topo_level(ms,
> > CACHE_LEVEL_AND_TYPE_L2);
> > + if (level == topo_level) {
> > + *level_found = 2;
> > + return true;
> > + }
> > +
> > + level = machine_get_cache_topo_level(ms,
> > CACHE_LEVEL_AND_TYPE_L3);
> > + if (level == topo_level) {
> > + *level_found = 3;
> > + return true;
> > + }
> > +
> > + return false;
> > +}
> > +
> > type_init(cpu_core_register_types)
>
> ...
>
> > diff --git a/include/hw/cpu/core.h b/include/hw/cpu/core.h
> > index 98ab91647e..0f7bf8bc28 100644
> > --- a/include/hw/cpu/core.h
> > +++ b/include/hw/cpu/core.h
> > @@ -11,6 +11,7 @@
> >
> > #include "hw/qdev-core.h"
> > #include "qom/object.h"
> > +#include "qapi/qapi-types-machine-common.h"
> >
> > #define TYPE_CPU_CORE "cpu-core"
> >
> > @@ -25,6 +26,32 @@ struct CPUCore {
> > int nr_threads;
> > };
> >
> > +typedef enum CPUCacheType {
> > + CPU_CORE_DATA,
> > + CPU_CORE_INSTRUCTION,
> > + CPU_CORE_UNIFIED,
> > +} CPUCoreCacheType;
>
> This is a complete duplicate of the x86's CPUCaches
> (target/i386/cpu.h).
>
> I think we can move x86's CPUCaches to include/hw/core/cpu.h.
>
> > +typedef struct CPUPPTTCaches {
> > + CPUCoreCacheType type;
> > + uint32_t pptt_id;
> > + uint32_t sets;
> > + uint32_t size;
> > + uint32_t level;
> > + uint16_t linesize;
> > + uint8_t attributes; /* write policy: 0x0 write back, 0x1 write
> > through */
> > + uint8_t associativity;
> > +} CPUCorePPTTCaches;
>
> x86 doesn't use PPTT to describe cache so it's not necessary to reuse
> CPUCacheInfo (target/i386/cpu.h) for PPTT.
>
> But I understand it's better to place this sturct in
> include/hw/acpi/cpu.h, since it is part of the ACPI PPTT table.
>
> > +int partial_cache_description(const MachineState *ms,
> > CPUCorePPTTCaches *caches,
> > + int num_caches);
>
> Could move to include/hw/acpi/cpu.h, too.
>
> > +bool cache_described_at(const MachineState *ms, CpuTopologyLevel
> > level); +
> > +bool find_the_lowest_level_cache_defined_at_level(const
> > MachineState *ms,
> > + int *level_found,
> > + CpuTopologyLevel
> > topo_level);
> > +
>
> Because these 2 functions' definitions would be moved to
> hw/core/machine-smp.c, then we need to move their declarations to
> include/hw/boards.h.
>
>
> Except the above nits, the general part is fine for me.
>
> Thanks,
> Zhao
>
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2025-06-11 11:42 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-04 13:34 [PATCH v12 0/6] Specifying cache topology on ARM Alireza Sanaee via
2025-06-04 13:34 ` [PATCH v12 1/6] target/arm/tcg: increase cache level for cpu=max Alireza Sanaee via
2025-06-04 13:34 ` [PATCH v12 2/6] arm/virt.c: add cache hierarchy to device tree Alireza Sanaee via
2025-06-05 9:44 ` Zhao Liu
2025-06-05 9:40 ` Alireza Sanaee via
2025-06-05 13:58 ` Zhao Liu
2025-06-11 11:38 ` Alireza Sanaee via
2025-06-04 13:34 ` [PATCH v12 3/6] bios-tables-test: prepare to change ARM ACPI virt PPTT Alireza Sanaee via
2025-06-05 8:29 ` Zhao Liu
2025-06-04 13:34 ` [PATCH v12 4/6] hw/acpi: add cache hierarchy to pptt table Alireza Sanaee via
2025-06-04 13:34 ` [PATCH v12 5/6] tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology Alireza Sanaee via
2025-06-05 9:46 ` Zhao Liu
2025-06-04 13:34 ` [PATCH v12 6/6] Update the ACPI tables based on new aml-build.c Alireza Sanaee via
2025-06-05 9:47 ` Zhao Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).