From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DA5DC5B543 for ; Thu, 5 Jun 2025 08:37:16 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uN65o-0005Aa-Es; Thu, 05 Jun 2025 04:36:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uN65n-0005AK-7S for qemu-devel@nongnu.org; Thu, 05 Jun 2025 04:36:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uN65l-000730-KI for qemu-devel@nongnu.org; Thu, 05 Jun 2025 04:36:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749112611; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=3x3FxLU30MF7ZMaK47pkskaPAWFt/ytFGXLThMUCswM=; b=D6l8cz0zgm4u9vl1ORU52QWEPalf0j5XPAyh5hgVNeBqeEVVyMrUPFt43ACzOqnP+wOFnf rdAePWXSsKsQA0CfUcSu1ixwFOpzLpbA1+IBVZe03/U92Ss4vItB2frkpaTVW1YeL/bY/c pQA+1Sh8PFElQ8A3rbG+M+5BQpTV5Q8= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-505-rYziKKgzNNSxmScuW51EqA-1; Thu, 05 Jun 2025 04:36:50 -0400 X-MC-Unique: rYziKKgzNNSxmScuW51EqA-1 X-Mimecast-MFC-AGG-ID: rYziKKgzNNSxmScuW51EqA_1749112609 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1C658195608B; Thu, 5 Jun 2025 08:36:48 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.159]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9A04D1956048; Thu, 5 Jun 2025 08:36:45 +0000 (UTC) Date: Thu, 5 Jun 2025 09:36:41 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: John Snow , qemu-devel@nongnu.org, Michael Roth , Cleber Rosa , Peter Maydell Subject: Re: [PATCH v5 4/6] python: add qapi static analysis tests Message-ID: References: <20250604200354.459501-1-jsnow@redhat.com> <20250604200354.459501-5-jsnow@redhat.com> <87frgen1dj.fsf@pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87frgen1dj.fsf@pond.sub.org> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.128, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Jun 05, 2025 at 08:33:44AM +0200, Markus Armbruster wrote: > John Snow writes: > > [...] > > > diff --git a/python/tests/qapi-flake8.sh b/python/tests/qapi-flake8.sh > > new file mode 100755 > > index 00000000000..2211b6c7f41 > > --- /dev/null > > +++ b/python/tests/qapi-flake8.sh > > @@ -0,0 +1,6 @@ > > +#!/bin/sh -e > > +# SPDX-License-Identifier: LGPL-2.1-or-later > > Why not GPL-2.0-or-later? Indeed, checkpatch.pl should be warning about this choice, and requesting that it be explained in the commit message. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|