Re: [PATCH v1] ramfb: Add property to control if load the romfile

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Jun 05, 2025 at 04:24:07PM +0200, Cédric Le Goater wrote:
> On 6/5/25 14:21, Gerd Hoffmann wrote:
> >    Hi,
> > 
> > > > Now the ramfb will load the vgabios-ramfb.bin unconditionally, but only
> > > > the x86 need the vgabios-ramfb.bin, this can cause that when use the
> > > > release package on arm64 it can't find the vgabios-ramfb.bin.
> > 
> > > Simpler to directly pass the ROM path instead of using a boolean,
> > > so board (or CLI) could pass path to non-x86 rom.
> > 
> > The rom is loaded into a fw_cfg file which only seabios will look at.
> > So this rom logic is x86-specific.
> > 
> > edk2 ships an EFI driver for ramfb, that is how ramfb is used on !x86
> > platforms today, and I don't expect that to change.
> 
> Should we also set the vfio-pci::ramfb-romfile property to false in
> a compat property for ARM machines then ? I don't know for RISC-V and
> PPC.

Sounds like we'd be better setting the property to false by default,
and then special case x86 machine types to set it to true.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|