From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4261FC5B552 for ; Mon, 9 Jun 2025 09:10:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uOYWT-00066p-Gt; Mon, 09 Jun 2025 05:10:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uOYWQ-000660-5J for qemu-devel@nongnu.org; Mon, 09 Jun 2025 05:10:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uOYWO-0008Vd-JE for qemu-devel@nongnu.org; Mon, 09 Jun 2025 05:10:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749460223; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Kn8ec7xGLUDt4PSLBqUMuRPROR1nOuR1fmR99U4wpjE=; b=Wzubf3ZgJPXfj2E/D7OsTOETAbKRBoN9YfNMGSSxN0u/I3c/WCpJFKA02isThVXItJDdPi UXs1kRxTWbYJxMO0nR6gJhcL+F8qy9gIUcxqhTUSrZa0NORJDL1A4C2Qig05BcbSTiAW2u mlW52fy7jPXbdpaKpCilzDKTp82vJiE= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-630-JXjU0RC3PcqjVnaZyI5tPg-1; Mon, 09 Jun 2025 05:10:18 -0400 X-MC-Unique: JXjU0RC3PcqjVnaZyI5tPg-1 X-Mimecast-MFC-AGG-ID: JXjU0RC3PcqjVnaZyI5tPg_1749460217 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0C5E81956057; Mon, 9 Jun 2025 09:10:17 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.45]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 82A771806D3E; Mon, 9 Jun 2025 09:10:13 +0000 (UTC) Date: Mon, 9 Jun 2025 10:10:10 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Peter Maydell Cc: Shaoqin Huang , qemu-arm@nongnu.org, Gerd Hoffmann , Eric Auger , qemu-devel@nongnu.org Subject: Re: [PATCH v3 2/2] hw/arm: Add the romfile compatatibility Message-ID: References: <20250609073408.2083831-1-shahuang@redhat.com> <20250609073408.2083831-3-shahuang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Jun 09, 2025 at 09:48:36AM +0100, Peter Maydell wrote: > On Mon, 9 Jun 2025 at 08:34, Shaoqin Huang wrote: > > > > On arm64, it doesn't use the vgabios-ramfb.bin, so set the property > > "use-legacy-x86-rom" to false, thus the ramfb won't load the > > vgabios-ramfb.bin. > > > > This can mitigate the problem that on release version the qemu can't > > find the vgabios-ramfb.bin if it use the ramfb. > > > > Signed-off-by: Shaoqin Huang > > --- > > hw/arm/virt.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > > index a96452f17a..5f94f7a2ca 100644 > > --- a/hw/arm/virt.c > > +++ b/hw/arm/virt.c > > @@ -38,6 +38,7 @@ > > #include "hw/arm/primecell.h" > > #include "hw/arm/virt.h" > > #include "hw/block/flash.h" > > +#include "hw/vfio/pci.h" > > #include "hw/vfio/vfio-calxeda-xgmac.h" > > #include "hw/vfio/vfio-amd-xgbe.h" > > #include "hw/display/ramfb.h" > > @@ -90,6 +91,8 @@ > > > > static GlobalProperty arm_virt_compat[] = { > > { TYPE_VIRTIO_IOMMU_PCI, "aw-bits", "48" }, > > + { TYPE_RAMFB_DEVICE, "use-legacy-x86-rom", "false" }, > > + { TYPE_VFIO_PCI, "use-legacy-x86-rom", "false" }, > > I think we should find a way to make this default to "false" > and only be set "true" for x86. Otherwise every single non-x86 > board that ever adds support for ramfb and virtio will have > to add these two lines, which is a source of future bugs. > (Whereas if you forget to mark a new x86 board as needing > the legacy rom you'll find out about it pretty quickly.) Yes, going forward we this to default to true only on x86. For non-x86, historical versioned machine types will need likely it set to true, in order to avoid the memory layout being changed IIUC. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|