From: Peter Xu <peterx@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Jaehoon Kim <jhkim@linux.ibm.com>,
qemu-devel@nongnu.org, jjherne@linux.ibm.com,
steven.sistare@oracle.com, farosas@suse.de, lvivier@redhat.com,
pbonzini@redhat.com
Subject: Re: [PATCH v4 2/2] migration: Support fd-based socket address in cpr_transfer_input
Date: Thu, 12 Jun 2025 10:37:56 -0400 [thread overview]
Message-ID: <aErmRDco1cXWZGyB@x1.local> (raw)
In-Reply-To: <aErY-yZy9qbVpdcU@redhat.com>
On Thu, Jun 12, 2025 at 02:41:15PM +0100, Daniel P. Berrangé wrote:
> On Wed, Jun 11, 2025 at 03:56:10PM -0500, Jaehoon Kim wrote:
> > Extend cpr_transfer_input to handle SOCKET_ADDRESS_TYPE_FD alongside
> > SOCKET_ADDRESS_TYPE_UNIX. This change supports the use of pre-listened
> > socket file descriptors for cpr migration channels.
> >
> > This change is particularly useful in qtest environments, where the
> > socket may be created externally and passed via fd.
> >
> > Reviewed-by: Jason J. Herne <jjherne@linux.ibm.com>
> > Reviewed-by: Steve Sistare <steven.sistare@oracle.com>
> > Signed-off-by: Jaehoon Kim <jhkim@linux.ibm.com>
> > ---
> > migration/cpr-transfer.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
>
> This patch *MUST* be first in the series, otherwise 'git bisect'
> will hit test failures on the former patch.
Yes. I fixed both issues and queued the series, thanks all. For the other
patch I did null-initialize for the var.
https://gitlab.com/peterx/qemu/-/commits/migration-staging
--
Peter Xu
prev parent reply other threads:[~2025-06-12 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 20:56 [PATCH v4 0/2] migration: Support socket fd for CPR and fix Jaehoon Kim
2025-06-11 20:56 ` [PATCH v4 1/2] tests/migration: Setup pre-listened cpr.sock to remove race-condition Jaehoon Kim
2025-06-12 13:33 ` Steven Sistare
2025-06-11 20:56 ` [PATCH v4 2/2] migration: Support fd-based socket address in cpr_transfer_input Jaehoon Kim
2025-06-12 13:41 ` Daniel P. Berrangé
2025-06-12 14:37 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aErmRDco1cXWZGyB@x1.local \
--to=peterx@redhat.com \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=jhkim@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=steven.sistare@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).