From: Zhao Liu <zhao1.liu@intel.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] i386/tdx: Remove task->watch only when it's valid
Date: Fri, 27 Jun 2025 16:42:01 +0800 [thread overview]
Message-ID: <aF5ZWUZvls6l2RDI@intel.com> (raw)
In-Reply-To: <20250625035505.2770580-1-xiaoyao.li@intel.com>
On Wed, Jun 25, 2025 at 11:55:05AM +0800, Xiaoyao Li wrote:
> Date: Wed, 25 Jun 2025 11:55:05 +0800
> From: Xiaoyao Li <xiaoyao.li@intel.com>
> Subject: [PATCH] i386/tdx: Remove task->watch only when it's valid
> X-Mailer: git-send-email 2.43.0
>
> In some case (e.g., failed to connect to QGS socket),
> tdx_generate_quote_cleanup() is called with task->watch invalid. It
> triggers assertion of
>
> qemu-system-x86_64: GLib: g_source_remove: assertion 'tag > 0' failed
>
> Fix it by checking task->watch.
>
> Fixes: 40da501d8989 ("i386/tdx: handle TDG.VP.VMCALL<GetQuote>")
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
> target/i386/kvm/tdx-quote-generator.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
next prev parent reply other threads:[~2025-06-27 8:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 3:55 [PATCH] i386/tdx: Remove task->watch only when it's valid Xiaoyao Li
2025-06-27 8:42 ` Zhao Liu [this message]
2025-07-11 8:45 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF5ZWUZvls6l2RDI@intel.com \
--to=zhao1.liu@intel.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).