Re: [PATCH v4 00/19] vfio-user client

[John Levon <john.levon@nutanix.com>]

On Fri, Jun 20, 2025 at 11:11:10AM +0200, Cédric Le Goater wrote:

> > The series contains an implement of a vfio-user client in QEMU, along with a few
> > more preparatory patches.
> 
> Please run ./scripts/checkpatch.pl and resend later on, as we might get
> reviews.

Output is below, MAINTAINERS looks correct to me, and the other complaints are
for files that are the same as in hw/vfio/

So please let me know what if anything needs to be fixed (and if I should make
the same retrospective fix to hw/vfio/ equivalent).

regards
john


1/19 Checking commit cfffef23476c (vfio-user: add vfio-user class and container)
WARNING: Does new file 'hw/vfio-user/Kconfig' need 'SPDX-License-Identifier'?
WARNING: Does new file 'hw/vfio-user/meson.build' need 'SPDX-License-Identifier'?
total: 0 errors, 2 warnings, 461 lines checked

Patch 1/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/19 Checking commit 132ba4d3a176 (vfio-user: connect vfio proxy to remote server)
WARNING: added, moved or deleted file(s):

  hw/vfio-user/proxy.h
  hw/vfio-user/proxy.c

Does MAINTAINERS need updating?

total: 0 errors, 1 warnings, 316 lines checked

Patch 2/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/19 Checking commit 459bf245dbde (vfio-user: implement message receive infrastructure)
ERROR: New file 'hw/vfio-user/trace.h' requires 'SPDX-License-Identifier'
WARNING: Does new file 'hw/vfio-user/trace-events' need 'SPDX-License-Identifier'?
WARNING: added, moved or deleted file(s):

  hw/vfio-user/protocol.h
  hw/vfio-user/trace.h
  hw/vfio-user/trace-events

Does MAINTAINERS need updating?

total: 1 errors, 2 warnings, 584 lines checked

Patch 3/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/19 Checking commit 8bc73aa81e1a (vfio-user: implement message send infrastructure)
total: 0 errors, 0 warnings, 698 lines checked

Patch 4/19 has no obvious style problems and is ready for submission.
5/19 Checking commit 0197d0323b7d (vfio-user: implement VFIO_USER_DEVICE_GET_INFO)
WARNING: added, moved or deleted file(s):

  hw/vfio-user/device.h
  hw/vfio-user/device.c

Does MAINTAINERS need updating?

total: 0 errors, 1 warnings, 165 lines checked

Patch 5/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/19 Checking commit 0d4bf7c4847d (vfio-user: implement VFIO_USER_DEVICE_GET_REGION_INFO)
total: 0 errors, 0 warnings, 134 lines checked

Patch 6/19 has no obvious style problems and is ready for submission.
7/19 Checking commit ab4156d34c6a (vfio-user: implement VFIO_USER_REGION_READ/WRITE)
total: 0 errors, 0 warnings, 96 lines checked

Patch 7/19 has no obvious style problems and is ready for submission.
8/19 Checking commit 880367f1b72c (vfio-user: set up PCI in vfio_user_pci_realize())
total: 0 errors, 0 warnings, 39 lines checked

Patch 8/19 has no obvious style problems and is ready for submission.
9/19 Checking commit 98aeea76f227 (vfio-user: implement VFIO_USER_DEVICE_GET/SET_IRQ*)
total: 0 errors, 0 warnings, 169 lines checked

Patch 9/19 has no obvious style problems and is ready for submission.
10/19 Checking commit 98dcb17f4a2f (vfio-user: forward MSI-X PBA BAR accesses to server)
total: 0 errors, 0 warnings, 89 lines checked

Patch 10/19 has no obvious style problems and is ready for submission.
11/19 Checking commit 90f17d9f77bc (vfio-user: set up container access to the proxy)
total: 0 errors, 0 warnings, 115 lines checked

Patch 11/19 has no obvious style problems and is ready for submission.
12/19 Checking commit 1cc6c7a2318a (vfio-user: implement VFIO_USER_DEVICE_RESET)
total: 0 errors, 0 warnings, 53 lines checked

Patch 12/19 has no obvious style problems and is ready for submission.
13/19 Checking commit 44a2750529ec (vfio-user: implement VFIO_USER_DMA_MAP/UNMAP)
total: 0 errors, 0 warnings, 306 lines checked

Patch 13/19 has no obvious style problems and is ready for submission.
14/19 Checking commit bd778e2c6e65 (vfio-user: implement VFIO_USER_DMA_READ/WRITE)
total: 0 errors, 0 warnings, 265 lines checked

Patch 14/19 has no obvious style problems and is ready for submission.
15/19 Checking commit 55b7d98a7919 (vfio-user: add 'x-msg-timeout' option)
total: 0 errors, 0 warnings, 55 lines checked

Patch 15/19 has no obvious style problems and is ready for submission.
16/19 Checking commit 39ed25427ff9 (vfio-user: support posted writes)
total: 0 errors, 0 warnings, 142 lines checked

Patch 16/19 has no obvious style problems and is ready for submission.
17/19 Checking commit 7d146a1fc463 (vfio-user: add coalesced posted writes)
total: 0 errors, 0 warnings, 276 lines checked

Patch 17/19 has no obvious style problems and is ready for submission.
18/19 Checking commit 1df337f26b29 (docs: add vfio-user documentation)
WARNING: Does new file 'docs/system/devices/vfio-user.rst' need 'SPDX-License-Identifier'?
WARNING: added, moved or deleted file(s):

  docs/system/devices/vfio-user.rst

Does MAINTAINERS need updating?

total: 0 errors, 2 warnings, 31 lines checked

Patch 18/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/19 Checking commit 472c86cd1066 (vfio-user: introduce vfio-user protocol specification)
WARNING: Does new file 'docs/interop/vfio-user.rst' need 'SPDX-License-Identifier'?
total: 0 errors, 1 warnings, 1540 lines checked

Patch 19/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.