From: Zhao Liu <zhao1.liu@intel.com>
To: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, qemu-rust@nongnu.org, shentey@gmail.com
Subject: Re: [PATCH] rust: log: implement io::Write
Date: Tue, 24 Jun 2025 17:05:37 +0800 [thread overview]
Message-ID: <aFpqYTBLaf8GEd0v@intel.com> (raw)
In-Reply-To: <CAAjaMXZvi7FxdOgC8xpw5O1sQD3ncZSpRQpNEetNDMR3MdfhvA@mail.gmail.com>
> > @@ -136,8 +137,7 @@ macro_rules! log_mask_ln {
> > if unsafe {
> > (::qemu_api::bindings::qemu_loglevel & ($mask as std::os::raw::c_int)) != 0
> > } {
> > - #[allow(unused_must_use)]
> > - ::qemu_api::log::LogGuard::log_fmt(
> > + let _ = ::qemu_api::log::LogGuard::log_fmt(
> > format_args!("{}\n", format_args!($fmt $($args)*)));
> > }
> > }};
>
>
> Just `_ = ::qemu_api::log::LogGuard::log_fmt(...);` is sufficient, no
> `let` needed.
Good catch! Thank you Manos.
Regards,
Zhao
prev parent reply other threads:[~2025-06-24 8:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 8:12 [PATCH] rust: log: implement io::Write Paolo Bonzini
2025-06-24 6:25 ` Zhao Liu
2025-06-24 7:21 ` Zhao Liu
2025-06-24 8:22 ` Manos Pitsidianakis
2025-06-24 9:05 ` Zhao Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFpqYTBLaf8GEd0v@intel.com \
--to=zhao1.liu@intel.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).