From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, Zhenzhong Duan <zhenzhong.duan@intel.com>
Subject: Re: [PATCH] i386/tdx: Use .has_gpa field to check if the gpa is valid
Date: Thu, 10 Jul 2025 15:25:13 +0100 [thread overview]
Message-ID: <aG_NSfr0cS9vYA8d@redhat.com> (raw)
In-Reply-To: <20250710141512.170302-1-xiaoyao.li@intel.com>
On Thu, Jul 10, 2025 at 10:15:12PM +0800, Xiaoyao Li wrote:
> There is actually the .has_gpa field when translating the QAPI data
> type GuestPanicInformationTdx to C structure.
>
> Stop using the magic number -1 as the indicator for no valid gpa.
> Instead just use .has_gpa field.
>
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
> system/runstate.c | 2 +-
> target/i386/kvm/tdx.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-07-10 14:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 14:15 [PATCH] i386/tdx: Use .has_gpa field to check if the gpa is valid Xiaoyao Li
2025-07-10 14:25 ` Daniel P. Berrangé [this message]
2025-07-11 3:22 ` Duan, Zhenzhong
2025-09-12 5:53 ` Xiaoyao Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aG_NSfr0cS9vYA8d@redhat.com \
--to=berrange@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiaoyao.li@intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).