Re: [PATCH v2 3/4] hw/vfio-user: wait for proxy close correctly

[John Levon <john.levon@nutanix.com>]

On Tue, Jul 15, 2025 at 10:01:59AM +0100, Mark Cave-Ayland wrote:

> On 15/07/2025 06:52, John Levon wrote:
> 
> > Coverity reported:
> > 
> > CID 1611806: Concurrent data access violations (BAD_CHECK_OF_WAIT_COND)
> > 
> > A wait is performed without a loop. If there is a spurious wakeup, the
> > condition may not be satisfied.
> > 
> > Fix this by checking ->state for VFIO_PROXY_CLOSED in a loop.
> > 
> > Resolves: Coverity CID 1611806
> > Fixes: 0b3d881a ("vfio-user: implement message receive infrastructure")
> > Signed-off-by: John Levon <john.levon@nutanix.com>
> 
> Is this definitely the right patch? The v2 posted at
> https://patchew.org/QEMU/20250711124500.1611628-1-john.levon@nutanix.com/
> contains the updated commit message mentioning the rename of the callback,
> whereas this one doesn't?

Yep, sorry, picked the wrong commit message (but same commit contents).

Should I resend?

regards
john