From: Zhao Liu <zhao1.liu@intel.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Ewan Hai" <ewanhai-oc@zhaoxin.com>,
"Xiaoyao Li" <xiaoyao.li@intel.com>, "Tao Su" <tao1.su@intel.com>,
"Yi Lai" <yi1.lai@intel.com>, "Dapeng Mi" <dapeng1.mi@intel.com>,
qemu-devel@nongnu.org, "Chuang Xu" <xuchuangxclwt@bytedance.com>,
"Guixiong Wei" <weiguixiong@bytedance.com>,
"Yipeng Yin" <yinyipeng@bytedance.com>,
qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [PATCH v2 4/7] i386/cpu: Fix number of addressable IDs field for CPUID.01H.EBX[23:16]
Date: Thu, 17 Jul 2025 11:06:24 +0800 [thread overview]
Message-ID: <aHhosJ/VWEyjwQDc@intel.com> (raw)
In-Reply-To: <33497cb5-037b-4656-bd8d-6310c7c03e65@tls.msk.ru>
> Hi!
>
> Previous incarnation of this patch were Cc'd qemu-stable@, as it were
> supposed to be picked up for the stable qemu series. However, this
> incarnation is not Cc'd to stable, and, most importantly, it relies
> on a feature which was introduced after all released qemu versions.
> Namely, vendor_cpuid_only_v2 is past v10.0.0, which is commit
> 216d9bb6d7716 "i386/cpu: Add x-vendor-cpuid-only-v2 option for
> compatibility".
>
> Should I omit this change for stable-10.0 series, or should it be
> modified to work in 10.0?
Hi Michael, considerring current fix is covered by compat option,
it's not fit to be backported to the previous version.
This issue has existed for a very long time, and the feedback received
on this is currently one case and it based on a specific topology
configuration, so the impact is limited. Therefore, in this patch
version, I fixed it with the newly added compat option, which also
avoids the controversy about the impact of migration.
So I think you could omit this change for stable-10.0 series, if it's
also okay with Paolo.
Thanks,
Zhao
next prev parent reply other threads:[~2025-07-17 2:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 8:08 [PATCH v2 0/7] i386/cpu: Clean Up Reserved CPUID Leaves & Topology Overflow Fix Zhao Liu
2025-07-14 8:08 ` [PATCH v2 1/7] i386/cpu: Mark EBX/ECX/EDX in CPUID 0x80000000 leaf as reserved for Intel Zhao Liu
2025-07-14 8:15 ` Xiaoyao Li
2025-07-14 8:08 ` [PATCH v2 2/7] i386/cpu: Mark CPUID 0x80000008 ECX bits[0:7] & [12:15] as reserved for Intel/Zhaoxin Zhao Liu
2025-07-14 8:27 ` Xiaoyao Li
2025-07-14 9:23 ` Zhao Liu
2025-07-14 8:08 ` [PATCH v2 3/7] i386/cpu: Reorder CPUID leaves in cpu_x86_cpuid() Zhao Liu
2025-07-14 8:08 ` [PATCH v2 4/7] i386/cpu: Fix number of addressable IDs field for CPUID.01H.EBX[23:16] Zhao Liu
2025-07-14 8:29 ` Xiaoyao Li
2025-07-16 15:31 ` Michael Tokarev
2025-07-17 3:06 ` Zhao Liu [this message]
2025-07-17 3:25 ` Michael Tokarev
2025-07-17 4:09 ` Zhao Liu
2025-07-14 8:08 ` [PATCH v2 5/7] i386/cpu: Fix cpu number overflow in CPUID.01H.EBX[23:16] Zhao Liu
2025-07-14 8:08 ` [PATCH v2 6/7] i386/cpu: Fix overflow of cache topology fields in CPUID.04H Zhao Liu
2025-07-14 8:08 ` [PATCH v2 7/7] i386/cpu: Honor maximum value for CPUID.8000001DH.EAX[25:14] Zhao Liu
2025-07-14 14:51 ` Moger, Babu
2025-07-14 15:41 ` Zhao Liu
2025-07-14 15:25 ` Moger, Babu
2025-07-14 8:25 ` [PATCH v2 0/7] i386/cpu: Clean Up Reserved CPUID Leaves & Topology Overflow Fix Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHhosJ/VWEyjwQDc@intel.com \
--to=zhao1.liu@intel.com \
--cc=berrange@redhat.com \
--cc=dapeng1.mi@intel.com \
--cc=ewanhai-oc@zhaoxin.com \
--cc=imammedo@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=tao1.su@intel.com \
--cc=weiguixiong@bytedance.com \
--cc=xiaoyao.li@intel.com \
--cc=xuchuangxclwt@bytedance.com \
--cc=yi1.lai@intel.com \
--cc=yinyipeng@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).