From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E0E9C87FCE for ; Mon, 28 Jul 2025 09:08:01 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ugJpq-0002TN-0C; Mon, 28 Jul 2025 05:07:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ugJoE-0000cQ-Pi for qemu-devel@nongnu.org; Mon, 28 Jul 2025 05:06:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ugJoB-0007rg-LV for qemu-devel@nongnu.org; Mon, 28 Jul 2025 05:06:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1753693569; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ai+PAqO4uWpUhTflZsLGLQ0TVuuRdRRzVD4O6WQP/5k=; b=P/JVgUa2/HP5pSxfy2lz40UYXnSMO8joFeobHMmZfEBkWptos4ecd+4GciMxv7n4wapJud 1GeMAHTRfxicklkUWz7Hy3gl8Tq52Gqjys8yAyIEJCJCmsnEo047fj2DdmRjTHI0U3INOd 4u5CCwkIo30RnYpRdZhD5bpIidpmHZE= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-400-_-Cl0rOJNOuB3p1xv27Nyw-1; Mon, 28 Jul 2025 05:06:06 -0400 X-MC-Unique: _-Cl0rOJNOuB3p1xv27Nyw-1 X-Mimecast-MFC-AGG-ID: _-Cl0rOJNOuB3p1xv27Nyw_1753693563 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E14391800165; Mon, 28 Jul 2025 09:06:02 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.32]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EE12E1800D8C; Mon, 28 Jul 2025 09:05:51 +0000 (UTC) Date: Mon, 28 Jul 2025 10:05:48 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: Arun Menon , qemu-devel@nongnu.org, "Michael S. Tsirkin" , Marcel Apfelbaum , Cornelia Huck , Halil Pasic , Eric Farman , Richard Henderson , David Hildenbrand , Ilya Leoshkevich , Thomas Huth , Christian Borntraeger , Paolo Bonzini , Fam Zheng , Nicholas Piggin , Daniel Henrique Barboza , Harsh Prateek Bora , Alex Williamson , =?utf-8?Q?C=C3=A9dric?= Le Goater , Peter Xu , Fabiano Rosas , Hailiang Zhang , Steve Sistare , qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, Stefan Berger , Alex =?utf-8?Q?Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Matthew Rosato Subject: Re: [PATCH v7 09/24] migration: push Error **errp into loadvm_process_command() Message-ID: References: <20250725-propagate_tpm_error-v7-0-d52704443975@redhat.com> <20250725-propagate_tpm_error-v7-9-d52704443975@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Jul 28, 2025 at 12:53:07PM +0400, Marc-André Lureau wrote: > Hi > > On Fri, Jul 25, 2025 at 4:20 PM Arun Menon wrote: > > > This is an incremental step in converting vmstate loading > > code to report error via Error objects instead of directly > > printing it to console/monitor. > > It is ensured that loadvm_process_command() must report an error > > in errp, in case of failure. > > > > Signed-off-by: Arun Menon > > --- > > migration/savevm.c | 73 > > +++++++++++++++++++++++++++++++++++++++--------------- > > 1 file changed, 53 insertions(+), 20 deletions(-) > > > > diff --git a/migration/savevm.c b/migration/savevm.c > > index > > ad96da3651b89023e4b70ffeecab46d176bae6f5..d40b25d74be46b209be8f28d10b7538a5ff2e3dd > > 100644 > > --- a/migration/savevm.c > > +++ b/migration/savevm.c > > @@ -2544,12 +2544,13 @@ static int > > loadvm_postcopy_handle_switchover_start(void) > > * LOADVM_QUIT All good, but exit the loop > > * <0 Error > > */ > > -static int loadvm_process_command(QEMUFile *f) > > +static int loadvm_process_command(QEMUFile *f, Error **errp) > > { > > > > better with ERRP_GUARD Nothing in this patch derefences errp, so ERRP_GUARD is redundant. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|