qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhao Liu <zhao1.liu@intel.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Kirill Martynov" <stdcalllevi@yandex-team.ru>,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] target/i386: Define enum X86ASIdx for x86's address spaces
Date: Wed, 30 Jul 2025 16:23:31 +0800	[thread overview]
Message-ID: <aInWgzo0yJH1QRbS@intel.com> (raw)
In-Reply-To: <20250729054023.1668443-3-xiaoyao.li@intel.com>

On Tue, Jul 29, 2025 at 01:40:23PM +0800, Xiaoyao Li wrote:
> Date: Tue, 29 Jul 2025 13:40:23 +0800
> From: Xiaoyao Li <xiaoyao.li@intel.com>
> Subject: [PATCH 2/2] target/i386: Define enum X86ASIdx for x86's address
>  spaces
> X-Mailer: git-send-email 2.43.0
> 
> Like ARM defines ARMASIdx, do the same to define X86ASIdx as enum. So
> that it's more clear what index 0 is for memory and index 1 is for SMM.

Maybe:

Define X86ASIdx as the enum, like ARM's ARMASIdx, so that index 0 is
clearly for memory and index 1 for SMM.

> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
>  accel/kvm/kvm-all.c              | 2 +-
>  target/i386/cpu.h                | 5 +++++
>  target/i386/kvm/kvm-cpu.c        | 2 +-
>  target/i386/kvm/kvm.c            | 4 ++--
>  target/i386/tcg/system/tcg-cpu.c | 4 ++--
>  5 files changed, 11 insertions(+), 6 deletions(-)

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>



      parent reply	other threads:[~2025-07-30  8:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-29  5:40 [PATCH 0/2] i386/kvm: Enable SMM addrss space for i386 cpu Xiaoyao Li
2025-07-29  5:40 ` [PATCH 1/2] i386/cpu: Enable SMM cpu addressspace Xiaoyao Li
2025-07-29  7:08   ` Philippe Mathieu-Daudé
2025-07-30  8:11   ` Zhao Liu
2025-07-30  7:55     ` Kirill Martynov
2025-07-30 10:12     ` Xiaoyao Li
2025-07-30 15:20       ` Zhao Liu
2025-07-30 16:11         ` Xiaoyao Li
2025-07-31  3:53           ` Zhao Liu
2025-08-18  9:37             ` Kirill Martynov
2025-07-29  5:40 ` [PATCH 2/2] target/i386: Define enum X86ASIdx for x86's address spaces Xiaoyao Li
2025-07-29  7:11   ` Philippe Mathieu-Daudé
2025-07-29 12:16     ` Kirill Martynov
2025-07-30  8:23   ` Zhao Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aInWgzo0yJH1QRbS@intel.com \
    --to=zhao1.liu@intel.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=stdcalllevi@yandex-team.ru \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).