From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18649C87FCB for ; Mon, 4 Aug 2025 11:18:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uitCc-0005cD-4L; Mon, 04 Aug 2025 07:18:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uisxE-0007Wq-4F for qemu-devel@nongnu.org; Mon, 04 Aug 2025 07:02:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uisxC-0008TD-2t for qemu-devel@nongnu.org; Mon, 04 Aug 2025 07:02:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754305325; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Ns9E6VWM1rFhp1mW7TRpd0Wuk3KuLwCvfnTdGm2t3lA=; b=LqIC8H3TmyPi0zJbNP3uD5oqYGSZbcoe/8lAFU4d34tMqi7LWPyO0NRxgV+2DP/uBHM/Qr ijAnBVAVJptddtNr8vYd0KwKqjgHOfcgPT+febrYgcjXRGVuuZj7qtS/At0PiFwDIh5K0+ JlQXopU1AfNWb+gwAiv3b3Ms1aJSu/A= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-310-G1WIJxVTO5yC7PxaHRG_RQ-1; Mon, 04 Aug 2025 07:02:04 -0400 X-MC-Unique: G1WIJxVTO5yC7PxaHRG_RQ-1 X-Mimecast-MFC-AGG-ID: G1WIJxVTO5yC7PxaHRG_RQ_1754305323 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 23C27195D027 for ; Mon, 4 Aug 2025 11:02:03 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.62]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EBFF418003FC; Mon, 4 Aug 2025 11:02:00 +0000 (UTC) Date: Mon, 4 Aug 2025 12:01:57 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Kostiantyn Kostiuk Cc: Michal Privoznik , Jan Tomko , Yan Vugenfirer , QEMU Subject: Re: QGA installation issue on Windows Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Aug 04, 2025 at 01:54:09PM +0300, Kostiantyn Kostiuk wrote: > Hi Michal, > > I want to discuss your patch > https://gitlab.com/qemu-project/qemu/-/commit/c6f5dd7ac8ef62dcdec4cdeda1467c658161afff > > Unfortunately, we found bad behaviour on Windows. On Windows, we run QGA > with `-d --retry-path` options by default, so we expect that QGA will start > even without the vioserial driver and will wait for communication > forever. > > This worked previously, but after your patch QGA service fails if the > vioserial communication channel is missing. This behavior is totally > unacceptable for us. > > You send this patch to fix a Linux problem, but it causes a Windows problem. > So, what we need on Windows, if --retry-path specified, we should ignore > any channel error and retry the connection. If -d and --retry-path are > specified, it should become a daemon first to make Windows Service Manager > happy. This looks pretty simple to fix - in the initialize_agent() method, if channel_init() fails, then simply ignore the failure if 'retry_path' is set, because the later code in run_agent() will already correctly retry the connection. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|