From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>,
Andrew Melnychenko <andrew@daynix.com>,
Yuri Benditovich <yuri.benditovich@daynix.com>
Subject: Re: ebpf functions can fail without setting an error
Date: Tue, 19 Aug 2025 11:48:07 +0100 [thread overview]
Message-ID: <aKRWZwvbWzA0QbA_@redhat.com> (raw)
In-Reply-To: <87ectns27j.fsf@pond.sub.org>
On Thu, Aug 07, 2025 at 03:14:56PM +0200, Markus Armbruster wrote:
> Three functions in ebpf_rss.h take an Error ** argument and return bool.
> Good.
>
> They can all fail without setting an error. Not good.
>
> The failures without error are:
>
> * All three stubs in ebpf_rss-stub.c always. Oversight?
Opps, yes, we really should have added error_setg() calls for diagnosis
if someone tries to use eBPF when QEMU build has it disabled.
> * Non-stub ebpf_rss_load() when ebpf_rss_is_loaded(). Are these
> reachable?
This scenario should never happen, and we should add a call like
error_setg(errp, "eBPF program is already loaded");
to report it correctly.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-08-19 10:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 13:14 ebpf functions can fail without setting an error Markus Armbruster
2025-08-19 10:48 ` Daniel P. Berrangé [this message]
2025-08-25 12:19 ` Markus Armbruster
2025-08-25 13:27 ` Philippe Mathieu-Daudé
2025-08-27 8:13 ` Markus Armbruster
2025-09-17 8:24 ` Akihiko Odaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKRWZwvbWzA0QbA_@redhat.com \
--to=berrange@redhat.com \
--cc=andrew@daynix.com \
--cc=armbru@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).