From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5200FCA0EED for ; Tue, 19 Aug 2025 10:49:14 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uoJt9-0000FI-EP; Tue, 19 Aug 2025 06:48:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uoJt6-0000Ea-2O for qemu-devel@nongnu.org; Tue, 19 Aug 2025 06:48:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uoJt3-0001Wj-VA for qemu-devel@nongnu.org; Tue, 19 Aug 2025 06:48:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755600495; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Q0KK0FDkijxB92IB5gw0fSm8CIValPIvyMolmou68o8=; b=inCmC+zanHK+iMfOE63XtH9Ih6LufPb5sJrXaM5P3r7Egj+ftzdnUVRYQ00UT53X3/RfKT QrgTKY/sAl3jnZRF8VrQnt7cva0qpd/rtktY90DJ2fMPGgq0nc8rDYnzMP3xyChYl4SgoM eTL7/uRlwyayDeSiiFWbWAZGkC0eYSc= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-spb-pCYiNrivrgFOmDMCAA-1; Tue, 19 Aug 2025 06:48:14 -0400 X-MC-Unique: spb-pCYiNrivrgFOmDMCAA-1 X-Mimecast-MFC-AGG-ID: spb-pCYiNrivrgFOmDMCAA_1755600493 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2AF9F18003FD; Tue, 19 Aug 2025 10:48:13 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.237]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6089A19A4CA1; Tue, 19 Aug 2025 10:48:11 +0000 (UTC) Date: Tue, 19 Aug 2025 11:48:07 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: qemu-devel@nongnu.org, Jason Wang , Andrew Melnychenko , Yuri Benditovich Subject: Re: ebpf functions can fail without setting an error Message-ID: References: <87ectns27j.fsf@pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87ectns27j.fsf@pond.sub.org> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Aug 07, 2025 at 03:14:56PM +0200, Markus Armbruster wrote: > Three functions in ebpf_rss.h take an Error ** argument and return bool. > Good. > > They can all fail without setting an error. Not good. > > The failures without error are: > > * All three stubs in ebpf_rss-stub.c always. Oversight? Opps, yes, we really should have added error_setg() calls for diagnosis if someone tries to use eBPF when QEMU build has it disabled. > * Non-stub ebpf_rss_load() when ebpf_rss_is_loaded(). Are these > reachable? This scenario should never happen, and we should add a call like error_setg(errp, "eBPF program is already loaded"); to report it correctly. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|