From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Gustavo Romero <gustavo.romero@linaro.org>
Cc: qemu-devel@nongnu.org, alex.bennee@linaro.org, thuth@redhat.com,
qemu-arm@nongnu.org, 1844144@gmail.com
Subject: Re: [PATCH 3/4] tests/functional: Mark main in QemuBaseTest class as a static method
Date: Tue, 19 Aug 2025 15:54:29 +0100 [thread overview]
Message-ID: <aKSQJa7lGaTeNG9C@redhat.com> (raw)
In-Reply-To: <20250819143916.4138035-4-gustavo.romero@linaro.org>
On Tue, Aug 19, 2025 at 02:39:15PM +0000, Gustavo Romero wrote:
> The main() method in the QemuBaseTest class has no parameters but is
> defined as a regular method. Currently, this does not cause any issues
> because in the functional tests main() is always called directly from
> QemuBaseTest (never from instances), but the way this method is defined
> makes its signature wrong, implying a 'self'. Hence, it's best practice
> to define such a method as a static method, so decorate it with
> @staticmethod.
>
> Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
> ---
> tests/functional/qemu_test/testcase.py | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-08-19 14:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 14:39 [PATCH 0/4] tests/functional: Adapt reverse_debugging to run w/o Avocado Gustavo Romero
2025-08-19 14:39 ` [PATCH 1/4] tests/guest-debug: Make QEMU optional in run-test.py Gustavo Romero
2025-08-25 17:01 ` Alex Bennée
2025-08-25 17:26 ` Gustavo Romero
2025-08-25 17:30 ` Gustavo Romero
2025-08-25 21:24 ` Alex Bennée
2025-08-19 14:39 ` [PATCH 2/4] tests/functional: Support tests that require a runner Gustavo Romero
2025-08-25 16:50 ` Alex Bennée
2025-08-26 15:20 ` Gustavo Romero
2025-08-19 14:39 ` [PATCH 3/4] tests/functional: Mark main in QemuBaseTest class as a static method Gustavo Romero
2025-08-19 14:54 ` Daniel P. Berrangé [this message]
2025-08-19 14:39 ` [PATCH 4/4] tests/functional: Adapt reverse_debugging to run w/o Avocado Gustavo Romero
2025-08-25 10:34 ` Thomas Huth
2025-08-25 14:05 ` Gustavo Romero
2025-08-27 1:23 ` Gustavo Romero
2025-08-25 10:29 ` [PATCH 0/4] " Thomas Huth
2025-08-25 11:00 ` Manos Pitsidianakis
2025-08-25 14:56 ` Gustavo Romero
2025-08-25 14:04 ` Gustavo Romero
2025-08-26 7:51 ` Thomas Huth
2025-08-26 8:26 ` Alex Bennée
2025-08-26 8:45 ` Manos Pitsidianakis
2025-08-26 14:10 ` Daniel P. Berrangé
2025-08-26 15:22 ` Daniel P. Berrangé
2025-08-26 15:31 ` Gustavo Romero
2025-08-26 8:06 ` Thomas Huth
2025-08-26 15:02 ` Gustavo Romero
2025-08-26 13:58 ` Daniel P. Berrangé
2025-08-27 12:04 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKSQJa7lGaTeNG9C@redhat.com \
--to=berrange@redhat.com \
--cc=1844144@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=gustavo.romero@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).