From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F927CA0EEB for ; Tue, 19 Aug 2025 20:30:19 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uoSyE-0002hu-Sw; Tue, 19 Aug 2025 16:30:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uoSxq-0002Rb-9K for qemu-devel@nongnu.org; Tue, 19 Aug 2025 16:29:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uoSxo-0006cv-DS for qemu-devel@nongnu.org; Tue, 19 Aug 2025 16:29:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755635387; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PtUjZaGETAdcn0kL+nTJyqu1DbHoW27/fXa9xQDQ7OA=; b=dafue79uXIOfrAuLzBdFCBDkx8ziN18Rrlq4Oev9XU/oZkXj2Vrk/JbHcrUyfpkjwtRmtN n55KRZW0YEGDeJ1MTtq0R4lE6ouq1njRSYg68MGaVOVUFsMiLZqq2IHyeBQuGL4WONCXBx tp6YVLPN8aKIp2iO0e4bTARzK1Ez2m4= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-619-fIGLAviZNAau1Go8grU8Sg-1; Tue, 19 Aug 2025 16:29:43 -0400 X-MC-Unique: fIGLAviZNAau1Go8grU8Sg-1 X-Mimecast-MFC-AGG-ID: fIGLAviZNAau1Go8grU8Sg_1755635382 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7A7B71800359; Tue, 19 Aug 2025 20:29:42 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.237]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 14FCD19560B2; Tue, 19 Aug 2025 20:29:38 +0000 (UTC) Date: Tue, 19 Aug 2025 21:29:35 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: John Snow Cc: qemu-devel@nongnu.org, Hanna Reitz , Jagannathan Raman , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Elena Ufimtseva , Thomas Huth , Cleber Rosa , qemu-block@nongnu.org, Kevin Wolf Subject: Re: [PATCH 11/14] python: ensure QEMUQtestProtocol closes its socket Message-ID: References: <20250715143023.1851000-1-berrange@redhat.com> <20250715143023.1851000-12-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Aug 19, 2025 at 04:12:12PM -0400, John Snow wrote: > On Tue, Jul 15, 2025 at 10:32 AM Daniel P. Berrangé wrote: > > > > While QEMUQtestMachine closes the socket that was passed to > > QEMUQtestProtocol, the python resource leak manager still > > believes that the copy QEMUQtestProtocol holds is open. We > > must explicitly call close to avoid this leak warnnig. > > Huh. I wonder if that's a false positive, or if it's actually true? I'm not sure to be honest, but the extra close doesn't seem to cause any ill effects. > > > > > Signed-off-by: Daniel P. Berrangé > > Well, either way... > > Reviewed-by: John Snow > > > --- > > python/qemu/machine/qtest.py | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/python/qemu/machine/qtest.py b/python/qemu/machine/qtest.py > > index 4f5ede85b2..781f674ffa 100644 > > --- a/python/qemu/machine/qtest.py > > +++ b/python/qemu/machine/qtest.py > > @@ -177,6 +177,8 @@ def _post_shutdown(self) -> None: > > self._qtest_sock_pair[0].close() > > self._qtest_sock_pair[1].close() > > self._qtest_sock_pair = None > > + if self._qtest is not None: > > + self._qtest.close() > > super()._post_shutdown() > > > > def qtest(self, cmd: str) -> str: > > -- > > 2.49.0 > > > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|