From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Tanish Desai <tanishdesai37@gmail.com>,
qemu-devel@nongnu.org, Mads Ynddal <mads@ynddal.dk>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH v2 1/2] tracetool: add CHECK_TRACE_EVENT_GET_STATE
Date: Wed, 20 Aug 2025 13:14:44 +0100 [thread overview]
Message-ID: <aKW8NABFH8g-NCkx@redhat.com> (raw)
In-Reply-To: <46c5fbcb-9aec-4f9e-984a-b2f255210007@redhat.com>
On Thu, Aug 07, 2025 at 12:35:39PM +0200, Paolo Bonzini wrote:
> On 8/6/25 21:13, Daniel P. Berrangé wrote:
> > It is best to have new functionality added in a separate commit
> > from the removal of obsolete code.
>
> My mistake - when Tanish and I "un-rebased" these patches from on top of
> yours, we placed the removal of the "nocheck" functions in patch 1 instead
> of patch 2 where it made more sense.
>
> > I've co-incidentally got removal of this obsolete code in the
> > tracing test suite series I posted, so one will need to be
> > rebased on top of the other, depending on what order Stefan
> > wants to take the patches.
>
> If the main blocker (the /dev/stdout issue) is fixed quickly, your patches
> should go in first because they aid in reviewing this one.
I posted a new version that drops the stdout patch
https://lists.nongnu.org/archive/html/qemu-devel/2025-08/msg02716.html
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-08-20 12:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 15:05 [PATCH v2 0/2] tracetool: remove no_check_foo() and if(true){..} blocks Tanish Desai
2025-08-06 15:05 ` [PATCH v2 1/2] tracetool: add CHECK_TRACE_EVENT_GET_STATE Tanish Desai
2025-08-06 19:13 ` Daniel P. Berrangé
2025-08-07 10:35 ` Paolo Bonzini
2025-08-20 12:14 ` Daniel P. Berrangé [this message]
2025-08-07 19:23 ` Stefan Hajnoczi
2025-08-06 15:05 ` [PATCH v2 2/2] tracetool/format: remove redundent trace-event checks Tanish Desai
2025-08-06 16:53 ` Daniel P. Berrangé
2025-08-07 19:25 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKW8NABFH8g-NCkx@redhat.com \
--to=berrange@redhat.com \
--cc=mads@ynddal.dk \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=tanishdesai37@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).