From: "Daniel P. Berrangé" <berrange@redhat.com>
To: John Levon <john.levon@nutanix.com>
Cc: qemu-devel@nongnu.org, "Cédric Le Goater" <clg@redhat.com>,
"Thanos Makatos" <thanos.makatos@nutanix.com>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH 2/3] tests/functional: add vm param to console routines
Date: Wed, 20 Aug 2025 17:10:21 +0100 [thread overview]
Message-ID: <aKXzbVrHZm0bOhpE@redhat.com> (raw)
In-Reply-To: <20250818110546.2159622-3-john.levon@nutanix.com>
On Mon, Aug 18, 2025 at 12:05:45PM +0100, John Levon wrote:
> Extend the "vm" parameter of wait_for_console_pattern() to all the other
> utility functions; this allows them to be used on a VM other than
> test.vm.
>
> Signed-off-by: John Levon <john.levon@nutanix.com>
> ---
> tests/functional/qemu_test/cmd.py | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-08-20 16:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 11:05 [PATCH 0/3] vfio-user client functional test John Levon
2025-08-18 11:05 ` [PATCH 1/3] tests/functional: return output from exec_command_and_wait_for_pattern() John Levon
2025-08-20 16:08 ` Daniel P. Berrangé
2025-08-18 11:05 ` [PATCH 2/3] tests/functional: add vm param to console routines John Levon
2025-08-20 16:10 ` Daniel P. Berrangé [this message]
2025-08-18 11:05 ` [PATCH 3/3] tests/functional: add a vfio-user smoke test John Levon
2025-08-20 16:14 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKXzbVrHZm0bOhpE@redhat.com \
--to=berrange@redhat.com \
--cc=clg@redhat.com \
--cc=john.levon@nutanix.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thanos.makatos@nutanix.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).