From: Zhao Liu <zhao1.liu@intel.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, mtosatti@redhat.com,
kvm@vger.kernel.org, aharivel@redhat.com
Subject: Re: [PATCH 1/2] i386/kvm/vmsr_energy: Plug memory leak on failure to connect socket
Date: Fri, 29 Aug 2025 15:49:12 +0800 [thread overview]
Message-ID: <aLFbeCthx53qkq8e@intel.com> (raw)
In-Reply-To: <20250723133257.1497640-2-armbru@redhat.com>
On Wed, Jul 23, 2025 at 03:32:56PM +0200, Markus Armbruster wrote:
> Date: Wed, 23 Jul 2025 15:32:56 +0200
> From: Markus Armbruster <armbru@redhat.com>
> Subject: [PATCH 1/2] i386/kvm/vmsr_energy: Plug memory leak on failure to
> connect socket
>
> vmsr_open_socket() leaks the Error set by
> qio_channel_socket_connect_sync(). Plug the leak by not creating the
> Error.
>
> Fixes: 0418f90809ae (Add support for RAPL MSRs in KVM/Qemu)
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> target/i386/kvm/vmsr_energy.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
next prev parent reply other threads:[~2025-08-30 15:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 13:32 [PATCH 0/2] A fix and cleanup around qio_channel_socket_connect_sync() Markus Armbruster
2025-07-23 13:32 ` [PATCH 1/2] i386/kvm/vmsr_energy: Plug memory leak on failure to connect socket Markus Armbruster
2025-08-29 7:49 ` Zhao Liu [this message]
2025-09-03 7:10 ` Michael Tokarev
2025-07-23 13:32 ` [PATCH 2/2] vfio scsi ui: Error-check qio_channel_socket_connect_sync() the same way Markus Armbruster
2025-08-29 7:50 ` Zhao Liu
2025-09-03 7:37 ` Michael Tokarev
2025-08-28 5:33 ` [PATCH 0/2] A fix and cleanup around qio_channel_socket_connect_sync() Markus Armbruster
2025-09-01 11:14 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLFbeCthx53qkq8e@intel.com \
--to=zhao1.liu@intel.com \
--cc=aharivel@redhat.com \
--cc=armbru@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).