From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] tests/functional/m68k: Avoid ResourceWarning in the nextcube test
Date: Fri, 29 Aug 2025 15:22:33 +0100 [thread overview]
Message-ID: <aLG3qVta6cBxnFWy@redhat.com> (raw)
In-Reply-To: <20250829142000.62320-1-thuth@redhat.com>
On Fri, Aug 29, 2025 at 04:20:00PM +0200, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> Since commit c3fd296cf7b1 ("functional: always enable all python
> warnings") we enabled more warnings for the functional tests. This
> triggers now a warning in the nextcube test:
>
> tests/functional/m68k/test_nextcube.py:47: ResourceWarning:
> unclosed file <_io.BufferedReader name='tests/functional/m68k/test_nextcube.NextCubeMachine.test_bootrom_framebuffer_size/scratch/dump.ppm'>
> width, height = Image.open(screenshot_path).size
>
> Use a proper "with" context to avoid it.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/functional/m68k/test_nextcube.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2025-08-30 15:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 14:20 [PATCH] tests/functional/m68k: Avoid ResourceWarning in the nextcube test Thomas Huth
2025-08-29 14:22 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLG3qVta6cBxnFWy@redhat.com \
--to=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).