From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6F69CA1002 for ; Mon, 1 Sep 2025 13:38:35 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ut4jV-0005qI-93; Mon, 01 Sep 2025 09:38:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ut4jT-0005ok-Sk for qemu-devel@nongnu.org; Mon, 01 Sep 2025 09:38:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ut4jQ-0002sY-JQ for qemu-devel@nongnu.org; Mon, 01 Sep 2025 09:38:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756733879; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UgsEaIVb7dOAyNYJBPoyoEcEYDI0X0WnsrsLkdY2hoE=; b=ciSMXar7ZY68kIG1XWif6V9hNJqBCOIB++Hhgt9rU10lzqKcKB8bTqBcw43zHHc1z+bHnt /Vse0h3DOVipMay670Gv2FWoqxIyCooH2qCkyhwk8D9oyx0zCqHmjyfAHBBiUOJ1fengtr uoH4p/02b7dyaQeGTZfcvdV/euQG4xk= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-601-dz18ecxlNBOU4mvOHyz-fA-1; Mon, 01 Sep 2025 09:37:56 -0400 X-MC-Unique: dz18ecxlNBOU4mvOHyz-fA-1 X-Mimecast-MFC-AGG-ID: dz18ecxlNBOU4mvOHyz-fA_1756733874 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7024D1800289; Mon, 1 Sep 2025 13:37:54 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.100]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 83F6818003FC; Mon, 1 Sep 2025 13:37:48 +0000 (UTC) Date: Mon, 1 Sep 2025 14:37:45 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Paolo Bonzini , qemu-ppc@nongnu.org, Peter Maydell , Harsh Prateek Bora , Stefan Hajnoczi , Nicholas Piggin , Chinmay Rath , kvm@vger.kernel.org, Glenn Miles , Thomas Huth , Alex =?utf-8?Q?Benn=C3=A9e?= , Pierrick Bouvier , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Subject: Re: [PATCH v2 2/3] buildsys: Prohibit alloca() use on system code Message-ID: References: <20250901132626.28639-1-philmd@linaro.org> <20250901132626.28639-3-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250901132626.28639-3-philmd@linaro.org> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Sep 01, 2025 at 03:26:25PM +0200, Philippe Mathieu-Daudé wrote: > Similarly to commit 64c1a544352 ("meson: Enable -Wvla") with > variable length arrays, forbid alloca() uses on system code. > > There are few uses on ancient linux-user code, do not bother > there. This says you're not turning on -Walloca for linux-user, but.... > +if have_system > + warn_flags += ['-Walloca'] > +endif ...surely this still turns on -Walloca for linux-user, if the build has enabled multiple targets covering both system & user mode. ie a default qemu build ? > + > # Set up C++ compiler flags > qemu_cxxflags = [] > if 'cpp' in all_languages > -- > 2.51.0 > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|