From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, peterx@redhat.com
Subject: Re: [PATCH 01/10] io/channel: document how qio_channel_readv_full() handles fds
Date: Tue, 9 Sep 2025 09:34:31 +0100 [thread overview]
Message-ID: <aL_mlwurxB6VAPA8@redhat.com> (raw)
In-Reply-To: <20250903094411.1029449-2-vsementsov@yandex-team.ru>
On Wed, Sep 03, 2025 at 12:44:01PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> The only realization, which may have incoming fds is
> qio_channel_socket_readv() (in io/channel-socket.c).
> qio_channel_socket_readv() do call (through
> qio_channel_socket_copy_fds()) qemu_socket_set_block() and
> qemu_set_cloexec() for each fd.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
> include/io/channel.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-09-09 8:36 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 9:44 [PATCH 00/10] io: deal with blocking/non-blocking fds Vladimir Sementsov-Ogievskiy
2025-09-03 9:44 ` [PATCH 01/10] io/channel: document how qio_channel_readv_full() handles fds Vladimir Sementsov-Ogievskiy
2025-09-09 8:34 ` Daniel P. Berrangé [this message]
2025-09-03 9:44 ` [PATCH 02/10] char-socket: rework tcp_chr_recv() Vladimir Sementsov-Ogievskiy
2025-09-08 21:53 ` Peter Xu
2025-09-09 7:49 ` Vladimir Sementsov-Ogievskiy
2025-09-09 8:38 ` Daniel P. Berrangé
2025-09-09 8:46 ` Vladimir Sementsov-Ogievskiy
2025-09-03 9:44 ` [PATCH 03/10] util: add qemu_set_blocking() function Vladimir Sementsov-Ogievskiy
2025-09-08 22:02 ` Peter Xu
2025-09-09 7:51 ` Vladimir Sementsov-Ogievskiy
2025-09-09 8:59 ` Daniel P. Berrangé
2025-09-03 9:44 ` [PATCH 04/10] util: drop qemu_socket_set_nonblock() Vladimir Sementsov-Ogievskiy
2025-09-08 22:16 ` Peter Xu
2025-09-09 8:19 ` Vladimir Sementsov-Ogievskiy
2025-09-10 9:41 ` Daniel P. Berrangé
2025-09-10 10:32 ` Vladimir Sementsov-Ogievskiy
2025-09-10 9:44 ` Daniel P. Berrangé
2025-09-10 10:33 ` Vladimir Sementsov-Ogievskiy
2025-09-10 15:30 ` Vladimir Sementsov-Ogievskiy
2025-09-10 17:55 ` Vladimir Sementsov-Ogievskiy
2025-09-10 18:15 ` Daniel P. Berrangé
2025-09-10 18:52 ` Vladimir Sementsov-Ogievskiy
2025-09-12 14:51 ` Daniel P. Berrangé
2025-09-03 9:44 ` [PATCH 05/10] util: drop qemu_socket_try_set_nonblock() Vladimir Sementsov-Ogievskiy
2025-09-09 0:09 ` Peter Xu
2025-09-03 9:44 ` [PATCH 06/10] util: drop qemu_socket_set_block() Vladimir Sementsov-Ogievskiy
2025-09-03 9:44 ` [PATCH 07/10] use qemu_set_blocking instead of g_unix_set_fd_nonblocking Vladimir Sementsov-Ogievskiy
2025-09-09 9:00 ` Daniel P. Berrangé
2025-09-09 9:11 ` Vladimir Sementsov-Ogievskiy
2025-09-09 9:15 ` Daniel P. Berrangé
2025-09-09 9:50 ` Vladimir Sementsov-Ogievskiy
2025-09-10 9:32 ` Daniel P. Berrangé
2025-09-09 14:24 ` Stefan Hajnoczi
2025-09-03 9:44 ` [PATCH 08/10] oslib-posix: add qemu_fds_set_blocking() helper Vladimir Sementsov-Ogievskiy
2025-09-03 9:48 ` Vladimir Sementsov-Ogievskiy
2025-09-10 9:52 ` Daniel P. Berrangé
2025-09-10 10:42 ` Vladimir Sementsov-Ogievskiy
2025-09-03 9:44 ` [PATCH 09/10] qio_channel_readv_full(): move setting fd blocking to callers Vladimir Sementsov-Ogievskiy
2025-09-03 9:44 ` [PATCH 10/10] migration/qemu-file: don't make incoming fds blocking again Vladimir Sementsov-Ogievskiy
2025-09-03 9:47 ` Vladimir Sementsov-Ogievskiy
2025-09-04 14:35 ` [PATCH 00/10] io: deal with blocking/non-blocking fds Lei Yang
2025-09-09 8:12 ` Vladimir Sementsov-Ogievskiy
2025-09-09 14:25 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aL_mlwurxB6VAPA8@redhat.com \
--to=berrange@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).