From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A491DCAC587 for ; Tue, 9 Sep 2025 09:17:13 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uvuSi-0004Yv-50; Tue, 09 Sep 2025 05:16:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uvuSY-0004Bg-RA for qemu-devel@nongnu.org; Tue, 09 Sep 2025 05:16:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uvuSQ-0007cw-U7 for qemu-devel@nongnu.org; Tue, 09 Sep 2025 05:16:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757409368; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XLTdFIrydxP18sL39W++yMP2XbxieZcPtiOm1+wtePU=; b=Mb2GKCuehqC/g2s/L6pmAuLLbR8XbIphL4wemRHbLpq9SwMm9rdjzhTbn4STGCSFbDMgF/ F59AYNWIm8tlZh+Txv3rpUMrL4ep/0C7rUymXaNgdUyPQORs1GLezpnrRImz4ml41YHQH0 qgCnMQmO0OJ2PI4HrXhzZe6giz06JWI= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-67-LH3168zTOcGZWuuqkLDuew-1; Tue, 09 Sep 2025 05:16:07 -0400 X-MC-Unique: LH3168zTOcGZWuuqkLDuew-1 X-Mimecast-MFC-AGG-ID: LH3168zTOcGZWuuqkLDuew_1757409366 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A1E961800451; Tue, 9 Sep 2025 09:16:05 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.45]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AE7241800452; Tue, 9 Sep 2025 09:15:59 +0000 (UTC) Date: Tue, 9 Sep 2025 10:15:56 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Vladimir Sementsov-Ogievskiy Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, peterx@redhat.com, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Paolo Bonzini , Gerd Hoffmann , "Michael S. Tsirkin" , Gustavo Romero , Stefano Garzarella , Jason Wang , Michael Roth , Kostiantyn Kostiuk , Alexander Bulekov , Bandan Das , Stefan Hajnoczi , Fabiano Rosas , Darren Kenny , Qiuhao Li , Laurent Vivier Subject: Re: [PATCH 07/10] use qemu_set_blocking instead of g_unix_set_fd_nonblocking Message-ID: References: <20250903094411.1029449-1-vsementsov@yandex-team.ru> <20250903094411.1029449-8-vsementsov@yandex-team.ru> <4b0de513-12fa-4891-8dde-82971efa4778@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4b0de513-12fa-4891-8dde-82971efa4778@yandex-team.ru> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Sep 09, 2025 at 12:11:19PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 09.09.25 12:00, Daniel P. Berrangé wrote: > > On Wed, Sep 03, 2025 at 12:44:07PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > > Instead of open-coded g_unix_set_fd_nonblocking() calls, use > > > QEMU wrapper qemu_socket_set_nonblock(). > > > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy > > > --- > > > chardev/char-fd.c | 4 ++-- > > > chardev/char-pty.c | 3 +-- > > > chardev/char-serial.c | 3 +-- > > > chardev/char-stdio.c | 3 +-- > > > hw/input/virtio-input-host.c | 3 +-- > > > hw/misc/ivshmem-flat.c | 4 +++- > > > hw/misc/ivshmem-pci.c | 8 +++++++- > > > hw/virtio/vhost-vsock.c | 8 ++------ > > > io/channel-command.c | 9 ++++++--- > > > io/channel-file.c | 3 +-- > > > net/tap-bsd.c | 12 ++++++++++-- > > > net/tap-linux.c | 8 +++++++- > > > net/tap-solaris.c | 7 ++++++- > > > net/tap.c | 21 ++++++--------------- > > > qga/commands-posix.c | 3 +-- > > > tests/qtest/fuzz/virtio_net_fuzz.c | 2 +- > > > tests/qtest/vhost-user-test.c | 3 +-- > > > tests/unit/test-iov.c | 5 +++-- > > > ui/input-linux.c | 3 +-- > > > util/event_notifier-posix.c | 5 +++-- > > > util/main-loop.c | 6 +++++- > > > 21 files changed, 69 insertions(+), 54 deletions(-) > > > > > diff --git a/io/channel-command.c b/io/channel-command.c > > > index 8966dd3a2b..8ae9a026b3 100644 > > > --- a/io/channel-command.c > > > +++ b/io/channel-command.c > > > @@ -277,9 +277,12 @@ static int qio_channel_command_set_blocking(QIOChannel *ioc, > > > cioc->blocking = enabled; > > > #else > > > - if ((cioc->writefd >= 0 && !g_unix_set_fd_nonblocking(cioc->writefd, !enabled, NULL)) || > > > - (cioc->readfd >= 0 && !g_unix_set_fd_nonblocking(cioc->readfd, !enabled, NULL))) { > > > - error_setg_errno(errp, errno, "Failed to set FD nonblocking"); > > > + if (cioc->writefd >= 0 && > > > + !qemu_set_blocking(cioc->writefd, enabled, errp)) { > > > + return -1; > > > + } > > > + if (cioc->readfd >= 0 && > > > + !qemu_set_blocking(cioc->readfd, enabled, errp)) { > > > return -1; > > > } > > > #endif > > > diff --git a/io/channel-file.c b/io/channel-file.c > > > index ca3f180cc2..5cef75a67c 100644 > > > --- a/io/channel-file.c > > > +++ b/io/channel-file.c > > > @@ -223,8 +223,7 @@ static int qio_channel_file_set_blocking(QIOChannel *ioc, > > > #else > > > QIOChannelFile *fioc = QIO_CHANNEL_FILE(ioc); > > > - if (!g_unix_set_fd_nonblocking(fioc->fd, !enabled, NULL)) { > > > - error_setg_errno(errp, errno, "Failed to set FD nonblocking"); > > > + if (!qemu_set_blocking(fioc->fd, enabled, errp)) { > > > return -1; > > > } > > > return 0; > > > > This is wrong for Windows. fioc->fd is not a socket, but this is passing > > it to an API whose impl assume it is receiving a socket. > > > > But what is changed with the patch? g_unix_set_fd_nonblocking(fioc->fd, ..) is wrong for Windows as well. Actually I missed the #ifdef. This code is in an #else branch that excludes compilation on Wnidows - the Windows brach just raise an error. > And making separate qemu_set_blocking() and qemu_socket_set_blocking(), which do the same > thing, doesn't make sense.. > > Hmm. But we can define qemu_set_blocking() only for Linux, keeping qemu_socket_set_blocking() the generic > function. Still, nothing prevents using qemu_socket_set_blocking() on non-sockets.. We just relying on the name of the function alerting the developer / reviewer. If you're dealing with a FIFO pipe FD you are (hopefully) going to realize that qemu_socket_XXX is not a function to be used. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|