From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37CC8CAC587 for ; Tue, 9 Sep 2025 09:18:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uvuUB-0005lE-Hs; Tue, 09 Sep 2025 05:17:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uvuUA-0005ki-36 for qemu-devel@nongnu.org; Tue, 09 Sep 2025 05:17:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uvuU5-0007jG-3A for qemu-devel@nongnu.org; Tue, 09 Sep 2025 05:17:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757409469; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o1wV7s0PBuYHMU3+/24J90kIvp/DulBRrQ3LIZXLbDs=; b=OrCnnLzys8xZYiua2lDt6GrFqo7IGYofbjYCHQbGdReZvtEvLEn65P9GF/EGbs4UZLI45n nIpggy8dbGODEIm7c+ZRakn9t6HdWw+pT6rVEqyDek+waQT59zKfu9cg09qrHySJHAyoG2 cI3LPDCIRXAhOj1/3YgQopgKjeDK330= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-368-FeJNNKJmOJGMswmHGR-DEg-1; Tue, 09 Sep 2025 05:17:46 -0400 X-MC-Unique: FeJNNKJmOJGMswmHGR-DEg-1 X-Mimecast-MFC-AGG-ID: FeJNNKJmOJGMswmHGR-DEg_1757409465 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 956721800447; Tue, 9 Sep 2025 09:17:45 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.45]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 40F101956095; Tue, 9 Sep 2025 09:17:44 +0000 (UTC) Date: Tue, 9 Sep 2025 10:17:40 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Andrew Keesler Cc: marcandre.lureau@gmail.com, qemu-devel@nongnu.org Subject: Re: [PATCH v3 1/1] Support per-head resolutions with virtio-gpu Message-ID: References: <20250902141312.750525-1-ankeesler@google.com> <20250902141312.750525-2-ankeesler@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250902141312.750525-2-ankeesler@google.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Sep 02, 2025 at 02:13:12PM +0000, Andrew Keesler wrote: > In 454f4b0f, we started down the path of supporting separate > configurations per display head (e.g., you have 2 heads - one with > EDID name "AAA" and the other with EDID name "BBB"). > > In this change, we add resolution to this configuration surface (e.g., > you have 2 heads - one with resolution 111x222 and the other with > resolution 333x444). > > -display vnc=localhost:0,id=aaa,display=vga,head=0 \ > -display vnc=localhost:1,id=bbb,display=vga,head=1 \ > -device '{"driver":"virtio-vga", > "max_outputs":2, > "id":"vga", > "outputs":[ > { > "name":"AAA", > "xres":111, > "yres":222 > }, > { > "name":"BBB", > "xres":333, > "yres":444 > } > ]}' > > Here is the behavior matrix of the current resolution configuration > surface (xres/yres) with the new resolution configuration surface > (outputs[i].xres/yres). > > Case: !(xres || yres) && !(outputs[i].has_xres && outputs[i].has_yres) > Behavior: current behavior - outputs[0] enabled with default xres/yres > > Case: (xres || yres) && !(outputs[i].has_xres && outputs[i].has_yres) > Behavior: current behavior - outputs[0] enabled with xres/yres > > Case: !(xres || yres) && (outputs[i].has_xres && outputs[i].has_yres) > Behavior: new behavior - outputs[i] enabled with outputs[i].xres/yres > > Case: (xres || yres) && (outputs[i].has_xres && outputs[i].has_yres) > Behavior: new behavior - outputs[i] enabled with outputs[i].xres/yres > --- > hw/display/virtio-gpu-base.c | 10 ++++++++++ > qapi/virtio.json | 10 ++++++++-- > 2 files changed, 18 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|