From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH] linux-user: avoid -Werror=int-in-bool-context
Date: Fri, 19 Sep 2025 10:31:15 +0100 [thread overview]
Message-ID: <aM0i4zxm5RaoUIPH@redhat.com> (raw)
In-Reply-To: <20250919083612.86546-1-pbonzini@redhat.com>
On Fri, Sep 19, 2025 at 10:36:12AM +0200, Paolo Bonzini wrote:
> linux-user is failing to compile on Fedora 43:
>
> ../linux-user/strace.c:57:66: error: enum constant in boolean context [-Werror=int-in-bool-context]
> 57 | #define FLAG_BASIC(V, M, N) { V, M | QEMU_BUILD_BUG_ON_ZERO(!(M)), N }
>
> The warning does not seem to useful and we could even disable it, but
> the workaround is simple in this case.
>
> Cc: qemu-stable@nongnu.org
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> linux-user/strace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-09-19 9:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 8:36 [PATCH] linux-user: avoid -Werror=int-in-bool-context Paolo Bonzini
2025-09-19 9:31 ` Daniel P. Berrangé [this message]
2025-09-19 9:33 ` Peter Maydell
2025-09-19 9:45 ` Markus Armbruster
2025-09-19 9:45 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aM0i4zxm5RaoUIPH@redhat.com \
--to=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).