qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Jiří Denemark" <jdenemar@redhat.com>
Cc: Peter Xu <peterx@redhat.com>, Juraj Marcin <jmarcin@redhat.com>,
	qemu-devel@nongnu.org, Fabiano Rosas <farosas@suse.de>
Subject: Re: [PATCH] migration: Apply migration specific keep-alive defaults to inet socket
Date: Fri, 19 Sep 2025 13:00:34 +0100	[thread overview]
Message-ID: <aM1F4vGh86vq0MW3@redhat.com> (raw)
In-Reply-To: <aM1Fj6tpynIz9XHL@orkuz.int.mamuti.net>

On Fri, Sep 19, 2025 at 01:59:11PM +0200, Jiří Denemark wrote:
> On Thu, Sep 18, 2025 at 11:10:49 -0400, Peter Xu wrote:
> > On Thu, Sep 18, 2025 at 03:45:21PM +0100, Daniel P. Berrangé wrote:
> > > There needs to be a way to initiate post-copy recovery regardless
> > > of whether we've hit a keepalive timeout. Especially if we can
> > > see one QEMU in postcopy-paused, but not the other side, it
> > > doesn't appear to make sense to block the recovery process.
> > > 
> > > The virDomainJobCancel command can do a migrate-cancel on the
> > > src, but it didn't look like we could do the same on the dst.
> > > Unless I've overlooked something, Libvirt needs to gain a way
> > > to explicitly force both sides into the postcopy-paused state,
> > > and thus be able to immediately initiate recovery.
> > 
> > Right, if libvirt can do that then problem should have been solved too.
> 
> I think we should be able to use the yank command to tell QEMU to close
> migration connections. I haven't tried it on the destination, but I
> guess it should work similarly to the source where it causes the
> migration to switch to postcopy-paused. It seems to be an equivalent of
> migrate-pause. So can we safely use yank in such situations?

Can't we use migrate-pause on the target too ?  IIUC that was what Peter
was suggesting earlier in the thread, unless I mis-interpreted ?

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2025-09-19 12:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09 15:01 [PATCH] migration: Apply migration specific keep-alive defaults to inet socket Juraj Marcin
2025-09-09 15:09 ` Daniel P. Berrangé
2025-09-09 21:58   ` Peter Xu
2025-09-10  7:10     ` Daniel P. Berrangé
2025-09-10 16:36       ` Peter Xu
2025-09-12 10:20         ` Daniel P. Berrangé
2025-09-12 15:02           ` Peter Xu
2025-09-15 18:23             ` Daniel P. Berrangé
2025-09-15 20:05               ` Peter Xu
2025-09-18 14:16               ` Juraj Marcin
2025-09-18 14:45                 ` Daniel P. Berrangé
2025-09-18 15:10                   ` Peter Xu
2025-09-18 15:52                     ` Daniel P. Berrangé
2025-09-19 11:59                     ` Jiří Denemark
2025-09-19 12:00                       ` Daniel P. Berrangé [this message]
2025-09-19 12:10                         ` Jiří Denemark
2025-09-19 12:04                   ` Jiří Denemark
2025-09-10 12:05   ` Juraj Marcin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aM1F4vGh86vq0MW3@redhat.com \
    --to=berrange@redhat.com \
    --cc=farosas@suse.de \
    --cc=jdenemar@redhat.com \
    --cc=jmarcin@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).