From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4263BCA101F for ; Wed, 10 Sep 2025 18:07:25 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uwPD7-0002BG-De; Wed, 10 Sep 2025 14:06:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uwPCY-0000cy-Me for qemu-devel@nongnu.org; Wed, 10 Sep 2025 14:05:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uwPCW-00050Q-LL for qemu-devel@nongnu.org; Wed, 10 Sep 2025 14:05:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757527547; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=NdibCPxAZX1isc7mCsZl5Mu924d8hKRd4Nv1RYXWrPg=; b=OARAdw8bLI9/7vJ1N6E3624Z1kYkVtoRKsaGknRsN1CVJ7bR8DxZC1ZnIfvylNUdLqWXh2 mXgvrnWx4vGzzinAnJU8tkgtKlZEMVI+Ng8ueLfUe0ZP7xhuZDS2deu8jftxlNB0EEaGBc f1MLwg8KtH9JgK2VGoLiAH2QgRcMMk8= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-uWANk37WOmSCOr17-dg9Yg-1; Wed, 10 Sep 2025 14:05:44 -0400 X-MC-Unique: uWANk37WOmSCOr17-dg9Yg-1 X-Mimecast-MFC-AGG-ID: uWANk37WOmSCOr17-dg9Yg_1757527543 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7E9F019560B6; Wed, 10 Sep 2025 18:05:43 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.57]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9F9151956095; Wed, 10 Sep 2025 18:05:40 +0000 (UTC) Date: Wed, 10 Sep 2025 19:05:37 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Richard Henderson Cc: qemu-devel@nongnu.org Subject: Re: [RFC 0/4] util: qmessage_context followup Message-ID: References: <20250902103010.309094-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250902103010.309094-1-richard.henderson@linaro.org> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Sep 02, 2025 at 12:30:06PM +0200, Richard Henderson wrote: > Hi Daniel, > > I'm still not keen on qmessage_context allocating a string. > > If we *did* allocate a string, it should be a GString so that we can > easily append to that. The only benefit I see from this is that we > would collect all of the output and it would reach stderr atomically. > > However, I think it's better to not collect the message and just > output the pieces. Something like the following. The names are > horrible and I didn't document the patches well. I've posted a v3 of my series which incorporates the conceptual idea you show here. I managed to simplify it somewhat as I came to realize the qmessage_context code never needs to write to anything other than a "FILE *", because we always skip the context when writing to HMP. IOW, we could simply use fprintf() directly throughout With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|