From: Dominique Martinet <asmadeus@codewreck.org>
To: Filip Hejsek <filip.hejsek@gmail.com>
Cc: Szymon Lukasz <noh4hss@gmail.com>,
qemu-devel@nongnu.org, lvivier@redhat.com, berrange@redhat.com,
amit@kernel.org, mst@redhat.com, marcandre.lureau@redhat.com,
pbonzini@redhat.com
Subject: Re: [PATCH v3 0/9] virtio-console: notify about the terminal size
Date: Fri, 12 Sep 2025 06:53:42 +0900 [thread overview]
Message-ID: <aMNE5rOJaORVmk3M@codewreck.org> (raw)
In-Reply-To: <e30c59563cce0fc8e4935c5b6aba6f85cf8a8288.camel@gmail.com>
Filip Hejsek wrote on Thu, Sep 11, 2025 at 11:19:15PM +0200:
> > Done. You can find an updated version of the patches at
> > <https://gitlab.com/filip-hejsek/qemu/-/commits/console-resize>.
> > I haven't tested the updated version though. I will maybe do some
> > testing and then submit it to the mailing list for review, although if
> > anyone else would like to take over then feel free to do so.
>
> I have done some tests and it seems that lines and columns are swapped.
> Maybe the implementation in the linux kernel was changed to conform to
> the spec?
Yes, they have:
https://git.kernel.org/linus/5326ab737a47278dbd16ed3ee7380b26c7056ddd
I had also rebased the patches but wasn't sure how it was supposed to
work, but perhaps that was why it appeared not to work instead...
(I assumed running qemu with something like that would "just resize",
but also tried the qmp command to no avail:
-serial none -device virtio-serial-pci -chardev stdio,id=foo -device virtconsole,chardev=foo
)
I'll retry with your branch, thank you !
--
Dominique Martinet | Asmadeus
prev parent reply other threads:[~2025-09-11 21:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 16:40 [PATCH v3 0/9] virtio-console: notify about the terminal size Szymon Lukasz
2020-06-29 16:40 ` [PATCH v3 1/9] chardev: add cols, rows fields Szymon Lukasz
2020-06-29 16:40 ` [PATCH v3 2/9] chardev: add CHR_EVENT_RESIZE Szymon Lukasz
2020-06-29 16:40 ` [PATCH v3 3/9] chardev: add qemu_chr_resize() Szymon Lukasz
2020-06-29 16:40 ` [PATCH v3 4/9] char-mux: add support for the terminal size Szymon Lukasz
2020-06-29 16:40 ` [PATCH v3 5/9] main-loop: change the handling of SIGWINCH Szymon Lukasz
2020-06-29 16:40 ` [PATCH v3 6/9] char-stdio: add support for the terminal size Szymon Lukasz
2020-06-29 16:40 ` [PATCH v3 7/9] qmp: add chardev-resize command Szymon Lukasz
2020-06-29 16:40 ` [PATCH v3 8/9] virtio-serial-bus: add terminal resize messages Szymon Lukasz
2020-06-29 16:40 ` [PATCH v3 9/9] virtio-console: notify the guest about terminal resizes Szymon Lukasz
2023-10-23 3:12 ` [PATCH v3 0/9] virtio-console: notify about the terminal size Filip Hejsek
2023-10-23 8:09 ` Amit Shah
2025-09-09 13:48 ` Dominique Martinet
2025-09-09 19:24 ` Michael S. Tsirkin
2025-09-11 14:08 ` Filip Hejsek
2025-09-11 16:43 ` Filip Hejsek
2025-09-11 21:19 ` Filip Hejsek
2025-09-11 21:53 ` Dominique Martinet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMNE5rOJaORVmk3M@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=amit@kernel.org \
--cc=berrange@redhat.com \
--cc=filip.hejsek@gmail.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=noh4hss@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).