Re: [PATCH 20/33] rust: split "bql" crate

[Zhao Liu <zhao1.liu@intel.com>]

On Mon, Sep 08, 2025 at 12:49:52PM +0200, Paolo Bonzini wrote:
> Date: Mon,  8 Sep 2025 12:49:52 +0200
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH 20/33] rust: split "bql" crate
> X-Mailer: git-send-email 2.51.0
> 
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Unfortunately, an example had to be compile-time disabled, since it
> relies on higher level crates (qdev, irq etc). The alternative is
> probably to move that code to an example in qemu-api or elsewere and
> make a link to it, or include_str.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Link: https://lore.kernel.org/r/20250827104147.717203-12-marcandre.lureau@redhat.com
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  MAINTAINERS                          |  1 +
>  rust/bql/wrapper.h                   | 27 ++++++++
>  rust/Cargo.lock                      | 10 +++
>  rust/Cargo.toml                      |  1 +
>  rust/bql/Cargo.toml                  | 23 +++++++
>  rust/bql/build.rs                    |  1 +
>  rust/bql/meson.build                 | 52 ++++++++++++++++
>  rust/bql/src/bindings.rs             | 25 ++++++++
>  rust/{qemu-api => bql}/src/cell.rs   | 92 ++++++++++------------------
>  rust/bql/src/lib.rs                  | 29 +++++++++
>  rust/common/src/opaque.rs            |  4 +-
>  rust/hw/char/pl011/Cargo.toml        |  1 +
>  rust/hw/char/pl011/meson.build       |  1 +
>  rust/hw/char/pl011/src/device.rs     |  1 +
>  rust/hw/timer/hpet/Cargo.toml        |  1 +
>  rust/hw/timer/hpet/meson.build       |  1 +
>  rust/hw/timer/hpet/src/device.rs     |  2 +-
>  rust/hw/timer/hpet/src/fw_cfg.rs     |  5 +-
>  rust/meson.build                     |  1 +
>  rust/migration/src/vmstate.rs        |  4 +-
>  rust/qemu-api/Cargo.toml             |  5 +-
>  rust/qemu-api/meson.build            | 18 +-----
>  rust/qemu-api/src/chardev.rs         | 17 +++--
>  rust/qemu-api/src/irq.rs             |  1 +
>  rust/qemu-api/src/lib.rs             |  1 -
>  rust/qemu-api/src/prelude.rs         |  3 -
>  rust/qemu-api/src/qdev.rs            |  5 +-
>  rust/qemu-api/src/qom.rs             | 13 ++--
>  rust/qemu-api/src/sysbus.rs          | 13 ++--
>  rust/qemu-api/tests/tests.rs         |  4 +-
>  rust/qemu-api/tests/vmstate_tests.rs |  2 +-
>  31 files changed, 244 insertions(+), 120 deletions(-)
>  create mode 100644 rust/bql/wrapper.h
>  create mode 100644 rust/bql/Cargo.toml
>  create mode 120000 rust/bql/build.rs
>  create mode 100644 rust/bql/meson.build
>  create mode 100644 rust/bql/src/bindings.rs
>  rename rust/{qemu-api => bql}/src/cell.rs (92%)
>  create mode 100644 rust/bql/src/lib.rs

...

> diff --git a/rust/Cargo.lock b/rust/Cargo.lock
> index 048dd74757f..73ca9582a56 100644
> --- a/rust/Cargo.lock
> +++ b/rust/Cargo.lock
> @@ -44,6 +44,13 @@ dependencies = [
>   "qemu_api_macros",
>  ]
>  
> +[[package]]
> +name = "bql"
> +version = "0.1.0"
> +dependencies = [
> + "migration",
> +]

Yes, I also think this dependency is not much proper.

I also agree to move vmstate related things back to migration crate and
then we can make migration depend on bql (in fact, migration itself
indeed requires bql).

Current bql is good for now, so

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>