From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F5EFCAC582 for ; Fri, 12 Sep 2025 16:49:13 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ux6wl-0001eB-JQ; Fri, 12 Sep 2025 12:48:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ux6wb-0001dN-3W for qemu-devel@nongnu.org; Fri, 12 Sep 2025 12:48:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ux6wX-0008HB-Ug for qemu-devel@nongnu.org; Fri, 12 Sep 2025 12:48:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757695690; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fm9gZjozx57qowBHaBlbq/OnWgQpIoqHNrCceZgb2fY=; b=caXSUUPOiSNffDjRdyqoB+Q5AMBzWUk6SiBuz/fqHIHx95C7avJD2UdEZhXBWC1CPTxisP bJeQ2Kxsj+7/vazsbEVYcBRVWuUOtggDy/xmit0Dq2bCWSPxZUptuVD8lp8MUu+cj5+l7V iZkTKeUpRKI89ooF0Pcuse31BzESjps= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-300-9wOOkslvMLKslK4obsrjxQ-1; Fri, 12 Sep 2025 12:48:03 -0400 X-MC-Unique: 9wOOkslvMLKslK4obsrjxQ-1 X-Mimecast-MFC-AGG-ID: 9wOOkslvMLKslK4obsrjxQ_1757695682 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1F1471800451; Fri, 12 Sep 2025 16:48:02 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.154]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C87A6300021A; Fri, 12 Sep 2025 16:47:59 +0000 (UTC) Date: Fri, 12 Sep 2025 17:47:56 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Vladimir Sementsov-Ogievskiy Cc: peterx@redhat.com, farosas@suse.de, steven.sistare@oracle.com, qemu-devel@nongnu.org Subject: Re: [PATCH v4 1/2] migration/qemu-file: don't make incoming fds blocking again Message-ID: References: <20250910193112.1220763-1-vsementsov@yandex-team.ru> <20250910193112.1220763-2-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250910193112.1220763-2-vsementsov@yandex-team.ru> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Sep 10, 2025 at 10:31:11PM +0300, Vladimir Sementsov-Ogievskiy wrote: > In migration we want to pass fd "as is", not changing its > blocking status. > > The only current user of these fds is CPR state (through VMSTATE_FD), > which of-course doesn't want to modify fds on target when source is > still running and use these fds. > > Suggested-by: Daniel P. Berrangé > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/io/channel.h | 1 + > io/channel-socket.c | 13 +++++++++---- > migration/qemu-file.c | 3 ++- > 3 files changed, 12 insertions(+), 5 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|