From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B4E9CAC597 for ; Mon, 15 Sep 2025 15:23:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uyB1T-0006ds-TR; Mon, 15 Sep 2025 11:21:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uyB1Q-0006an-5c for qemu-devel@nongnu.org; Mon, 15 Sep 2025 11:21:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uyB1F-0001rU-T0 for qemu-devel@nongnu.org; Mon, 15 Sep 2025 11:21:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757949680; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H3ZLzzp0nz8fpGm6+TVnQUXsptqEu7/YT1oyTtndr/w=; b=RLLDbyQdOtQuKkZAaSrsRPSS5mXUE7pFTH8snXUbjd7kE8ZSv8PL/0AxAbgg6lrDNpKjxn BL5FhUTDxBVfhRnboM72pKKrzv9fz7cYIwo3zTs01Al2/6EgIcT/wVn1Ui1is5i1n1f/03 2H9l1fj2bDUpVOmPUVzvjF4aVr0G1q0= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-264-GxFZGvUsP2aWoXfx5wlmmw-1; Mon, 15 Sep 2025 11:21:15 -0400 X-MC-Unique: GxFZGvUsP2aWoXfx5wlmmw-1 X-Mimecast-MFC-AGG-ID: GxFZGvUsP2aWoXfx5wlmmw_1757949675 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C1C3D1800576; Mon, 15 Sep 2025 15:21:14 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.50]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1052319560B4; Mon, 15 Sep 2025 15:21:11 +0000 (UTC) Date: Mon, 15 Sep 2025 16:21:08 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Vladimir Sementsov-Ogievskiy Cc: qemu-devel@nongnu.org, peterx@redhat.com, qemu-block@nongnu.org, leiyang@redhat.com, marcandre.lureau@redhat.com Subject: Re: [PATCH v3 09/13] io/channel-socket: rework qio_channel_socket_copy_fds() Message-ID: References: <20250915132211.135095-1-vsementsov@yandex-team.ru> <20250915132211.135095-10-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250915132211.135095-10-vsementsov@yandex-team.ru> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.035, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Sep 15, 2025 at 04:22:06PM +0300, Vladimir Sementsov-Ogievskiy wrote: > We want to switch from qemu_socket_set_block() to newer > qemu_set_blocking(), which provides return status of operation, > to handle errors. > > Still, we want to keep qio_channel_socket_readv() interface clean, > as currently it allocate @fds only on success. > > So, in case of error, we should close all incoming fds and keep > user's @fds untouched or zero. > > Let's make separate functions qio_channel_handle_fds() and > qio_channel_cleanup_fds(), to achieve what we want. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/io/channel.h | 8 +++--- > io/channel-socket.c | 67 +++++++++++++++++++++++++++++++++----------- > 2 files changed, 55 insertions(+), 20 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|