From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: qemu-devel@nongnu.org, peterx@redhat.com, qemu-block@nongnu.org,
leiyang@redhat.com, marcandre.lureau@redhat.com,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3 12/13] chardev: qemu_chr_open_fd(): add errp
Date: Mon, 15 Sep 2025 16:23:11 +0100 [thread overview]
Message-ID: <aMgvX7NsR_SUSmuJ@redhat.com> (raw)
In-Reply-To: <20250915132211.135095-13-vsementsov@yandex-team.ru>
On Mon, Sep 15, 2025 at 04:22:09PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Every caller already support errp, let's go further.
>
> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
> chardev/char-fd.c | 12 ++++++++----
> chardev/char-file.c | 6 +++++-
> chardev/char-pipe.c | 9 ++++++++-
> chardev/char-serial.c | 5 ++++-
> chardev/char-stdio.c | 7 +++++--
> include/chardev/char-fd.h | 2 +-
> 6 files changed, 31 insertions(+), 10 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-09-15 15:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 13:21 [PATCH v3 00/13] io: deal with blocking/non-blocking fds Vladimir Sementsov-Ogievskiy
2025-09-15 13:21 ` [PATCH v3 01/13] char-socket: tcp_chr_recv(): drop extra _set_(block, cloexec) Vladimir Sementsov-Ogievskiy
2025-09-15 13:21 ` [PATCH v3 02/13] char-socket: tcp_chr_recv(): add comment Vladimir Sementsov-Ogievskiy
2025-09-15 13:22 ` [PATCH v3 03/13] util: add qemu_set_blocking() function Vladimir Sementsov-Ogievskiy
2025-09-15 13:22 ` [PATCH v3 04/13] util/error: add &error_reporter Vladimir Sementsov-Ogievskiy
2025-09-15 15:45 ` Peter Xu
2025-09-15 18:14 ` Vladimir Sementsov-Ogievskiy
2025-09-15 18:29 ` Daniel P. Berrangé
2025-09-15 18:40 ` Vladimir Sementsov-Ogievskiy
2025-09-17 13:51 ` Markus Armbruster
2025-09-15 13:22 ` [PATCH v3 05/13] handle result of qio_channel_set_blocking() Vladimir Sementsov-Ogievskiy
2025-09-15 17:04 ` Jag Raman
2025-09-15 18:32 ` Vladimir Sementsov-Ogievskiy
2025-09-15 13:22 ` [PATCH v3 06/13] migration: qemu_file_set_blocking(): add errp parameter Vladimir Sementsov-Ogievskiy
2025-09-15 13:22 ` [PATCH v3 07/13] util: drop qemu_socket_set_nonblock() Vladimir Sementsov-Ogievskiy
2025-09-15 13:22 ` [PATCH v3 08/13] util: drop qemu_socket_try_set_nonblock() Vladimir Sementsov-Ogievskiy
2025-09-15 13:22 ` [PATCH v3 09/13] io/channel-socket: rework qio_channel_socket_copy_fds() Vladimir Sementsov-Ogievskiy
2025-09-15 15:21 ` Daniel P. Berrangé
2025-09-15 13:22 ` [PATCH v3 10/13] util: drop qemu_socket_set_block() Vladimir Sementsov-Ogievskiy
2025-09-15 13:22 ` [PATCH v3 11/13] use qemu_set_blocking instead of g_unix_set_fd_nonblocking Vladimir Sementsov-Ogievskiy
2025-09-15 15:22 ` Daniel P. Berrangé
2025-09-15 13:22 ` [PATCH v3 12/13] chardev: qemu_chr_open_fd(): add errp Vladimir Sementsov-Ogievskiy
2025-09-15 15:23 ` Daniel P. Berrangé [this message]
2025-09-15 13:22 ` [PATCH v3 13/13] chardev: close an fd on failure path Vladimir Sementsov-Ogievskiy
2025-09-15 15:25 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMgvX7NsR_SUSmuJ@redhat.com \
--to=berrange@redhat.com \
--cc=leiyang@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).