qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Magnus Kulke <magnuskulke@linux.microsoft.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, "Eric Blake" <eblake@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Magnus Kulke" <magnus.kulke@linux.microsoft.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Phil Dennis-Jordan" <phil@philjordan.eu>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Magnus Kulke" <magnus.kulke@microsoft.com>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Zhao Liu" <zhao1.liu@intel.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	"Cameron Esfahani" <dirty@apple.com>,
	"Wei Liu" <wei.liu@kernel.org>, "Wei Liu" <liuwe@microsoft.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Roman Bolshakov" <rbolshakov@ddn.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v3 10/26] accel/mshv: Add vCPU creation and execution loop
Date: Tue, 16 Sep 2025 11:33:01 +0200	[thread overview]
Message-ID: <aMkuzbCrzx0ftpGY@example.com> (raw)
In-Reply-To: <aK7q91-sjFp8nVIG@redhat.com>

On Wed, Aug 27, 2025 at 12:24:39PM +0100, Daniel P. Berrangé wrote:
> So every MSHV  vCPU has a corresponding Linux thread, similar
> to the model with KVM.  In libvirt we rely on the vCPU thread
> being controllable with all the normal Linux process related
> APIs. For example, setting thread CPU affinity, setting NUMA
> memory policy, setting scheduler priorities, putting threads
> into cgroups and applying a wide variety of cgroup controls.
> 
> Will there be any significant "gotchas" with the threads for
> MSHV vCPUs, that would mean the above libvirt controls would
> either raise errors, or silently not have any effect ?
> 

Hi Daniel,

I am not aware of any such gotchas. The MSHV vCPU threads should
be regular threads that spend most of their time blocked in
ioctl(MSHV_RUN) calls, and as such they should be controllable by
the facilities you mentioned. I know that that folks who tested this
code have been using numactl for reliable performance assessments
without running into issues.

best,

magnus


  parent reply	other threads:[~2025-09-16  9:33 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-07 14:39 [PATCH v3 00/26] Implementing a MSHV (Microsoft Hypervisor) accelerator Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 01/26] accel: Add Meson and config support for MSHV accelerator Magnus Kulke
2025-08-11 17:51   ` Wei Liu
2025-08-27 10:27   ` Daniel P. Berrangé
2025-08-07 14:39 ` [PATCH v3 02/26] target/i386/emulate: Allow instruction decoding from stream Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 03/26] target/i386/mshv: Add x86 decoder/emu implementation Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 04/26] hw/intc: Generalize APIC helper names from kvm_* to accel_* Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 05/26] include/hw/hyperv: Add MSHV ABI header definitions Magnus Kulke
2025-08-27 10:44   ` Daniel P. Berrangé
2025-08-07 14:39 ` [PATCH v3 06/26] linux-headers/linux: Add mshv.h headers Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 07/26] accel/mshv: Add accelerator skeleton Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 08/26] accel/mshv: Register memory region listeners Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 09/26] accel/mshv: Initialize VM partition Magnus Kulke
2025-08-27 11:15   ` Daniel P. Berrangé
2025-08-07 14:39 ` [PATCH v3 10/26] accel/mshv: Add vCPU creation and execution loop Magnus Kulke
2025-08-27 11:24   ` Daniel P. Berrangé
2025-08-27 17:39     ` Wei Liu
2025-09-16  9:33     ` Magnus Kulke [this message]
2025-08-07 14:39 ` [PATCH v3 11/26] accel/mshv: Add vCPU signal handling Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 12/26] target/i386/mshv: Add CPU create and remove logic Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 13/26] target/i386/mshv: Implement mshv_store_regs() Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 14/26] target/i386/mshv: Implement mshv_get_standard_regs() Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 15/26] target/i386/mshv: Implement mshv_get_special_regs() Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 16/26] target/i386/mshv: Implement mshv_arch_put_registers() Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 17/26] target/i386/mshv: Set local interrupt controller state Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 18/26] target/i386/mshv: Register CPUID entries with MSHV Magnus Kulke
2025-08-27 11:29   ` Daniel P. Berrangé
2025-09-16 10:49     ` Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 19/26] target/i386/mshv: Register MSRs " Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 20/26] target/i386/mshv: Integrate x86 instruction decoder/emulator Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 21/26] target/i386/mshv: Write MSRs to the hypervisor Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 22/26] target/i386/mshv: Implement mshv_vcpu_run() Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 23/26] accel/mshv: Handle overlapping mem mappings Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 24/26] docs: Add mshv to documentation Magnus Kulke
2025-08-27 11:33   ` Daniel P. Berrangé
2025-08-07 14:39 ` [PATCH v3 25/26] MAINTAINERS: Add maintainers for mshv accelerator Magnus Kulke
2025-08-07 14:39 ` [PATCH v3 26/26] qapi/accel: Allow to query mshv capabilities Magnus Kulke
2025-08-07 19:22   ` Wei Liu
2025-08-13  0:37     ` Wei Liu
2025-08-27 11:39   ` Daniel P. Berrangé
2025-08-11 17:59 ` [PATCH v3 00/26] Implementing a MSHV (Microsoft Hypervisor) accelerator Wei Liu
2025-09-11  6:59 ` Michael S. Tsirkin
2025-09-11 15:21   ` Paolo Bonzini
2025-09-11 16:07     ` Wei Liu
2025-09-11 16:26     ` Magnus Kulke
2025-09-18  4:08   ` Mohamed Mediouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aMkuzbCrzx0ftpGY@example.com \
    --to=magnuskulke@linux.microsoft.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=dirty@apple.com \
    --cc=eblake@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=liuwe@microsoft.com \
    --cc=magnus.kulke@linux.microsoft.com \
    --cc=magnus.kulke@microsoft.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=phil@philjordan.eu \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rbolshakov@ddn.com \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    --cc=wangyanan55@huawei.com \
    --cc=wei.liu@kernel.org \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).