Re: More check-functional asset download issues

["Daniel P. Berrangé" <berrange@redhat.com>]

On Wed, Sep 17, 2025 at 10:49:56AM -0700, Richard Henderson wrote:
> Hi,
> 
> We have
> 
>   https://patchew.org/QEMU/20250829142616.2633254-1-berrange@redhat.com/
> 
> in master already, but are still seeing up front failures:
> 
>   https://gitlab.com/qemu-project/qemu/-/jobs/11391070330
>   https://gitlab.com/qemu-project/qemu/-/jobs/11391070366
> 
> 2025-09-17 17:26:56,222 - qemu-test - INFO - Downloading https://github.com/legoater/qemu-ppc-boot/raw/refs/heads/main/buildroot/qemu_ppc64_e5500-2023.11-8-gdcd9f0f6eb-20240104/uImage
> to /builds/qemu-project/qemu/functional-cache/download/2478187c455d6cca3984e9dfde9c635d824ea16236b85fd6b4809f744706deda...
> Traceback (most recent call last):
>   File "/builds/qemu-project/qemu/tests/functional/qemu_test/asset.py", line 135, in fetch
>     with urllib.request.urlopen(self.url) as resp:
>   File "/usr/lib64/python3.9/urllib/request.py", line 214, in urlopen
>     return opener.open(url, data, timeout)
>   File "/usr/lib64/python3.9/urllib/request.py", line 517, in open
>     response = self._open(req, data)
>   File "/usr/lib64/python3.9/urllib/request.py", line 534, in _open
>     result = self._call_chain(self.handle_open, protocol, protocol +
>   File "/usr/lib64/python3.9/urllib/request.py", line 494, in _call_chain
>     result = func(*args)
>   File "/usr/lib64/python3.9/urllib/request.py", line 1389, in https_open
>     return self.do_open(http.client.HTTPSConnection, req,
>   File "/usr/lib64/python3.9/urllib/request.py", line 1350, in do_open
>     r = h.getresponse()
>   File "/usr/lib64/python3.9/http/client.py", line 1377, in getresponse
>     response.begin()
>   File "/usr/lib64/python3.9/http/client.py", line 320, in begin
>     version, status, reason = self._read_status()
>   File "/usr/lib64/python3.9/http/client.py", line 289, in _read_status
>     raise RemoteDisconnected("Remote end closed connection without"

Sigh, yet another type of exception that urlopen may raise.... this is
why apps end up wanting to catch Exception rather than try to match
all possible specialized subclasses.

We already catch Exception but treat it as a fatal error. I'm inclined
to switch it to be a transient error, so that we don't abort the CI
jobs, just skip tests with msising assets, as we do for HTTP error
codes and for DNS resolution errors.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|