From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65074CAC59A for ; Thu, 18 Sep 2025 08:25:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uz9vp-0000wp-FL; Thu, 18 Sep 2025 04:23:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uz9vn-0000we-0D for qemu-devel@nongnu.org; Thu, 18 Sep 2025 04:23:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uz9vh-0008K1-QO for qemu-devel@nongnu.org; Thu, 18 Sep 2025 04:23:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758183826; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=1ig3Ed+oAMQbNsksY1F9w/JiaiBXXfxyxhlHyuoL9KM=; b=TFJ8oRdf5wi1CwwxwYmtCcUXhcWdWV7mVfQYSUFllN6okdXcRKL/SD0wHFcIsbSba86Sb3 XX0Y/3y4j7sprA0lfJaeRy59ssB/a2YyLwU8H2fGYtzW7OGAmUvEErXRy+2vZKzs0aJp41 +ofSSFef4ah5xwsyfEDde3THTtkvFeU= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-539-DRs_8fHaPH68j_sPzbE3iw-1; Thu, 18 Sep 2025 04:23:43 -0400 X-MC-Unique: DRs_8fHaPH68j_sPzbE3iw-1 X-Mimecast-MFC-AGG-ID: DRs_8fHaPH68j_sPzbE3iw_1758183821 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0C43E180048E; Thu, 18 Sep 2025 08:23:41 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.161]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 721491955F21; Thu, 18 Sep 2025 08:23:36 +0000 (UTC) Date: Thu, 18 Sep 2025 09:23:33 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Filip Hejsek Cc: qemu-devel@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Paolo Bonzini , "Michael S. Tsirkin" , Laurent Vivier , Amit Shah , Markus Armbruster , Eric Blake , Eduardo Habkost , Marcel Apfelbaum , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Yanan Wang , Zhao Liu , Szymon Lukasz Subject: Re: [PATCH v4 08/10] virtio-serial-bus: add terminal resize messages Message-ID: References: <20250912-console-resize-v4-0-7925e444afc4@gmail.com> <20250912-console-resize-v4-8-7925e444afc4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250912-console-resize-v4-8-7925e444afc4@gmail.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Sep 12, 2025 at 05:39:53AM +0200, Filip Hejsek wrote: > From: Szymon Lukasz > > Implement the part of the virtio spec that allows to notify the virtio > driver about terminal resizes. The virtio spec contains two methods to > achieve that: > > For legacy drivers, we have only one port and we put the terminal size > in the config space and inject the config changed interrupt. > > For multiport devices, we use the control virtqueue to send a packet > containing the terminal size. Note that old versions of the Linux kernel > used an incorrect order for the fields (rows then cols instead of cols > then rows), until it was fixed by commit 5326ab737a47278dbd16ed3ee7380b26c7056ddd. > > As a result, when using a Linux kernel older than 6.15, the number of rows > and columns will be swapped. > > Signed-off-by: Szymon Lukasz > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Filip Hejsek > --- > hw/char/trace-events | 1 + > hw/char/virtio-serial-bus.c | 43 +++++++++++++++++++++++++++++++++++++-- > hw/core/machine.c | 4 +++- > include/hw/virtio/virtio-serial.h | 5 +++++ > 4 files changed, 50 insertions(+), 3 deletions(-) > > diff --git a/hw/char/trace-events b/hw/char/trace-events > index 05a33036c12070242c2b193c19011839d623bec4..9a975ab1e2a525a9391d0f0a85ddbe80aa6361fc 100644 > --- a/hw/char/trace-events > +++ b/hw/char/trace-events > @@ -11,6 +11,7 @@ serial_update_parameters(uint64_t baudrate, char parity, int data_bits, int stop > > # virtio-serial-bus.c > virtio_serial_send_control_event(unsigned int port, uint16_t event, uint16_t value) "port %u, event %u, value %u" > +virtio_serial_send_console_resize(unsigned int port, uint16_t cols, uint16_t rows) "port %u, cols %u, rows %u" > virtio_serial_throttle_port(unsigned int port, bool throttle) "port %u, throttle %d" > virtio_serial_handle_control_message(uint16_t event, uint16_t value) "event %u, value %u" > virtio_serial_handle_control_message_port(unsigned int port) "port %u" > diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c > index 673c50f0be08ef9b7142c16eaf8e6e31c7a00ca5..1d2963efcd74494a1f0d428f8ace0e72bb4c6647 100644 > --- a/hw/char/virtio-serial-bus.c > +++ b/hw/char/virtio-serial-bus.c > @@ -260,6 +260,43 @@ static size_t send_control_event(VirtIOSerial *vser, uint32_t port_id, > return send_control_msg(vser, &cpkt, sizeof(cpkt)); > } > > +/* > + * This struct should be added to the Linux kernel uapi headers > + * and later imported to standard-headers/linux/virtio_console.h > + */ > +struct virtio_console_resize { > + __virtio16 cols; > + __virtio16 rows; > +}; > + > +void virtio_serial_send_console_resize(VirtIOSerialPort *port, > + uint16_t cols, uint16_t rows) > +{ > + VirtIOSerial *vser = port->vser; > + VirtIODevice *vdev = VIRTIO_DEVICE(vser); > + > + trace_virtio_serial_send_console_resize(port->id, cols, rows); > + > + if (virtio_vdev_has_feature(vdev, VIRTIO_CONSOLE_F_MULTIPORT)) { > + struct { > + struct virtio_console_control control; > + struct virtio_console_resize resize; > + } buffer; > + > + virtio_stl_p(vdev, &buffer.control.id, port->id); > + virtio_stw_p(vdev, &buffer.control.event, VIRTIO_CONSOLE_RESIZE); > + virtio_stw_p(vdev, &buffer.resize.cols, cols); > + virtio_stw_p(vdev, &buffer.resize.rows, rows); > + > + send_control_msg(vser, &buffer, sizeof(buffer)); > + > + } else if (virtio_vdev_has_feature(vdev, VIRTIO_CONSOLE_F_SIZE)) { > + vser->port0_cols = cols; > + vser->port0_rows = rows; > + virtio_notify_config(vdev); IIUC, we should skip sending this if port->id does NOT reflect the primary port 0, as the virtio spec indicates F_SIZE only applies to port 0 unless we have F_MULTIPORT set. > + } > +} > + > /* Functions for use inside qemu to open and read from/write to ports */ > int virtio_serial_open(VirtIOSerialPort *port) > { > @@ -571,8 +608,8 @@ static void get_config(VirtIODevice *vdev, uint8_t *config_data) > struct virtio_console_config *config = > (struct virtio_console_config *)config_data; > > - config->cols = 0; > - config->rows = 0; > + config->cols = virtio_tswap16(vdev, vser->port0_cols); > + config->rows = virtio_tswap16(vdev, vser->port0_rows); > config->max_nr_ports = virtio_tswap32(vdev, > vser->serial.max_virtserial_ports); > } > @@ -1158,6 +1195,8 @@ static const Property virtio_serial_properties[] = { > 31), > DEFINE_PROP_BIT64("emergency-write", VirtIOSerial, host_features, > VIRTIO_CONSOLE_F_EMERG_WRITE, true), > + DEFINE_PROP_BIT64("console-size", VirtIOSerial, host_features, > + VIRTIO_CONSOLE_F_SIZE, true), > }; > > static void virtio_serial_class_init(ObjectClass *klass, const void *data) > diff --git a/hw/core/machine.c b/hw/core/machine.c > index 38c949c4f2ce4a117cbfca62f56919711ce392b4..74a747ec6578c958b35e1f9712e5dbed7bca72e8 100644 > --- a/hw/core/machine.c > +++ b/hw/core/machine.c > @@ -37,7 +37,9 @@ > #include "hw/virtio/virtio-iommu.h" > #include "audio/audio.h" > > -GlobalProperty hw_compat_10_1[] = {}; > +GlobalProperty hw_compat_10_1[] = { > + { "virtio-serial-device", "console-size", "off" }, > +}; > const size_t hw_compat_10_1_len = G_N_ELEMENTS(hw_compat_10_1); > > GlobalProperty hw_compat_10_0[] = { > diff --git a/include/hw/virtio/virtio-serial.h b/include/hw/virtio/virtio-serial.h > index d87c62eab7a270809daf47f932a73dd1fa3d5a6e..81efa853f804a52866890a9ec2c71bfbcabca4a0 100644 > --- a/include/hw/virtio/virtio-serial.h > +++ b/include/hw/virtio/virtio-serial.h > @@ -187,6 +187,8 @@ struct VirtIOSerial { > virtio_serial_conf serial; > > uint64_t host_features; > + > + uint16_t port0_cols, port0_rows; > }; > > /* Interface to the virtio-serial bus */ > @@ -221,6 +223,9 @@ size_t virtio_serial_guest_ready(VirtIOSerialPort *port); > */ > void virtio_serial_throttle_port(VirtIOSerialPort *port, bool throttle); > > +void virtio_serial_send_console_resize(VirtIOSerialPort *port, > + uint16_t cols, uint16_t rows); > + > #define TYPE_VIRTIO_SERIAL "virtio-serial-device" > OBJECT_DECLARE_SIMPLE_TYPE(VirtIOSerial, VIRTIO_SERIAL) > > > -- > 2.51.0 > > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|