Re: [PATCH v4 03/27] target/i386/mshv: Add x86 decoder/emu implementation

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Sep 16, 2025 at 06:48:23PM +0200, Magnus Kulke wrote:
> The MSHV accelerator requires a x86 decoder/emulator in userland to
> emulate MMIO instructions. This change contains the implementations for
> the generalized i386 instruction decoder/emulator.
> 
> Signed-off-by: Magnus Kulke <magnuskulke@linux.microsoft.com>
> ---
>  include/system/mshv.h           |  25 +++
>  target/i386/cpu.h               |   2 +-
>  target/i386/emulate/meson.build |   7 +-
>  target/i386/meson.build         |   2 +
>  target/i386/mshv/meson.build    |   7 +
>  target/i386/mshv/x86.c          | 297 ++++++++++++++++++++++++++++++++
>  6 files changed, 337 insertions(+), 3 deletions(-)
>  create mode 100644 include/system/mshv.h
>  create mode 100644 target/i386/mshv/meson.build
>  create mode 100644 target/i386/mshv/x86.c
> 

> diff --git a/target/i386/mshv/meson.build b/target/i386/mshv/meson.build
> new file mode 100644
> index 0000000000..8ddaa7c11d
> --- /dev/null
> +++ b/target/i386/mshv/meson.build
> @@ -0,0 +1,7 @@
> +i386_mshv_ss = ss.source_set()
> +
> +i386_mshv_ss.add(files(
> +  'x86.c',
> +))
> +
> +i386_system_ss.add_all(when: 'CONFIG_MSHV', if_true: i386_mshv_ss)

FYI, we expect the SPDX-License-Identifier to be present on
all new files[1] added to git, even if they're relatively simple
in some cases like this meson.build. 

If you run the series though checkpatch.pl it should tell
you which files you've missed.

With regards,
Daniel

[1] exception for non-plain text files, or if there's some reason it
    would cause problems.
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|