From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95DC7CAC5BB for ; Wed, 1 Oct 2025 12:19:03 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3vmm-0003sw-IO; Wed, 01 Oct 2025 08:18:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3vmk-0003ql-JJ for qemu-devel@nongnu.org; Wed, 01 Oct 2025 08:18:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3vmX-0007D1-HU for qemu-devel@nongnu.org; Wed, 01 Oct 2025 08:18:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759321079; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=82Huluz/PdMBDqbXQAS4eu3qVo/kxILV7fvb6MRwP2A=; b=V1BMb9mGkXkIrKxcmUHsR8w0Pyhu77qOaUNVDAg5eLszXi/5VvZlJRofGfreRmA4dcR81x X1Lt/e0PhLN5sveZSK8PBapQmKsFWyOvV5uuqfD1vUt3dEevbQHWO54Mmsk99o2uo6Hneu INeIyRko9c4SZ3PFhMvN/Yd7rGUzF1o= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-439-rQm_Zeg5Ony9Qm7EX6qWzA-1; Wed, 01 Oct 2025 08:17:56 -0400 X-MC-Unique: rQm_Zeg5Ony9Qm7EX6qWzA-1 X-Mimecast-MFC-AGG-ID: rQm_Zeg5Ony9Qm7EX6qWzA_1759321074 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1052019560B5; Wed, 1 Oct 2025 12:17:54 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.187]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F022A30002C5; Wed, 1 Oct 2025 12:17:47 +0000 (UTC) Date: Wed, 1 Oct 2025 13:17:44 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Magnus Kulke Cc: qemu-devel@nongnu.org, Markus Armbruster , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Cameron Esfahani , Paolo Bonzini , Thomas Huth , Richard Henderson , Wei Liu , Cornelia Huck , "Michael S. Tsirkin" , "Dr. David Alan Gilbert" , Roman Bolshakov , Phil Dennis-Jordan , Marcel Apfelbaum , Zhao Liu , Eduardo Habkost , Magnus Kulke , Wei Liu , Eric Blake , Yanan Wang , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH v4 25/27] target/i386/mshv: Use preallocated page for hvcall Message-ID: References: <20250916164847.77883-1-magnuskulke@linux.microsoft.com> <20250916164847.77883-26-magnuskulke@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250916164847.77883-26-magnuskulke@linux.microsoft.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.518, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Sep 16, 2025 at 06:48:45PM +0200, Magnus Kulke wrote: > There are hvcalls that are invoked during MMIO exits, the payload is of > dynamic size. To avoid heap allocations we can use preallocated pages as > in/out buffer for those calls. A page is reserved per vCPU and used for > set/get register hv calls. > > Signed-off-by: Magnus Kulke > --- > accel/mshv/mshv-all.c | 2 +- > include/system/mshv.h | 7 +++++++ > target/i386/mshv/mshv-cpu.c | 39 +++++++++++++++++++++++++------------ > 3 files changed, 35 insertions(+), 13 deletions(-) > > diff --git a/accel/mshv/mshv-all.c b/accel/mshv/mshv-all.c > index 2f7b325985..35a10f7a78 100644 > --- a/accel/mshv/mshv-all.c > +++ b/accel/mshv/mshv-all.c > @@ -398,8 +398,8 @@ static int mshv_init_vcpu(CPUState *cpu) > uint8_t vp_index = cpu->cpu_index; > int ret; > > - mshv_arch_init_vcpu(cpu); > cpu->accel = g_new0(AccelCPUState, 1); > + mshv_arch_init_vcpu(cpu); This change can either be dropped, or squashed into the earlier patch in this series that introduced this method. > > ret = mshv_create_vcpu(vm_fd, vp_index, &cpu->accel->cpufd); > if (ret < 0) { > diff --git a/target/i386/mshv/mshv-cpu.c b/target/i386/mshv/mshv-cpu.c > index 6b7e795a36..52afc6b303 100644 > --- a/target/i386/mshv/mshv-cpu.c > +++ b/target/i386/mshv/mshv-cpu.c > @@ -33,6 +33,11 @@ > > #include > > +#define MAX_SIZE(a, b) ((a) > (b) ? (a) : (b)) Isn't this the same as the existing 'MAX(a, b)' macro in osdep.h ? > +#define MAX_REGISTER_COUNT (MAX_SIZE(ARRAY_SIZE(STANDARD_REGISTER_NAMES), \ > + MAX_SIZE(ARRAY_SIZE(SPECIAL_REGISTER_NAMES), \ > + ARRAY_SIZE(FPU_REGISTER_NAMES)))) > + With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|