From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD4D3CAC5BB for ; Wed, 1 Oct 2025 12:16:44 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3vjm-0001by-9w; Wed, 01 Oct 2025 08:15:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3vjk-0001ZN-27 for qemu-devel@nongnu.org; Wed, 01 Oct 2025 08:15:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3vjS-0006Aq-Vt for qemu-devel@nongnu.org; Wed, 01 Oct 2025 08:15:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759320879; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=EwBhlQhPSZAtayivfLvyJgOAzDEXqz+RoU20rLYvK3c=; b=Y5LDGPyI5H7vyabSMzO9Ad9enHUkBRORuTlXDKRKWaHmWpeYUkZznDwqrYW5bHK0z7+xUh 793zwnfW3V+GwiewvTAQzirO1+6d1jnaEm2NKypjpcAY10lvJk8ziOU/kfwM2Qtb6zOTzn 6XLgJOwTTSt98TcqssJ8lxDHHX5z+ek= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-9yX6Q0PtN-2k1Ogvyps4bA-1; Wed, 01 Oct 2025 08:14:33 -0400 X-MC-Unique: 9yX6Q0PtN-2k1Ogvyps4bA-1 X-Mimecast-MFC-AGG-ID: 9yX6Q0PtN-2k1Ogvyps4bA_1759320869 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F404E1955DB8; Wed, 1 Oct 2025 12:14:27 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.187]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D7B1B1800577; Wed, 1 Oct 2025 12:14:20 +0000 (UTC) Date: Wed, 1 Oct 2025 13:14:17 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Magnus Kulke Cc: qemu-devel@nongnu.org, Markus Armbruster , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Cameron Esfahani , Paolo Bonzini , Thomas Huth , Richard Henderson , Wei Liu , Cornelia Huck , "Michael S. Tsirkin" , "Dr. David Alan Gilbert" , Roman Bolshakov , Phil Dennis-Jordan , Marcel Apfelbaum , Zhao Liu , Eduardo Habkost , Magnus Kulke , Wei Liu , Eric Blake , Yanan Wang , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH v4 24/27] qapi/accel: Allow to query mshv capabilities Message-ID: References: <20250916164847.77883-1-magnuskulke@linux.microsoft.com> <20250916164847.77883-25-magnuskulke@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250916164847.77883-25-magnuskulke@linux.microsoft.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.518, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Sep 16, 2025 at 06:48:44PM +0200, Magnus Kulke wrote: > From: Praveen K Paladugu > > Allow to query mshv capabilities via query-mshv QMP and info mshv HMP commands. > > Signed-off-by: Magnus Kulke > --- > hmp-commands-info.hx | 13 +++++++++++++ > hw/core/machine-hmp-cmds.c | 15 +++++++++++++++ > hw/core/machine-qmp-cmds.c | 14 ++++++++++++++ > include/monitor/hmp.h | 1 + > include/system/hw_accel.h | 1 + > qapi/accelerator.json | 29 +++++++++++++++++++++++++++++ > 6 files changed, 73 insertions(+) > diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c > index 6aca1a626e..e24bf0d97b 100644 > --- a/hw/core/machine-qmp-cmds.c > +++ b/hw/core/machine-qmp-cmds.c > @@ -28,6 +28,20 @@ > #include "system/runstate.h" > #include "system/system.h" > #include "hw/s390x/storage-keys.h" > +#include I think this is left over from a previous version of the patch that directly called stat() on the device node, and can be removed. > + > +/* > + * QMP query for MSHV > + */ > +MshvInfo *qmp_query_mshv(Error **errp) > +{ > + MshvInfo *info = g_malloc0(sizeof(*info)); > + > + info->enabled = mshv_enabled(); > + info->present = accel_find("mshv"); > + > + return info; > +} > > /* > * fast means: we NEVER interrupt vCPU threads to retrieve With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|