From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75A8FCAC5B8 for ; Thu, 2 Oct 2025 08:07:55 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v4EKh-0001ma-FP; Thu, 02 Oct 2025 04:06:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v4EKc-0001k3-LB for qemu-devel@nongnu.org; Thu, 02 Oct 2025 04:06:32 -0400 Received: from linux.microsoft.com ([13.77.154.182]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v4EKJ-0003WF-7j for qemu-devel@nongnu.org; Thu, 02 Oct 2025 04:06:28 -0400 Received: from example.com (unknown [167.220.208.67]) by linux.microsoft.com (Postfix) with ESMTPSA id D1B3C2012C19; Thu, 2 Oct 2025 01:05:55 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D1B3C2012C19 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1759392360; bh=u0WdOnmHfCoirE5Il5OiWbsniO3fceG77uSTLHwmOjA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jVu0Yh5Fcr3D+xTcW6019Sxwb231JXja3UH5Z7yYE/Zbjg4ZeLS1XGrgPZDIimCzz +uG9Udrf2rIUrI8g044kELiSdpsx6DXBw2GJDO7sT5EcMeOPUGYjoxIf+PluPlZKf/ ZTjLkV56ZUBmKdDSyqNV7g205vUJC22Xv0t2JV64= Date: Thu, 2 Oct 2025 10:05:52 +0200 From: Magnus Kulke To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Cc: qemu-devel@nongnu.org, Markus Armbruster , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Cameron Esfahani , Paolo Bonzini , Thomas Huth , Richard Henderson , Wei Liu , Cornelia Huck , "Michael S. Tsirkin" , "Dr. David Alan Gilbert" , Roman Bolshakov , Phil Dennis-Jordan , Marcel Apfelbaum , Zhao Liu , Eduardo Habkost , Magnus Kulke , Wei Liu , Eric Blake , Yanan Wang , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Alex =?iso-8859-1?Q?Benn=E9e?= Subject: Re: [PATCH v4 25/27] target/i386/mshv: Use preallocated page for hvcall Message-ID: References: <20250916164847.77883-1-magnuskulke@linux.microsoft.com> <20250916164847.77883-26-magnuskulke@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Received-SPF: pass client-ip=13.77.154.182; envelope-from=magnuskulke@linux.microsoft.com; helo=linux.microsoft.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Oct 01, 2025 at 01:17:44PM +0100, Daniel P. Berrangé wrote: > On Tue, Sep 16, 2025 at 06:48:45PM +0200, Magnus Kulke wrote: > > - mshv_arch_init_vcpu(cpu); > > cpu->accel = g_new0(AccelCPUState, 1); > > + mshv_arch_init_vcpu(cpu); > > This change can either be dropped, or squashed into the > earlier patch in this series that introduced this method. > right, this makes sense. > > +#define MAX_SIZE(a, b) ((a) > (b) ? (a) : (b)) > > Isn't this the same as the existing 'MAX(a, b)' macro in osdep.h ? > not quite, I don't think MAX can be used in a static assertion, but there's a MAX_CONST sibling that we can use.