From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 708E2CAC5B8 for ; Thu, 2 Oct 2025 13:15:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v4J8Y-0005Hj-BF; Thu, 02 Oct 2025 09:14:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v4J8V-0005Fn-Ll for qemu-devel@nongnu.org; Thu, 02 Oct 2025 09:14:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v4J8H-0006Fg-Ik for qemu-devel@nongnu.org; Thu, 02 Oct 2025 09:14:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759410839; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=saJDdhGX9bNuEH3vF7v5Ua6qg41pbki9hx5AkjeM2BQ=; b=TvXU+zXQvbmGmV+JwZNtdz5FgMW7W9XeT62mdxNqkGoNucHpo0T4j6M4xwKwMKJjPtkOEt H0NNJ4RQ3pYGw+F0bhRRuKv/uWJsyAgMwx41S0BIJKKQ5dKDaHyKWoJ0vq45bKOcwN/7BT Fsma6nKyRuo2T9+0TOopKKihuXaTfoA= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-445-OQlHdB_bMK-CuyAzytC1Yw-1; Thu, 02 Oct 2025 09:13:56 -0400 X-MC-Unique: OQlHdB_bMK-CuyAzytC1Yw-1 X-Mimecast-MFC-AGG-ID: OQlHdB_bMK-CuyAzytC1Yw_1759410835 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0CC5418004D4; Thu, 2 Oct 2025 13:13:55 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.93]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2CEF83000198; Thu, 2 Oct 2025 13:13:52 +0000 (UTC) Date: Thu, 2 Oct 2025 14:13:50 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Gustavo Romero Cc: qemu-devel@nongnu.org, alex.bennee@linaro.org, thuth@redhat.com, qemu-arm@nongnu.org Subject: Re: [PATCH v5 8/9] tests/functional: Adapt reverse_debugging to run w/o Avocado Message-ID: References: <20251002020432.54443-1-gustavo.romero@linaro.org> <20251002020432.54443-9-gustavo.romero@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251002020432.54443-9-gustavo.romero@linaro.org> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.451, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, T_SPF_HELO_TEMPERROR=0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Oct 02, 2025 at 02:04:31AM +0000, Gustavo Romero wrote: > This commit removes Avocado as a dependency for running the > reverse_debugging test. > > The main benefit, beyond eliminating an extra dependency, is that there > is no longer any need to handle GDB packets manually. This removes the > need for ad-hoc functions dealing with endianness and arch-specific > register numbers, making the test easier to read. The timeout variable > is also removed, since Meson now manages timeouts automatically. > > reverse_debugging now uses the pygdbmi module to interact with GDB, if > it's available in the test environment, otherwise the test is skipped. > GDB is detect via the QEMU_TEST_GDB env. variable. > > This commit also significantly improves the output for the test and > now prints all the GDB commands used in sequence. It also adds > some clarifications to existing comments, for example, clarifying that > once the replay-break is reached, a SIGINT is captured in GDB. > > reverse_debugging is kept "skipped" for aarch64, ppc64, and x86_64, so > won't run unless QEMU_TEST_FLAKY_TESTS=1 is set in the test environment, > before running 'make check-functional' or 'meson test [...]'. > > Signed-off-by: Gustavo Romero > --- > tests/functional/reverse_debugging.py | 138 ++++++++++++++------------ > 1 file changed, 74 insertions(+), 64 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|