From: Kevin Wolf <kwolf@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-block@nongnu.org, Hanna Czenczek <hreitz@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH 1/3] tests/qemu-iotests/184: Fix skip message for qemu-img without throttle
Date: Thu, 2 Oct 2025 16:05:01 +0200 [thread overview]
Message-ID: <aN6GjaSvTdWkpL_j@redhat.com> (raw)
In-Reply-To: <20250910153727.226217-2-thuth@redhat.com>
Am 10.09.2025 um 17:37 hat Thomas Huth geschrieben:
> From: Thomas Huth <thuth@redhat.com>
>
> If qemu-img does not support throttling, test 184 currently skips
> with the message:
>
> not suitable for this image format: raw
>
> But that's wrong, it's not about the image format, it's about the
> throttling not being available in qemu-img. Thus fix this by using
> _notrun with a proper message instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2025-10-02 14:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 15:37 [PATCH 0/3] tests/qemu-iotests: Improve test detection for meson Thomas Huth
2025-09-10 15:37 ` [PATCH 1/3] tests/qemu-iotests/184: Fix skip message for qemu-img without throttle Thomas Huth
2025-10-02 14:05 ` Kevin Wolf [this message]
2025-09-10 15:37 ` [PATCH 2/3] tests/qemu-iotests: Improve the dry run list to speed up thorough testing Thomas Huth
2025-10-02 14:04 ` Kevin Wolf
2025-10-02 14:33 ` Thomas Huth
2025-10-13 12:51 ` Kevin Wolf
2025-09-10 15:37 ` [PATCH 3/3] tests/qemu-iotest: Add more image formats to the " Thomas Huth
2025-10-02 14:07 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN6GjaSvTdWkpL_j@redhat.com \
--to=kwolf@redhat.com \
--cc=hreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).